Merge pull request #2703 from RedisInsight/e2e/feature/RI-4815_portion-of-string

E2e/feature/ri 4815 portion of string

Author: vlad-dargel

tests/e2e/common-actions/databases-actions.ts

@@ -69,6 +69,25 @@ export class DatabasesActions {
         }
         return matchedFiles;
     }
+
+    /**
+     * Get files count by name starts from directory
+     * @param dir The path directory of file
+     * @param fileStarts The file name should start from
+     */
+    async getFileCount(dir: string, fileStarts: string): Promise<number> {
+        if (fs.existsSync(dir)) {
+            const matchedFiles: string[] = [];
+            const files = fs.readdirSync(dir);
+            for (const file of files) {
+                if (file.startsWith(fileStarts)) {
+                    matchedFiles.push(file);
+                }
+            }
+            return matchedFiles.length;
+        }
+        return 0;
+    }
 }
 
 /**

tests/e2e/pageObjects/browser-page.ts

@@ -107,6 +107,8 @@ export class BrowserPage extends InstancePage {
     clearFilterHistoryBtn = Selector('[data-testid=clear-history-btn]');
     guideLinksBtn = Selector('[data-testid^=guide-button-]');
     backToBrowserBtn = Selector('[data-testid=back-right-panel-btn]');
+    loadAllBtn = Selector('[data-testid=load-all-value-btn]');
+    downloadAllValueBtn = Selector('[data-testid=download-all-value-btn]');
     //CONTAINERS
     streamGroupsContainer = Selector('[data-testid=stream-groups-container]');
     streamConsumersContainer = Selector('[data-testid=stream-consumers-container]');

tests/e2e/tests/web/critical-path/browser/large-data.e2e.ts

@@ -1,17 +1,25 @@
+import * as fs from 'fs';
+import { join as joinPath } from 'path';
 import { DatabaseHelper } from '../../../../helpers/database';
 import { Common } from '../../../../helpers/common';
 import { rte } from '../../../../helpers/constants';
 import { BrowserPage } from '../../../../pageObjects';
-import { commonUrl, ossStandaloneConfig } from '../../../../helpers/conf';
+import { commonUrl, fileDownloadPath, ossStandaloneConfig } from '../../../../helpers/conf';
 import { DatabaseAPIRequests } from '../../../../helpers/api/api-database';
 import { APIKeyRequests } from '../../../../helpers/api/api-keys';
+import { StringKeyParameters } from '../../../../pageObjects/browser-page';
+import { DatabasesActions } from '../../../../common-actions/databases-actions';
 
 const browserPage = new BrowserPage();
 const databaseHelper = new DatabaseHelper();
 const databaseAPIRequests = new DatabaseAPIRequests();
 const apiKeyRequests = new APIKeyRequests();
+const databasesActions = new DatabasesActions();
 
 let keyName = Common.generateWord(10);
+let bigKeyName = Common.generateWord(10);
+let foundStringDownloadedFiles = 0;
+const downloadedFile = 'string_value';
 
 fixture `Cases with large data`
     .meta({ type: 'critical_path', rte: rte.standalone })
@@ -46,3 +54,70 @@ test('Verify that user can see relevant information about key size', async t =>
     await t.expect(keySizeText).contains('KB', 'Key measure not correct');
     await t.expect(+keySize).gt(10, 'Key size value not correct');
 });
+test
+    .before(async() => {
+        await databaseHelper.acceptLicenseTermsAndAddDatabaseApi(ossStandaloneConfig);
+    })
+    .after(async() => {
+        // Clear and delete database
+        await apiKeyRequests.deleteKeyByNameApi(keyName, ossStandaloneConfig.databaseName);
+        await apiKeyRequests.deleteKeyByNameApi(bigKeyName, ossStandaloneConfig.databaseName);
+        await databaseAPIRequests.deleteStandaloneDatabaseApi(ossStandaloneConfig);
+        // Delete downloaded file
+        const foundDownloadedFiles = await databasesActions.findFilesByFileStarts(fileDownloadPath, downloadedFile);
+        fs.unlinkSync(joinPath(fileDownloadPath, foundDownloadedFiles[0]));
+    })('Verify that user can download String key value as txt file when it has > 5000 characters', async t => {
+        const disabledEditTooltip = 'Load the entire value to edit it';
+        const disabledFormattersTooltip = 'Load the entire value to select a format';
+        keyName = Common.generateWord(10);
+        bigKeyName = Common.generateWord(10);
+        // Create string key with 5000 characters
+        const length = 5000;
+        const keyValue = Common.generateWord(length);
+        const stringKeyParameters: StringKeyParameters = {
+            keyName: keyName,
+            value: keyValue
+        };
+        const bigStringKeyParameters: StringKeyParameters = {
+            keyName: bigKeyName,
+            value: keyValue + 1
+        };
+
+        await apiKeyRequests.addStringKeyApi(stringKeyParameters, ossStandaloneConfig);
+        await apiKeyRequests.addStringKeyApi(bigStringKeyParameters, ossStandaloneConfig);
+        await browserPage.reloadPage();
+        await browserPage.openKeyDetails(keyName);
+        await t.expect(browserPage.loadAllBtn.exists).notOk('Load All button displayed for 5000 length String key');
+        await t.expect(browserPage.downloadAllValueBtn.exists).notOk('Download All button displayed for 5000 length String key');
+
+        await browserPage.openKeyDetails(bigKeyName);
+        await t.expect(browserPage.editKeyValueButton.hasAttribute('disabled')).ok('Edit button not disabled for String > 5000');
+        await t.expect(browserPage.formatSwitcher.hasAttribute('disabled')).ok('Formatters control not disabled for String > 5000');
+
+        // Verify that user can see "Load the entire value to edit it." tooltip when hovering on disabled edit button before loading all
+        await t.hover(browserPage.editKeyValueButton.parent());
+        await t.expect(browserPage.tooltip.textContent).eql(disabledEditTooltip, 'Edit button tooltip contains invalid message');
+
+        // Verify that user can see "Load the entire value to select a format." tooltip when hovering on disabled formatters button before loading all
+        await t.hover(browserPage.formatSwitcher);
+        await t.expect(browserPage.tooltip.textContent).eql(disabledFormattersTooltip, 'Edit button tooltip contains invalid message');
+
+        // Verify that user can see String key value with only 5000 characters uploaded if length is more than 5000
+        await t.expect((await browserPage.stringKeyValueInput.textContent).length).eql(stringKeyParameters.value.length, 'String key > 5000 value is fully loaded by default');
+
+        await t.click(browserPage.loadAllBtn);
+        // Verify that user can see "Load all" button for String Key with more than 5000 characters and see full value by clicking on it
+        await t.expect((await browserPage.stringKeyValueInput.textContent).length).eql(bigStringKeyParameters.value.length, 'String key > 5000 value is not fully loaded after clicking Load All');
+        await t.expect(browserPage.editKeyValueButton.hasAttribute('disabled')).notOk('Edit button disabled for String > 5000 which is fully loaded');
+        await t.expect(browserPage.formatSwitcher.hasAttribute('disabled')).notOk('Formatters control disabled for String > 5000 which is fully loaded');
+
+        // Verify that user can see not fully loaded String key with > 5000 characters after clicking on Refresh button
+        await t.click(browserPage.refreshKeyButton);
+        await t.expect(browserPage.loadAllBtn.exists).ok('Load All button not displayed for 5000 length String key after Refresh');
+
+        // Verify that user can download String key value as txt file when it has > 5000 characters
+        await t.click(browserPage.downloadAllValueBtn);
+        // Verify that user can see default file name is “string_value” when downloading String key value
+        foundStringDownloadedFiles = await databasesActions.getFileCount(fileDownloadPath, downloadedFile);
+        await t.expect(foundStringDownloadedFiles).gt(0, 'String value file not saved');
+    });

tests/e2e/tests/web/critical-path/monitor/save-commands.e2e.ts

@@ -1,46 +1,29 @@
 import * as fs from 'fs';
 import * as os from 'os';
-import { join as joinPath } from 'path';
 import { DatabaseHelper } from '../../../../helpers/database';
 import { BrowserPage } from '../../../../pageObjects';
 import {
     commonUrl,
+    fileDownloadPath,
     ossStandaloneConfig
 } from '../../../../helpers/conf';
 import { rte } from '../../../../helpers/constants';
 import { DatabaseAPIRequests } from '../../../../helpers/api/api-database';
+import { DatabasesActions } from '../../../../common-actions/databases-actions';
 
 const browserPage = new BrowserPage();
 const databaseHelper = new DatabaseHelper();
 const databaseAPIRequests = new DatabaseAPIRequests();
+const databasesActions = new DatabasesActions();
 
 const tempDir = os.tmpdir();
-let downloadedFilePath = '';
-
-async function getFileDownloadPath(): Promise<string> {
-    return joinPath(os.homedir(), 'Downloads');
-}
-
-async function findByFileStarts(dir: string): Promise<number> {
-    if (fs.existsSync(dir)) {
-        const matchedFiles: string[] = [];
-        const files = fs.readdirSync(dir);
-        for (const file of files) {
-            if (file.startsWith('test_standalone')) {
-                matchedFiles.push(file);
-            }
-        }
-        return matchedFiles.length;
-    }
-    return 0;
-}
+const fileStarts = 'test_standalone';
 
 fixture `Save commands`
     .meta({ type: 'critical_path', rte: rte.standalone })
     .page(commonUrl)
     .beforeEach(async() => {
         await databaseHelper.acceptLicenseTermsAndAddDatabaseApi(ossStandaloneConfig);
-        downloadedFilePath = await getFileDownloadPath();
     })
     .afterEach(async() => {
         // Delete database
@@ -111,22 +94,22 @@ test('Verify the Profiler Button panel when toggle was switched to ON and user p
 });
 test('Verify that when user see the toggle is OFF - Profiler logs are not being saved', async t => {
     // Remember the number of files in Temp
-    const numberOfDownloadFiles = await findByFileStarts(downloadedFilePath);
+    const numberOfDownloadFiles = await databasesActions.getFileCount(fileDownloadPath, fileStarts);
 
     // Start Monitor without Save logs
     await browserPage.Profiler.startMonitor();
     await t.wait(3000);
     // Check the download files
-    await t.expect(await findByFileStarts(downloadedFilePath)).eql(numberOfDownloadFiles, 'The Profiler logs are saved');
+    await t.expect(await databasesActions.getFileCount(fileDownloadPath, fileStarts)).eql(numberOfDownloadFiles, 'The Profiler logs are saved');
 });
 test('Verify that when user see the toggle is ON - Profiler logs are being saved', async t => {
     // Remember the number of files in Temp
-    const numberOfDownloadFiles = await findByFileStarts(downloadedFilePath);
+    const numberOfDownloadFiles = await databasesActions.getFileCount(fileDownloadPath, fileStarts);
 
     // Start Monitor with Save logs
     await browserPage.Profiler.startMonitorWithSaveLog();
     // Download logs and check result
     await browserPage.Profiler.stopMonitor();
     await t.click(browserPage.Profiler.downloadLogButton);
-    await t.expect(await findByFileStarts(downloadedFilePath)).gt(numberOfDownloadFiles, 'The Profiler logs not saved', { timeout: 5000 });
+    await t.expect(await databasesActions.getFileCount(fileDownloadPath, fileStarts)).gt(numberOfDownloadFiles, 'The Profiler logs not saved', { timeout: 5000 });
 });