Merge pull request #3579 from RedisInsight/be/feature/RI-5848-update-recommendation

Show update redis recommendation when version is less than 7.3

Author: vlad-dargel

redisinsight/api/src/common/constants/recommendations.ts

@@ -18,7 +18,7 @@ export const BIG_SETS_RECOMMENDATION_LENGTH = 1_000;
 export const BIG_AMOUNT_OF_CONNECTED_CLIENTS_RECOMMENDATION_CLIENTS = 100;
 export const BIG_STRINGS_RECOMMENDATION_MEMORY = 100_000;
 export const SEARCH_INDEXES_RECOMMENDATION_KEYS_FOR_CHECK = 100;
-export const REDIS_VERSION_RECOMMENDATION_VERSION = '6';
+export const REDIS_VERSION_RECOMMENDATION_VERSION = '7.3';
 export const COMBINE_SMALL_STRINGS_TO_HASHES_RECOMMENDATION_KEYS_COUNT = 10;
 export const SEARCH_HASH_RECOMMENDATION_KEYS_FOR_CHECK = 50;
 export const SEARCH_HASH_RECOMMENDATION_KEYS_LENGTH = 2;

redisinsight/api/src/modules/database-recommendation/scanner/strategies/redis-version.strategy.spec.ts

@@ -9,12 +9,22 @@ describe('RedisVersionStrategy', () => {
 
   describe('isRecommendationReached', () => {
     describe('with search module', () => {
-      it('should return false when version not less then 6', async () => {
-        expect(await strategy.isRecommendationReached({ version: '6.0.0' })).toEqual({ isReached: false });
+      it('should return false when version is more then 7.3', async () => {
+        expect(
+          await strategy.isRecommendationReached({ version: '7.4.0' }),
+        ).toEqual({ isReached: false });
       });
 
-      it('should return true when version less then 6', async () => {
-        expect(await strategy.isRecommendationReached({ version: '5.1.1' })).toEqual({ isReached: true });
+      it('should return false when version is equal to 7.3', async () => {
+        expect(
+          await strategy.isRecommendationReached({ version: '7.3' }),
+        ).toEqual({ isReached: false });
+      });
+
+      it('should return true when version less then 7.3', async () => {
+        expect(
+          await strategy.isRecommendationReached({ version: '6.0.0' }),
+        ).toEqual({ isReached: true });
       });
     });
   });

redisinsight/api/src/modules/recommendation/providers/recommendation.provider.spec.ts

@@ -18,8 +18,8 @@ const mockRedisConfigResponse = ['name', '512'];
 const mockRedisClientsResponse1: string = '# Clients\r\nconnected_clients:100\r\n';
 const mockRedisClientsResponse2: string = '# Clients\r\nconnected_clients:101\r\n';
 
-const mockRedisServerResponse1: string = '# Server\r\nredis_version:6.0.0\r\n';
-const mockRedisServerResponse2: string = '# Server\r\nredis_version:5.1.1\r\n';
+const mockRedisServerResponse1: string = '# Server\r\nredis_version:7.4.0\r\n';
+const mockRedisServerResponse2: string = '# Server\r\nredis_version:6.0.0\r\n';
 
 const mockRedisAclListResponse1: string[] = [
   'user <pass off resetchannels -@all',