Skip to content

Commit 8236c09

Browse files
author
Artem
committed
#RI-4996 add error description for CLOUD_AUTH_FAILED events where possible
1 parent 02ca5dd commit 8236c09

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

redisinsight/api/src/modules/cloud/auth/cloud-auth.analytics.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@ export class CloudAuthAnalytics extends TelemetryBaseService {
1515
}
1616

1717
sendCloudSignInFailed(exception: HttpException, flow?: CloudSsoFeatureStrategy, action?: string) {
18-
this.sendFailedEvent(TelemetryEvents.CloudSignInFailed, exception, { flow, action });
18+
this.sendFailedEvent(TelemetryEvents.CloudSignInFailed, exception, {
19+
flow,
20+
action,
21+
errorDescription: exception?.['options']?.['description'],
22+
});
1923
}
2024
}

redisinsight/api/src/modules/cloud/auth/cloud-auth.service.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,14 @@ export class CloudAuthService {
3333

3434
static getAuthorizationServerRedirectError(query: { error_description: string }) {
3535
if (query?.error_description?.indexOf('properties are missing') > -1) {
36-
return new CloudOauthMissedRequiredDataException(query.error_description);
36+
return new CloudOauthMissedRequiredDataException(query.error_description, {
37+
description: query.error_description,
38+
});
3739
}
3840

39-
return new CloudOauthMisconfigurationException();
41+
return new CloudOauthMisconfigurationException(undefined, {
42+
description: query.error_description,
43+
});
4044
}
4145

4246
getAuthStrategy(strategy: CloudAuthIdpType): CloudAuthStrategy {

redisinsight/api/src/modules/cloud/auth/exceptions/cloud-oauth.unknown-authorization-request.exception.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export class CloudOauthUnknownAuthorizationRequestException extends HttpExceptio
77
const response = {
88
message,
99
statusCode: HttpStatus.BAD_REQUEST,
10-
error: 'CloudOauthGithubEmailPermission',
10+
error: 'CloudOauthUnknownAuthorizationRequest',
1111
errorCode: CustomErrorCodes.CloudOauthUnknownAuthorizationRequest,
1212
};
1313

0 commit comments

Comments
 (0)