Skip to content

Commit 8242aaf

Browse files
committed
e2e/bugfix/unskip-tests
1 parent 248eb6e commit 8242aaf

File tree

5 files changed

+21
-10
lines changed

5 files changed

+21
-10
lines changed

tests/e2e/tests/web/critical-path/memory-efficiency/recommendations.e2e.ts

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { ExploreTabs, RecommendationIds, rte } from '../../../../helpers/constan
33
import { DatabaseHelper } from '../../../../helpers/database';
44
import {
55
commonUrl,
6+
ossSentinelConfig,
67
ossStandaloneBigConfig,
78
ossStandaloneConfig,
89
ossStandaloneV5Config
@@ -88,7 +89,19 @@ test
8889
.eql(expandedTextContaiterSize, 'Lua script recommendation not expanded');
8990
});
9091
// skipped due to inability to receive no recommendations for now
91-
test.skip('No recommendations message', async t => {
92+
test
93+
.before(async() => {
94+
await databaseHelper.acceptLicenseTerms();
95+
// Add Sentinel databases
96+
await databaseAPIRequests.discoverSentinelDatabaseApi(ossSentinelConfig);
97+
await myRedisDatabasePage.reloadPage();
98+
})
99+
.after(async() => {
100+
// Delete all primary groups
101+
await databaseAPIRequests.deleteAllDatabasesByConnectionTypeApi('SENTINEL');
102+
await myRedisDatabasePage.reloadPage();
103+
})
104+
.meta({ rte: rte.sentinel })('No recommendations message', async t => {
92105
keyName = `recomKey-${Common.generateWord(10)}`;
93106
const noRecommendationsMessage = 'No recommendations at the moment, run a new report later to keep up the good work!';
94107
const command = `HSET ${keyName} field value`;
@@ -159,7 +172,7 @@ test
159172
await recommendationsActions.voteForRecommendation(redisVersionRecommendation, usefulVoteOption);
160173
await recommendationsActions.verifyVoteIsSelected(redisVersionRecommendation, usefulVoteOption);
161174
});
162-
test.skip
175+
test
163176
.before(async t => {
164177
await databaseHelper.acceptLicenseTermsAndAddDatabaseApi(ossStandaloneConfig);
165178
keyName = `recomKey-${Common.generateWord(10)}`;

tests/e2e/tests/web/regression/insights/import-tutorials.e2e.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,7 @@ test
120120
.notOk(`${tutorialName} tutorial is not uploaded`);
121121
});
122122
// https://redislabs.atlassian.net/browse/RI-4186, https://redislabs.atlassian.net/browse/RI-4213, https://redislabs.atlassian.net/browse/RI-4302
123-
// skipped because need to move .zip tutorial to another github repository
124-
test.skip
123+
test
125124
.after(async() => {
126125
tutorialName = 'Tutorials with manifest';
127126
const tutorials = await workbenchPage.InsightsPanel.setActiveTab(ExploreTabs.Tutorials);
@@ -130,8 +129,8 @@ test.skip
130129
}
131130
await databaseAPIRequests.deleteStandaloneDatabaseApi(ossStandaloneConfig);
132131
})('Verify that user can upload tutorial with URL with manifest.json', async t => {
133-
const labelFromManifest = 'LabelFromManifest';
134-
const link = 'https://github.com/RedisInsight/RedisInsight/raw/main/tests/e2e/test-data/upload-tutorials/TutorialsWithManifest.zip';
132+
const labelFromManifest = 'Working with JSON label';
133+
const link = 'https://github.com/RedisInsight/RedisInsight/raw/9155d0241f6937c213893a29fe24c2f560cd48f3/tests/e2e/test-data/upload-tutorials/TutorialsWithManifest.zip';
135134
internalLinkName1 = 'manifest-id';
136135
tutorialName = 'Tutorials with manifest';
137136
const summary = 'Summary for JSON';

tests/e2e/tests/web/regression/monitor/monitor.e2e.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,7 @@ test
115115
await t.expect(previousTimestamp).notEql(nextTimestamp, 'Monitor results not correct');
116116
}
117117
});
118-
// Skipped due to redis issue https://redislabs.atlassian.net/browse/RI-4111
119-
test.skip
118+
test
120119
.before(async t => {
121120
await databaseHelper.acceptLicenseTermsAndAddDatabaseApi(ossStandaloneConfig);
122121
await browserPage.Cli.sendCommandInCli('acl setuser noperm nopass on +@all ~* -monitor -client');

tests/e2e/tests/web/regression/workbench/command-results.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ test('Verify that user can switches between Table and Text for FT.AGGREGATE and
7171
await t.expect(workbenchPage.queryTableResult.exists).ok('The table view is not switched for command FT.AGGREGATE');
7272
});
7373
// Skipped due to issue https://redislabs.atlassian.net/browse/RI-3524
74-
test.skip('Verify that user can switches between views and see results according to this view in full mode in Workbench', async t => {
74+
test('Verify that user can switches between views and see results according to this view in full mode in Workbench', async t => {
7575
const command = 'CLIENT LIST';
7676

7777
// Send command and check table view is default in full mode

tests/e2e/tests/web/regression/workbench/default-scripts-area.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ test('Verify that user can see saved article in Enablement area when he leaves W
8383
await t.expect(selector.visible).ok('The end of the page is not visible');
8484
});
8585
//skipped due the issue RI-2384
86-
test.skip('Verify that user can see saved scroll position in Enablement area when he leaves Workbench page and goes back again', async t => {
86+
test('Verify that user can see saved scroll position in Enablement area when he leaves Workbench page and goes back again', async t => {
8787
// Open Working with Hashes section
8888
await workbenchPage.InsightsPanel.togglePanel(true);
8989
const tutorials = await workbenchPage.InsightsPanel.setActiveTab(ExploreTabs.Tutorials);

0 commit comments

Comments
 (0)