RI-6049 separate timezone update from dateFormat update

Author: kchepikava

redisinsight/ui/src/pages/settings/components/general-settings/datetime-formatter/DateTimeFormatter.tsx

@@ -1,41 +1,22 @@
-import React, { ChangeEvent, useEffect, useMemo, useState } from 'react'
-import { useDispatch, useSelector } from 'react-redux'
-import { useFormik } from 'formik'
+import React, { useEffect, useState } from 'react'
+import { useSelector } from 'react-redux'
 import {
-  EuiButton,
-  EuiFieldText,
   EuiFlexGroup,
   EuiFlexItem,
-  EuiForm,
-  EuiRadioGroup,
-  EuiRadioGroupOption,
   EuiSpacer,
-  EuiSuperSelect,
   EuiText,
   EuiTitle,
-  EuiToolTip
 } from '@elastic/eui'
-import { checkDateTimeFormat, formatTimestamp } from 'uiSrc/utils'
-import { DATETIME_FORMATTER_DEFAULT, DatetimeRadioOption, TimezoneOption, dateTimeOptions, timezoneOptions } from 'uiSrc/constants'
-import { updateUserConfigSettingsAction, userSettingsConfigSelector } from 'uiSrc/slices/user/user-settings'
-import icheck from 'uiSrc/assets/img/icons/check.svg'
-import { TelemetryEvent, sendEventTelemetry } from 'uiSrc/telemetry'
+import { formatTimestamp } from 'uiSrc/utils'
+import { DATETIME_FORMATTER_DEFAULT, TimezoneOption } from 'uiSrc/constants'
+import { userSettingsConfigSelector } from 'uiSrc/slices/user/user-settings'
+import TimezoneForm from './components/timezone-form/TimezoneForm'
+import DatetimeForm from './components/datetime-form/DatetimeForm'
 import styles from './styles.module.scss'
 
-interface InitialValuesType {
-  format: string;
-  customFormat: string;
-  commonFormat: string;
-  selectedRadioOption: DatetimeRadioOption;
-  timezone: TimezoneOption;
-}
-
 const DateTimeFormatter = () => {
-  const [error, setError] = useState('')
   const [preview, setPreview] = useState('')
-  const [saveFormatSucceed, setSaveFormatSucceed] = useState(false)
   const config = useSelector(userSettingsConfigSelector)
-  const dispatch = useDispatch()
 
   useEffect(() => {
     setPreview(formatTimestamp(
@@ -45,184 +26,8 @@ const DateTimeFormatter = () => {
     ))
   }, [config?.dateFormat, config?.timezone])
 
-  const getInitialDateTime = (): InitialValuesType => {
-    const format = config?.dateFormat || DATETIME_FORMATTER_DEFAULT
-    const selectedRadioOption = dateTimeOptions.some((opt) => opt.value === format)
-      ? DatetimeRadioOption.Common
-      : DatetimeRadioOption.Custom
-
-    return {
-      selectedRadioOption,
-      format,
-      customFormat: selectedRadioOption === DatetimeRadioOption.Custom ? format : '',
-      commonFormat: selectedRadioOption === DatetimeRadioOption.Common ? format : dateTimeOptions[0].value,
-      timezone: config?.timezone || TimezoneOption.Local,
-    }
-  }
-
-  const getInitialValues = useMemo(() => getInitialDateTime(), [config])
-
-  const formik = useFormik({
-    initialValues: getInitialValues,
-    enableReinitialize: true,
-    onSubmit: (values) => {
-      submitForm(values)
-    }
-  })
-
-  const submitForm = async (values: InitialValuesType) => {
-    if (checkDateTimeFormat(values.format, values.timezone).valid) {
-      dispatch(
-        updateUserConfigSettingsAction(
-          { dateFormat: values.format.trim(), timezone: values.timezone.trim() },
-          () => {
-            formik.setSubmitting(false)
-            setSaveFormatSucceed(true)
-            setTimeout(() => setSaveFormatSucceed(false), 5000)
-          },
-          () => {
-            formik.setSubmitting(false)
-          }
-        )
-      )
-    } else {
-      setError('This format is not supported.')
-      formik.setSubmitting(false)
-    }
-  }
-
-  const showError = !!error || !formik.values.customFormat
-  const getBtnIconType = () => (showError ? 'iInCircle' : (saveFormatSucceed ? icheck : undefined))
-
-  const handleFormatCheck = (format = formik.values.format, timezone = formik.values.timezone) => {
-    const { valid, error: errorMsg } = checkDateTimeFormat(format, timezone)
-    if (!valid) {
-      setError(errorMsg || 'This format is not supported')
-      setPreview('Invalid Format')
-    } else {
-      setError('')
-      const newPreview = formatTimestamp(new Date(), format, timezone)
-      setPreview(newPreview)
-    }
-    return valid
-  }
-
-  const onRadioOptionChange = (id: string) => {
-    formik.setFieldValue('selectedRadioOption', id)
-    if (id === DatetimeRadioOption.Custom) {
-      formik.setFieldValue('customFormat', formik.values.format)
-    } else {
-      formik.setFieldValue('format', formik.values.commonFormat)
-      formik.handleSubmit()
-    }
-  }
-
-  const onTimezoneChange = (value: string) => {
-    formik.setFieldValue('timezone', value)
-
-    sendEventTelemetry({
-      event: TelemetryEvent.SETTINGS_TIME_ZONE_CHANGED,
-      eventData: {
-        currentTimezone: value,
-      }
-    })
-    formik.handleSubmit()
-  }
-
-  const onCustomFormatChange = (e: ChangeEvent<HTMLInputElement>) => {
-    const { value } = e.target
-    formik.setFieldValue('customFormat', value)
-    formik.setFieldValue('format', value)
-    handleFormatCheck(value)
-  }
-
-  const onCommonFormatChange = (value: string) => {
-    formik.setFieldValue('commonFormat', value)
-    formik.setFieldValue('format', value)
-
-    sendEventTelemetry({
-      event: TelemetryEvent.SETTINGS_DATE_TIME_FORMAT_CHANGED,
-      eventData: {
-        currentFormat: value,
-      }
-    })
-    formik.handleSubmit()
-  }
-
-  const onCustomFormatSubmit = () => {
-    sendEventTelemetry({
-      event: TelemetryEvent.SETTINGS_DATE_TIME_FORMAT_CHANGED,
-      eventData: {
-        currentFormat: formik.values.customFormat,
-      }
-    })
-
-    formik.handleSubmit()
-  }
-
-  const dateTimeFormatOptions: EuiRadioGroupOption[] = [
-    {
-      id: DatetimeRadioOption.Common,
-      label: (
-        <div className={styles.radioLabelWrapper}>
-          <div className={styles.radioLabelTextContainer}>
-            <EuiText color="subdued" className={styles.radioLabelText}>Pre-selected formats</EuiText>
-          </div>
-          <EuiSuperSelect
-            className={styles.datetimeInput}
-            options={dateTimeOptions}
-            valueOfSelected={formik.values.commonFormat}
-            onChange={(option) => onCommonFormatChange(option)}
-            disabled={formik.values.selectedRadioOption !== DatetimeRadioOption.Common}
-            data-test-subj="select-datetime"
-          />
-        </div>
-      ),
-    },
-    {
-      id: DatetimeRadioOption.Custom,
-      label: (
-        <div className={styles.radioLabelWrapper}>
-          <div className={styles.radioLabelTextContainer}>
-            <EuiText color="subdued" className={styles.radioLabelText}>Custom</EuiText>
-          </div>
-          {formik.values.selectedRadioOption === DatetimeRadioOption.Custom && (
-            <>
-              <EuiFieldText
-                className={styles.datetimeInput}
-                id="customFormat"
-                name="customFormat"
-                value={formik.values.customFormat}
-                onChange={(e) => onCustomFormatChange(e)}
-                data-testid="custom-datetime-input"
-              />
-              <EuiToolTip
-                position="top"
-                anchorClassName="euiToolTip__btn-disabled"
-                content={showError ? (error || 'This format is not supported') : null}
-              >
-                <EuiButton
-                  aria-label="Save"
-                  isLoading={formik.isSubmitting}
-                  color="secondary"
-                  fill
-                  size="m"
-                  className={styles.customBtn}
-                  onClick={onCustomFormatSubmit}
-                  data-testid="datetime-custom-btn"
-                  iconType={getBtnIconType()}
-                  disabled={showError}
-                >Save
-                </EuiButton>
-              </EuiToolTip>
-            </>
-          )}
-        </div>)
-    }
-  ]
-
   return (
-    <EuiForm component="form" onSubmit={formik.handleSubmit} data-testid="format-timestamp-form">
+    <>
       <EuiTitle size="xs">
         <h4>Date and Time Format</h4>
       </EuiTitle>
@@ -231,28 +36,14 @@ const DateTimeFormatter = () => {
         Specifies the date and time format to be used in Redis Insight:
       </EuiText>
       <EuiSpacer size="m" />
-      <EuiRadioGroup
-        options={dateTimeFormatOptions}
-        className={styles.radios}
-        name="radioDateTime"
-        idSelected={formik.values.selectedRadioOption}
-        onChange={(id) => onRadioOptionChange(id)}
-      />
+      <DatetimeForm setPreview={setPreview} />
       <EuiSpacer size="m" />
       <EuiText className={styles.dateTimeSubtitle} color="subdued">Specifies the time zone to be used in Redis Insight:</EuiText>
       <EuiSpacer size="s" />
       <div>
         <EuiFlexGroup alignItems="center">
           <EuiFlexItem grow={1}>
-            <div>
-              <EuiSuperSelect
-                className={styles.datetimeInput}
-                options={timezoneOptions}
-                valueOfSelected={formik.values.timezone}
-                onChange={(option) => onTimezoneChange(option)}
-                data-test-subj="select-timezone"
-              />
-            </div>
+            <TimezoneForm />
           </EuiFlexItem>
           <EuiFlexItem grow={2}>
             <div className={styles.previewContainer}>
@@ -263,7 +54,7 @@ const DateTimeFormatter = () => {
         </EuiFlexGroup>
       </div>
       <EuiSpacer size="l" />
-    </EuiForm>
+    </>
   )
 }