e2e - fix iframe tests

Author: tanyatrayanava

redisinsight/ui/src/components/query-card/QueryCardCliPlugin/QueryCardCliPlugin.tsx

@@ -164,6 +164,7 @@ const QueryCardCliPlugin = (props: Props) => {
           ref={pluginIframeRef}
           referrerPolicy="no-referrer"
           sandbox="allow-same-origin allow-scripts"
+          data-testid="pluginIframe"
         />
         {!!error && (
           <div className={styles.container}>

tests/e2e/pageObjects/workbench-page.ts

@@ -67,7 +67,7 @@ export class WorkbenchPage {
       this.paginationButtonPrevious = Selector(this.cssSelectorPaginationButtonPrevious);
       this.paginationButtonNext = Selector(this.cssSelectorPaginationButtonNext);
       this.selectViewType = Selector('[data-testid=select-view-type]');
-      this.textViewTypeOption = Selector('[data-test-subj=view-type-option-Text]');
+      this.textViewTypeOption = Selector('[data-test-subj^=view-type-option-Text]');
       this.preselectList = Selector('[data-testid*=preselect-List]');
       this.preselectIndexInfo = Selector('[data-testid*=preselect-Index]');
       this.preselectSearch = Selector('[data-testid=preselect-Search]');
@@ -94,7 +94,7 @@ export class WorkbenchPage {
       this.monacoCommandDetails = Selector('div.suggest-details-container');
       this.monacoCloseCommandDetails = Selector('span.codicon-close');
       this.monacoSuggestion = Selector('span.monaco-icon-name-container');
-      this.iframe = Selector('.pluginIframe', { timeout: 90000 });
+      this.iframe = Selector('[data-testid=pluginIframe]');
   }
 
   /**

tests/e2e/tests/critical-path/workbench/default-scripts-area.e2e.ts

@@ -30,8 +30,7 @@ fixture `Default scripts area at Workbench`
         //Drop index and documents
         await workbenchPage.sendCommandInWorkbench('FT.DROPINDEX products DD');
     })
-//skipped due the inaccessibility of the iframe
-test.skip('Verify that user can edit and run automatically added "FT._LIST" and "FT.INFO {index}" scripts in Workbench and see the results', async t => {
+test('Verify that user can edit and run automatically added "FT._LIST" and "FT.INFO {index}" scripts in Workbench and see the results', async t => {
     const commandsForSend = [
         `FT.CREATE ${indexName} ON HASH PREFIX 1 product: SCHEMA name TEXT`,
         'HMSET product:1 name "Apple Juice" ',
@@ -54,7 +53,9 @@ test.skip('Verify that user can edit and run automatically added "FT._LIST" and
     await t.pressKey('ctrl+a delete');
     await workbenchPage.sendCommandInWorkbench(addedScript);
     //Check the FT.INFO result
+    await t.switchToIframe(workbenchPage.iframe);
     await t.expect(workbenchPage.queryColumns.textContent).contains('name', 'The result of the FT.INFO command');
+    await t.switchToMainWindow();
 });
 //skipped due the inaccessibility of the iframe
 test.skip('Verify that user can edit and run automatically added "Search" script in Workbench and see the results', async t => {
@@ -72,10 +73,12 @@ test.skip('Verify that user can edit and run automatically added "Search" script
     await t.pressKey('ctrl+a delete');
     await workbenchPage.sendCommandInWorkbench(searchCommand);
     //Check the FT.SEARCH result
+    await t.switchToIframe(workbenchPage.iframe);
     const key = workbenchPage.queryTableResult.withText('product:1');
     const name = workbenchPage.queryTableResult.withText('Apple Juice');
     await t.expect(key.exists).ok('The added key is in the Search result');
     await t.expect(name.exists).ok('The added key name field is in the Search result');
+    await t.switchToMainWindow();
 });
 //skipped due the inaccessibility of the iframe
 test.skip('Verify that user can edit and run automatically added "Aggregate" script in Workbench and see the results', async t => {
@@ -94,8 +97,10 @@ test.skip('Verify that user can edit and run automatically added "Aggregate" scr
     await t.pressKey('ctrl+a delete');
     await workbenchPage.sendCommandInWorkbench(searchCommand);
     //Check the FT.Aggregate result
+    await t.switchToIframe(workbenchPage.iframe);
     await t.expect(workbenchPage.queryTableResult.textContent).contains(aggregationResultField, 'The aggregation field name is in the Search result');
     await t.expect(workbenchPage.queryTableResult.textContent).contains('100', 'The aggregation max value is in the Search result');
+    await t.switchToMainWindow();
 });
 test('Verify that when the “Manual” option clicked, user can see the Editor is automatically prepopulated with the information', async t => {
     const information = [

tests/e2e/tests/critical-path/workbench/index-schema.e2e.ts

@@ -34,8 +34,7 @@ fixture `Index Schema at Workbench`
         //Drop index and documents
         await workbenchPage.sendCommandInWorkbench(`FT.DROPINDEX ${indexName} DD`);
     })
-//skipped due the inaccessibility of the iframe
-test.skip('Verify that user can open results in Text and Table views for FT.INFO for Hash in Workbench', async t => {
+test('Verify that user can open results in Text and Table views for FT.INFO for Hash in Workbench', async t => {
     const commandsForSend = [
         `FT.CREATE ${indexName} ON HASH PREFIX 1 product: SCHEMA name TEXT`,
         `HMSET product:1 name "Apple Juice"`
@@ -49,12 +48,12 @@ test.skip('Verify that user can open results in Text and Table views for FT.INFO
     await t.switchToIframe(workbenchPage.iframe);
     await t.expect(workbenchPage.queryTableResult.exists).ok('The result is displayed in Table view');
     //Select Text view type
+    await t.switchToMainWindow();
     await workbenchPage.selectViewTypeText();
     //Check that result is displayed in Text view
     await t.expect(workbenchPage.queryTextResult.exists).ok('The result is displayed in Text view');
 });
-//skipped due the inaccessibility of the iframe
-test.skip('Verify that user can open results in Text and Table views for FT.INFO for JSON in Workbench', async t => {
+test('Verify that user can open results in Text and Table views for FT.INFO for JSON in Workbench', async t => {
     const commandsForSend = [
         `FT.CREATE ${indexName} ON JSON SCHEMA $.user.name AS name TEXT $.user.tag AS country TAG`,
         `JSON.SET myDoc1 $ '{"user":{"name":"John Smith","tag":"foo,bar","hp":1000, "dmg":150}}'`
@@ -65,8 +64,10 @@ test.skip('Verify that user can open results in Text and Table views for FT.INFO
     //Send search command
     await workbenchPage.sendCommandInWorkbench(searchCommand);
     //Check that result is displayed in Table view
+    await t.switchToIframe(workbenchPage.iframe);
     await t.expect(workbenchPage.queryTableResult.exists).ok('The result is displayed in Table view');
     //Select Text view type
+    await t.switchToMainWindow();
     await workbenchPage.selectViewTypeText();
     //Check that result is displayed in Text view
     await t.expect(workbenchPage.queryTextResult.exists).ok('The result is displayed in Text view');

tests/e2e/tests/critical-path/workbench/json-workbench.e2e.ts

@@ -35,7 +35,7 @@ fixture `JSON verifications at Workbench`
         await workbenchPage.sendCommandInWorkbench(`FT.DROPINDEX ${indexName} DD`);
     })
 //skipped due the inaccessibility of the iframe
-test.skip('Verify that user can see result in Table and Text view for JSON data types for FT.AGGREGATE command in Workbench', async t => {
+test('Verify that user can see result in Table and Text view for JSON data types for FT.AGGREGATE command in Workbench', async t => {
     const commandsForSend = [
         `FT.CREATE ${indexName} ON JSON SCHEMA $.user.name AS name TEXT $.user.tag AS country TAG`,
         `JSON.SET myDoc1 $ '{"user":{"name":"John Smith","tag":"foo,bar","hp":1000, "dmg":150}}'`,
@@ -47,8 +47,10 @@ test.skip('Verify that user can see result in Table and Text view for JSON data
     //Send search command
     await workbenchPage.sendCommandInWorkbench(searchCommand);
     //Check that result is displayed in Table view
+    await t.switchToIframe(workbenchPage.iframe);
     await t.expect(workbenchPage.queryTableResult.exists).ok('The result is displayed in Table view');
     //Select Text view type
+    await t.switchToMainWindow();
     await workbenchPage.selectViewTypeText();
     //Check that result is displayed in Text view
     await t.expect(workbenchPage.queryTextResult.exists).ok('The result is displayed in Text view');

tests/e2e/tests/critical-path/workbench/scripting-area.e2e.ts

@@ -80,11 +80,13 @@ test.skip('Verify that user when he have more than 10 results can request to vie
     //Get needed container
     const containerOfCommand = await workbenchPage.getCardContainerByCommand(searchCommand);
     //Verify that we have pagination buttons
+    await t.switchToIframe(workbenchPage.iframe);
     await t.expect(containerOfCommand.find(workbenchPage.cssSelectorPaginationButtonPrevious).exists)
         .ok('Pagination previous button exists');
     await t.expect(containerOfCommand.find(workbenchPage.cssSelectorPaginationButtonNext).exists)
         .ok('Pagination next button exists');
     //Drop index and documents
+    await t.switchToMainWindow();
     await workbenchPage.sendCommandInWorkbench('FT.DROPINDEX products DD');
 });
 //skipped due the inaccessibility of the iframe
@@ -105,8 +107,10 @@ test.skip
         //Send search command
         await workbenchPage.sendCommandInWorkbench(searchCommand);
         //Check that result is displayed in Table view
+        await t.switchToIframe(workbenchPage.iframe);
         await t.expect(workbenchPage.queryTableResult.exists).ok('The result is displayed in Table view');
         //Select Text view type
+        await t.switchToMainWindow();
         await workbenchPage.selectViewTypeText();
         //Check that result is displayed in Text view
         await t.expect(workbenchPage.queryTextResult.exists).ok('The result is displayed in Text view');