Skip to content

Commit 887895e

Browse files
authored
Merge pull request #102 from RedisInsight/fix/e2e-enablement-area
[E2E] Fix failed tests with Enablement area
2 parents e60e4be + b43f851 commit 887895e

File tree

2 files changed

+19
-23
lines changed

2 files changed

+19
-23
lines changed

tests/e2e/pageObjects/workbench-page.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ export class WorkbenchPage {
3232
queryInputScriptArea: Selector
3333
overviewTotalKeys: Selector
3434
overviewTotalMemory: Selector
35-
resizeButtonForPreselectsArea: Selector
35+
collapsePreselectAreaButton: Selector
36+
expandPreselectAreaButton: Selector
3637
preselectButtons: Selector
37-
preselectsAreaContainer: Selector
3838
reRunCommandButton: Selector
3939
queryCardNoModuleOutput: Selector
4040
queryCardNoModuleButton: Selector
@@ -45,6 +45,8 @@ export class WorkbenchPage {
4545
internalLinkWorkingWithHashes: Selector
4646
preselectExactSearch: Selector
4747
preselectGroupBy: Selector
48+
preselectArea: Selector
49+
expandArea: Selector
4850

4951
constructor() {
5052
//CSS selectors
@@ -63,7 +65,8 @@ export class WorkbenchPage {
6365
//BUTTONS
6466
this.submitCommandButton = Selector('[data-testid=btn-submit]');
6567
this.resizeButtonForScriptingAndResults = Selector('[data-test-subj=resize-btn-scripting-area-and-results]');
66-
this.resizeButtonForPreselectsArea = Selector('[data-test-subj=resize-btn-preselects-area]');
68+
this.collapsePreselectAreaButton = Selector('[data-testid=collapse-enablement-area]');
69+
this.expandPreselectAreaButton = Selector('[data-testid=expand-enablement-area]');
6770
this.paginationButtonPrevious = Selector(this.cssSelectorPaginationButtonPrevious);
6871
this.paginationButtonNext = Selector(this.cssSelectorPaginationButtonNext);
6972
this.selectViewType = Selector('[data-testid=select-view-type]');
@@ -88,13 +91,15 @@ export class WorkbenchPage {
8891
this.queryInputScriptArea = Selector('[data-testid=query-input-container] .view-line');
8992
this.overviewTotalKeys = Selector('[data-test-subj=overview-total-keys]');
9093
this.overviewTotalMemory = Selector('[data-test-subj=overview-total-memory]');
91-
this.preselectsAreaContainer = Selector('[data-test-subj=resize-container-preselects-area]');
9294
this.queryCardNoModuleOutput = Selector('[data-testid=query-card-no-module-output]');
9395
this.queryCardNoModuleButton = Selector('[data-testid=query-card-no-module-button] a');
9496
this.monacoCommandDetails = Selector('div.suggest-details-container');
9597
this.monacoCloseCommandDetails = Selector('span.codicon-close');
9698
this.monacoSuggestion = Selector('span.monaco-icon-name-container');
9799
this.iframe = Selector('.pluginIframe', { timeout: 90000 });
100+
// Panel
101+
this.preselectArea = Selector('[data-testid=enablementArea]');
102+
this.expandArea = Selector('[]')
98103
}
99104

100105
/**

tests/e2e/tests/regression/workbench/default-scripts-area.e2e.ts

Lines changed: 10 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { addNewStandaloneDatabase } from '../../../helpers/database';
2-
import { WorkbenchPage } from '../../../pageObjects/workbench-page';
3-
import { MyRedisDatabasePage, UserAgreementPage, AddRedisDatabasePage } from '../../../pageObjects';
2+
import { MyRedisDatabasePage, UserAgreementPage, AddRedisDatabasePage, WorkbenchPage } from '../../../pageObjects';
43
import {
54
commonUrl,
65
ossStandaloneConfig
@@ -24,25 +23,17 @@ fixture `Default scripts area at Workbench`
2423
//Go to Workbench page
2524
await t.click(myRedisDatabasePage.workbenchButton);
2625
})
27-
test('Verify that user can resize(maximize)/(minimize) the enablement area (the one with default scripts)', async t => {
28-
const offsetX = 100;
29-
const areaWidthBefore = await workbenchPage.preselectsAreaContainer.clientWidth;
30-
//Minimize the area with default scripts
31-
await t.drag(workbenchPage.resizeButtonForPreselectsArea, -offsetX, 0, { speed: 0.1 });
32-
await t.expect(await workbenchPage.preselectsAreaContainer.clientWidth).lt(areaWidthBefore, 'Default scripts area is smaller after resize');
33-
//Maximize the area with default scripts
34-
const areaWidthAfter = await workbenchPage.preselectsAreaContainer.clientWidth;
35-
await t.click(workbenchPage.preselectsAreaContainer);
36-
await t.drag(workbenchPage.resizeButtonForPreselectsArea, offsetX, 0, { speed: 0.1 });
37-
await t.expect(await workbenchPage.preselectsAreaContainer.clientWidth).gte(areaWidthAfter, 'Default scripts area is bigger after resize');
38-
});
3926
test('Verify that user can expand/collapse the enablement area', async t => {
27+
//Hover over Enablement area
28+
await t.hover(workbenchPage.preselectArea);
4029
//Collapse the area with default scripts
41-
await t.doubleClick(workbenchPage.resizeButtonForPreselectsArea);
42-
await t.expect(await workbenchPage.preselectButtons.visible).eql(false, 'Default scripts area after resize is minimized');
43-
//Expand the area with default scripts
44-
await t.click(workbenchPage.preselectsAreaContainer);
45-
await t.expect(await workbenchPage.preselectButtons.visible).eql(true, 'Default scripts area after resize is maximized');
30+
await t.click(workbenchPage.collapsePreselectAreaButton);
31+
//Validate that Enablement area is not displayed
32+
await t.expect(workbenchPage.preselectArea.visible).notOk('Enablement area is collapsed');
33+
//Expand Enablement area
34+
await t.click(workbenchPage.expandPreselectAreaButton);
35+
//Validate that Enablement area is displayed
36+
await t.expect(workbenchPage.preselectArea.visible).ok('Enablement area is expanded');
4637
});
4738
test('Verify that user can see the [Manual] option in the Enablement area', async t => {
4839
const optionsForCheck = [

0 commit comments

Comments
 (0)