Skip to content

Commit 892cf41

Browse files
#RI-3704-update getOverview cluster test
1 parent ac39343 commit 892cf41

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

redisinsight/api/src/modules/database/providers/database-overview.provider.spec.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,17 @@ export const mockDatabaseOverview: DatabaseOverview = {
7777
describe('OverviewService', () => {
7878
let service: DatabaseOverviewProvider;
7979
let spyGetNodeInfo;
80+
let spyCalculateTotalKeys;
81+
let spyCalculateNodesTotalKeys;
8082
beforeEach(async () => {
8183
const module: TestingModule = await Test.createTestingModule({
8284
providers: [DatabaseOverviewProvider],
8385
}).compile();
8486

8587
service = await module.get(DatabaseOverviewProvider);
8688
spyGetNodeInfo = jest.spyOn<any, any>(service, 'getNodeInfo');
89+
spyCalculateTotalKeys = jest.spyOn<any, any>(service, 'calculateTotalKeys');
90+
spyCalculateNodesTotalKeys = jest.spyOn<any, any>(service, 'calculateNodesTotalKeys');
8791
mockClient.call = jest.fn();
8892
mockClient.info = jest.fn();
8993
});
@@ -194,11 +198,10 @@ describe('OverviewService', () => {
194198
});
195199
describe('Cluster', () => {
196200
it('Should calculate overview and ignore replica where needed', async () => {
201+
const getTotal = jest.spyOn(Utils, 'getTotal').mockResolvedValue(mockGetTotalResponse_1);
197202
mockCluster.nodes = jest.fn()
198203
.mockReturnValue(new Array(6).fill(Promise.resolve()));
199204

200-
jest.spyOn(Utils, 'getTotal').mockResolvedValue(mockGetTotalResponse_1);
201-
202205
spyGetNodeInfo.mockResolvedValueOnce({
203206
...mockNodeInfo,
204207
port: 12001,
@@ -238,6 +241,9 @@ describe('OverviewService', () => {
238241
opsPerSecond: 6,
239242
cpuUsagePercentage: null,
240243
});
244+
expect(spyCalculateTotalKeys).toHaveBeenCalledTimes(0);
245+
expect(spyCalculateNodesTotalKeys).toHaveBeenCalledTimes(1);
246+
expect(getTotal).toHaveBeenCalledTimes(6); // 6 nodes
241247

242248
spyGetNodeInfo.mockResolvedValueOnce({
243249
...mockNodeInfo,

redisinsight/api/src/modules/database/providers/database-overview.provider.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,6 @@ export class DatabaseOverviewProvider {
243243
private async calculateNodesTotalKeys(
244244
client: IORedis.Cluster,
245245
): Promise<number> {
246-
console.log(client);
247246
const nodesTotal: number[] = await Promise.all(
248247
client
249248
.nodes('master')

0 commit comments

Comments
 (0)