Skip to content

Commit 8a77aff

Browse files
kyle-marcumnelsonwellsredis
authored andcommitted
CR-95: Changed database recommendation params type to better reflect its shape
1 parent 2e8c6f5 commit 8a77aff

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

redisinsight/api/src/__mocks__/database-recommendation.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export const mockRecommendationName = 'string';
1010

1111
export const mockDatabaseRecommendationParamsEncrypted = 'recommendation.params_ENCRYPTED';
1212

13-
export const mockDatabaseRecommendationParamsPlain = [];
13+
export const mockDatabaseRecommendationParamsPlain = {};
1414

1515
export const mockDatabaseRecommendation = Object.assign(new DatabaseRecommendation(), {
1616
id: mockDatabaseRecommendationId,

redisinsight/api/src/modules/database-recommendation/models/database-recommendation.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Expose } from 'class-transformer';
22
import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';
33
import {
4-
IsArray, IsEnum, IsOptional, IsBoolean,
4+
IsEnum, IsOptional, IsBoolean,
55
} from 'class-validator';
66
import { DatabaseRecommendationParams } from 'src/modules/database-recommendation/models';
77

@@ -77,11 +77,9 @@ export class DatabaseRecommendation {
7777

7878
@ApiPropertyOptional({
7979
description: 'Additional recommendation params',
80-
isArray: true,
81-
type: () => String,
80+
type: Object,
8281
})
83-
@IsArray()
8482
@IsOptional()
8583
@Expose()
86-
params?: DatabaseRecommendationParams[];
84+
params?: DatabaseRecommendationParams;
8785
}

0 commit comments

Comments
 (0)