Skip to content

Commit 8babd57

Browse files
committed
Put databaseId to eventData
1 parent d0b0541 commit 8babd57

File tree

9 files changed

+25
-12
lines changed

9 files changed

+25
-12
lines changed

redisinsight/ui/src/pages/browser/BrowserPage.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,9 @@ const BrowserPage = () => {
150150
const sendPageView = (instanceId: string) => {
151151
sendPageViewTelemetry({
152152
name: TelemetryPageView.BROWSER_PAGE,
153-
databaseId: instanceId
153+
eventData: {
154+
databaseId: instanceId
155+
}
154156
})
155157
setIsPageViewSent(true)
156158
}

redisinsight/ui/src/pages/cluster-details/ClusterDetailsPage.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,9 @@ const ClusterDetailsPage = () => {
106106
const sendPageView = (instanceId: string) => {
107107
sendPageViewTelemetry({
108108
name: TelemetryPageView.CLUSTER_DETAILS_PAGE,
109-
databaseId: instanceId
109+
eventData: {
110+
databaseId: instanceId
111+
}
110112
})
111113
setIsPageViewSent(true)
112114
}

redisinsight/ui/src/pages/database-analysis/DatabaseAnalysisPage.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,9 @@ const DatabaseAnalysisPage = () => {
7575
const sendPageView = (instanceId: string) => {
7676
sendPageViewTelemetry({
7777
name: TelemetryPageView.DATABASE_ANALYSIS,
78-
databaseId: instanceId
78+
eventData: {
79+
databaseId: instanceId
80+
}
7981
})
8082
setIsPageViewSent(true)
8183
}

redisinsight/ui/src/pages/pub-sub/PubSubPage.spec.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@ describe('PubSubPage', () => {
3535

3636
expect(sendPageViewTelemetry).toBeCalledWith({
3737
name: TelemetryPageView.PUBSUB_PAGE,
38-
databaseId: 'instanceId'
38+
eventData: {
39+
databaseId: 'instanceId'
40+
}
3941
})
4042
})
4143
})

redisinsight/ui/src/pages/pub-sub/PubSubPage.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,9 @@ const PubSubPage = () => {
5454
const sendPageView = (instanceId: string) => {
5555
sendPageViewTelemetry({
5656
name: TelemetryPageView.PUBSUB_PAGE,
57-
databaseId: instanceId
57+
eventData: {
58+
databaseId: instanceId
59+
}
5860
})
5961
setIsPageViewSent(true)
6062
}

redisinsight/ui/src/pages/slow-log/SlowLogPage.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,9 @@ const SlowLogPage = () => {
8686
const sendPageView = (instanceId: string) => {
8787
sendPageViewTelemetry({
8888
name: TelemetryPageView.SLOWLOG_PAGE,
89-
databaseId: instanceId
89+
eventData: {
90+
databaseId: instanceId
91+
}
9092
})
9193
setIsPageViewSent(true)
9294
}

redisinsight/ui/src/pages/workbench/WorkbenchPage.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@ const WorkbenchPage = () => {
2929
const sendPageView = (instanceId: string) => {
3030
sendPageViewTelemetry({
3131
name: TelemetryPageView.WORKBENCH_PAGE,
32-
databaseId: instanceId
32+
eventData: {
33+
databaseId: instanceId
34+
}
3335
})
3436
setIsPageViewSent(true)
3537
}

redisinsight/ui/src/telemetry/interfaces.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ export interface ITelemetrySendEvent {
2222
export interface ITelemetrySendPageView {
2323
name: string
2424
eventData?: EventData
25-
databaseId?: string
2625
nonTracking?: boolean
2726
}
2827

redisinsight/ui/src/telemetry/telemetryUtils.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,17 +44,17 @@ const sendEventTelemetry = async ({ event, eventData = {}, traits = {} }: ITelem
4444
}
4545
}
4646

47-
const sendPageViewTelemetry = async ({ name, databaseId, eventData = {} }: ITelemetrySendPageView) => {
47+
const sendPageViewTelemetry = async ({ name, eventData = {} }: ITelemetrySendPageView) => {
4848
try {
4949
const isAnalyticsGranted = checkIsAnalyticsGranted()
5050
if (!isAnalyticsGranted) {
5151
return
5252
}
53-
if (!eventData.provider && databaseId) {
54-
eventData.provider = getProvider(databaseId)
53+
if (!eventData.provider && eventData.databaseId) {
54+
eventData.provider = getProvider(eventData.databaseId)
5555
}
5656
await apiService.post(`${ApiEndpoints.ANALYTICS_SEND_PAGE}`,
57-
{ event: name, eventData: { ...eventData, databaseId } })
57+
{ event: name, eventData })
5858
} catch (e) {
5959
// continue regardless of error
6060
}

0 commit comments

Comments
 (0)