Skip to content

Commit 8baf6ba

Browse files
#RI-3543-3544-3546-bugfix (#1170)
* #RI-3543-3544-3546-bugfix
1 parent c9099a8 commit 8baf6ba

File tree

10 files changed

+38
-21
lines changed

10 files changed

+38
-21
lines changed

redisinsight/ui/src/components/keyboard-shortcut/KeyboardShortcut.tsx

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,23 +6,27 @@ import { EuiBadge, EuiText } from '@elastic/eui'
66
import styles from './styles.module.scss'
77

88
export interface Props {
9-
items: (string | JSX.Element)[];
10-
separator?: string;
11-
transparent?: boolean;
9+
items: (string | JSX.Element)[]
10+
separator?: string
11+
transparent?: boolean
12+
badgeTextClassName?: string
1213
}
1314

14-
const KeyboardShortcut = ({ items = [], separator = '', transparent = false }: Props) => (
15-
<div className={styles.container}>
16-
{
15+
const KeyboardShortcut = (props: Props) => {
16+
const { items = [], separator = '', transparent = false, badgeTextClassName = '' } = props
17+
return (
18+
<div className={styles.container}>
19+
{
1720
items.map((item: string | JSX.Element, index: number) => (
1821
<div key={isString(item) ? item : item?.props?.children}>
19-
{ (index !== 0) && <div className={styles.separator}>{separator}</div> }
22+
{(index !== 0) && <div className={styles.separator}>{separator}</div>}
2023
<EuiBadge className={cx(styles.badge, { [styles.transparent]: transparent })}>
21-
<EuiText size="s">{item}</EuiText>
24+
<EuiText className={badgeTextClassName} size="s">{item}</EuiText>
2225
</EuiBadge>
2326
</div>
2427
))
2528
}
26-
</div>
27-
)
29+
</div>
30+
)
31+
}
2832
export default KeyboardShortcut

redisinsight/ui/src/components/query-card/QueryCard.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ export interface Props {
3030
result: Maybe<CommandExecutionResult[]>
3131
activeMode: RunQueryMode
3232
mode: RunQueryMode
33+
activeResultsMode?: ResultsMode
3334
resultsMode?: ResultsMode
3435
emptyCommand: boolean
3536
summary?: ResultsSummary
@@ -59,6 +60,7 @@ const QueryCard = (props: Props) => {
5960
result,
6061
activeMode,
6162
mode,
63+
activeResultsMode,
6264
resultsMode,
6365
summary,
6466
isOpen,
@@ -162,7 +164,7 @@ const QueryCard = (props: Props) => {
162164
selectedValue={selectedViewValue}
163165
activeMode={activeMode}
164166
mode={mode}
165-
resultsMode={resultsMode}
167+
activeResultsMode={activeResultsMode}
166168
emptyCommand={emptyCommand}
167169
summary={getSummaryText(summary)}
168170
toggleOpen={toggleOpen}

redisinsight/ui/src/components/query-card/QueryCardCliGroupResult/QueryCardCliGroupResult.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export interface Props {
1010
const QueryCardCliGroupResult = (props: Props) => {
1111
const { result = [] } = props
1212
return (
13-
<div data-testid="query-cli-default-result" style={{ maxHeight: '210px' }}>
13+
<div data-testid="query-cli-default-result" className="query-card-output-response-success">
1414
{result[0]?.response.map((item: any, index: number) =>
1515
cliParseCommandsGroupResult(item, index))}
1616
</div>

redisinsight/ui/src/components/query-card/QueryCardHeader/QueryCardHeader.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export interface Props {
4040
summaryText?: string
4141
activeMode: RunQueryMode
4242
mode: RunQueryMode
43-
resultsMode?: ResultsMode
43+
activeResultsMode?: ResultsMode
4444
summary?: string
4545
queryType: WBQueryType
4646
selectedValue: string
@@ -64,7 +64,7 @@ const QueryCardHeader = (props: Props) => {
6464
summaryText,
6565
createdAt,
6666
mode,
67-
resultsMode,
67+
activeResultsMode,
6868
summary,
6969
activeMode,
7070
selectedValue,
@@ -92,7 +92,7 @@ const QueryCardHeader = (props: Props) => {
9292
databaseId: instanceId,
9393
command: getCommandNameFromQuery(query, COMMANDS_SPEC),
9494
rawMode: activeMode === RunQueryMode.Raw,
95-
group: resultsMode === ResultsMode.GroupMode,
95+
group: activeResultsMode === ResultsMode.GroupMode,
9696
...additionalData
9797
}
9898
})

redisinsight/ui/src/components/query/Query/Query.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -516,8 +516,9 @@ const Query = (props: Props) => {
516516
? 'Please wait while the commands are being executed…'
517517
: KEYBOARD_SHORTCUTS?.workbench?.runQuery && (
518518
<div style={{ display: 'flex', alignItems: 'baseline' }}>
519-
<EuiText size="s">{`${KEYBOARD_SHORTCUTS.workbench.runQuery?.label}:\u00A0\u00A0`}</EuiText>
519+
<EuiText className={styles.tooltipText} size="s">{`${KEYBOARD_SHORTCUTS.workbench.runQuery?.label}:\u00A0\u00A0`}</EuiText>
520520
<KeyboardShortcut
521+
badgeTextClassName={styles.tooltipText}
521522
separator={KEYBOARD_SHORTCUTS?._separator}
522523
items={KEYBOARD_SHORTCUTS.workbench.runQuery.keys}
523524
/>
@@ -545,8 +546,9 @@ const Query = (props: Props) => {
545546
content={
546547
KEYBOARD_SHORTCUTS?.workbench?.changeGroupMode && (
547548
<div style={{ display: 'flex', alignItems: 'baseline' }}>
548-
<EuiText size="s">{`${KEYBOARD_SHORTCUTS.workbench.changeGroupMode?.label}:\u00A0\u00A0`}</EuiText>
549+
<EuiText className={styles.tooltipText} size="s">{`${KEYBOARD_SHORTCUTS.workbench.changeGroupMode?.label}:\u00A0\u00A0`}</EuiText>
549550
<KeyboardShortcut
551+
badgeTextClassName={styles.tooltipText}
550552
separator={KEYBOARD_SHORTCUTS?._separator}
551553
items={KEYBOARD_SHORTCUTS.workbench.changeGroupMode.keys}
552554
/>

redisinsight/ui/src/components/query/Query/styles.module.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,3 +137,7 @@
137137
height: 24px;
138138
}
139139
}
140+
141+
.tooltipText {
142+
font-size: 12px !important;
143+
}

redisinsight/ui/src/components/query/QueryWrapper.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export interface Props {
2828

2929
interface IState {
3030
activeMode: RunQueryMode
31-
resultsMode: ResultsMode
31+
resultsMode?: ResultsMode
3232
}
3333

3434
let state: IState = {
@@ -58,7 +58,7 @@ const QueryWrapper = (props: Props) => {
5858

5959
state = {
6060
activeMode,
61-
resultsMode: ResultsMode.Default
61+
resultsMode
6262
}
6363

6464
const sendEventSubmitTelemetry = (commandInit = query) => {

redisinsight/ui/src/pages/workbench/components/wb-results/WBResults/WBResults.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { Theme } from 'uiSrc/constants'
66
import { Nullable } from 'uiSrc/utils'
77
import QueryCard from 'uiSrc/components/query-card'
88
import { CommandExecutionUI } from 'uiSrc/slices/interfaces'
9-
import { RunQueryMode } from 'uiSrc/slices/interfaces/workbench'
9+
import { RunQueryMode, ResultsMode } from 'uiSrc/slices/interfaces/workbench'
1010
import { ThemeContext } from 'uiSrc/contexts/themeContext'
1111
import MultiPlayIconDark from 'uiSrc/assets/img/multi_play_icon_dark.svg'
1212
import MultiPlayIconLight from 'uiSrc/assets/img/multi_play_icon_light.svg'
@@ -15,6 +15,7 @@ import styles from './styles.module.scss'
1515
export interface Props {
1616
items: CommandExecutionUI[]
1717
activeMode: RunQueryMode
18+
activeResultsMode?: ResultsMode
1819
scrollDivRef: React.Ref<HTMLDivElement>
1920
onQueryReRun: (query: string, commandId?: Nullable<string>, clearEditor?: boolean) => void
2021
onQueryDelete: (commandId: string) => void
@@ -24,6 +25,7 @@ const WBResults = (props: Props) => {
2425
const {
2526
items = [],
2627
activeMode,
28+
activeResultsMode,
2729
onQueryReRun,
2830
onQueryDelete,
2931
onQueryOpen,
@@ -76,6 +78,7 @@ const WBResults = (props: Props) => {
7678
emptyCommand={emptyCommand}
7779
isNotStored={isNotStored}
7880
mode={mode}
81+
activeResultsMode={activeResultsMode}
7982
resultsMode={resultsMode}
8083
onQueryOpen={() => onQueryOpen(id)}
8184
onQueryReRun={() => onQueryReRun(command, null, false)}

redisinsight/ui/src/pages/workbench/components/wb-results/WBResultsWrapper.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
import React from 'react'
22
import { Nullable } from 'uiSrc/utils'
33
import { CommandExecutionUI } from 'uiSrc/slices/interfaces'
4-
import { RunQueryMode } from 'uiSrc/slices/interfaces/workbench'
4+
import { RunQueryMode, ResultsMode } from 'uiSrc/slices/interfaces/workbench'
55
import WBResults from './WBResults'
66

77
export interface Props {
88
items: CommandExecutionUI[]
99
activeMode: RunQueryMode
10+
activeResultsMode: ResultsMode
1011
scrollDivRef: React.Ref<HTMLDivElement>
1112
onQueryReRun: (query: string, commandId?: Nullable<string>, clearEditor?: boolean) => void
1213
onQueryOpen: (commandId: string) => void

redisinsight/ui/src/pages/workbench/components/wb-view/WBView/WBView.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ const WBView = (props: Props) => {
138138
<WBResultsWrapper
139139
items={items}
140140
activeMode={activeMode}
141+
activeResultsMode={resultsMode}
141142
scrollDivRef={scrollDivRef}
142143
onQueryReRun={onSubmit}
143144
onQueryOpen={onQueryOpen}

0 commit comments

Comments
 (0)