Skip to content

Commit 8c24e6e

Browse files
authored
Merge pull request #2714 from RedisInsight/e2e/bugfix/drag-test-fixes
E2e/bugfix/drag test fixes
2 parents 3da381d + b7f8581 commit 8c24e6e

File tree

3 files changed

+13
-20
lines changed

3 files changed

+13
-20
lines changed

tests/e2e/pageObjects/browser-page.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -572,6 +572,7 @@ export class BrowserPage extends InstancePage {
572572
*/
573573
async deleteKeyByName(keyName: string): Promise<void> {
574574
await this.searchByKeyName(keyName);
575+
await t.hover(this.keyNameInTheList);
575576
await t.click(this.keyNameInTheList);
576577
await t.click(this.deleteKeyButton);
577578
await t.click(this.confirmDeleteKeyButton);

tests/e2e/tests/web/critical-path/url-handling/url-handling.e2e.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ test
4444
await t.expect(myRedisDatabasePage.AddRedisDatabase.disabledDatabaseInfo.nth(1).getAttribute('title')).contains(port, 'Wrong port value');
4545
await t.click(myRedisDatabasePage.AddRedisDatabase.addRedisDatabaseButton);
4646
// wait for db is added
47-
await t.wait(7_000);
47+
await t.wait(10_000);
4848
await t.expect(workbenchPage.closeEnablementPage.exists).ok('Redirection to Workbench tutorial is not correct');
4949
});
5050

@@ -76,12 +76,12 @@ test
7676
};
7777

7878
await t.navigateTo(generateLink(connectUrlParams));
79-
await t.wait(7_000);
79+
await t.wait(10_000);
8080
await t.expect(workbenchPage.closeEnablementPage.exists).ok('Redirection to Workbench tutorial is not correct');
8181

8282
//Verify that the same db is not added
8383
await t.navigateTo(generateLink(connectUrlParams));
84-
await t.wait(5_000);
84+
await t.wait(10_000);
8585
await t.click(workbenchPage.NavigationPanel.myRedisDBButton);
8686
await t.expect(browserPage.notification.exists).notOk({ timeout: 10000 });
8787
await t.expect(myRedisDatabasePage.dbNameList.child('span').withExactText(databaseName).count).eql(2, 'the same db is added twice');

tests/e2e/tests/web/regression/browser/resize-columns.e2e.ts

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import { rte } from '../../../../helpers/constants';
77
import { commonUrl, ossStandaloneConfig } from '../../../../helpers/conf';
88
import { DatabaseAPIRequests } from '../../../../helpers/api/api-database';
99
import { Common } from '../../../../helpers/common';
10+
import { t } from 'testcafe';
1011

1112
const myRedisDatabasePage = new MyRedisDatabasePage();
1213
const browserPage = new BrowserPage();
@@ -39,9 +40,9 @@ const keys = [
3940
];
4041
const keyNames: string[] = [];
4142
keys.forEach(key => keyNames.push(key.name));
42-
let databaseName1 = `testDB1_${Common.generateWord(10)}`;
43-
let databaseName2 = `testDB2_${Common.generateWord(10)}`;
44-
let databasesForAdding = [
43+
const databaseName1 = `testDB1_${Common.generateWord(10)}`;
44+
const databaseName2 = `testDB2_${Common.generateWord(10)}`;
45+
const databasesForAdding = [
4546
{ host: ossStandaloneConfig.host, port: ossStandaloneConfig.port, databaseName: databaseName1 },
4647
{ host: ossStandaloneConfig.host, port: ossStandaloneConfig.port, databaseName: databaseName2 }
4748
];
@@ -50,18 +51,9 @@ fixture `Resize columns in Key details`
5051
.meta({ type: 'regression', rte: rte.standalone })
5152
.page(commonUrl)
5253
.beforeEach(async() => {
53-
databaseName1 = `testDB1_${Common.generateWord(10)}`;
54-
databaseName2 = `testDB2_${Common.generateWord(10)}`;
55-
databasesForAdding = [
56-
{ host: ossStandaloneConfig.host, port: ossStandaloneConfig.port, databaseName: databaseName1 },
57-
{ host: ossStandaloneConfig.host, port: ossStandaloneConfig.port, databaseName: databaseName2 }
58-
];
5954
// Add new databases using API
60-
await databaseHelper.acceptLicenseTerms();
61-
await databaseAPIRequests.addNewStandaloneDatabasesApi(databasesForAdding);
62-
// Reload Page
63-
await myRedisDatabasePage.reloadPage();
64-
await myRedisDatabasePage.clickOnDBByName(databasesForAdding[0].databaseName);
55+
await databaseHelper.acceptLicenseTermsAndAddDatabaseApi(databasesForAdding[0]);
56+
await databaseAPIRequests.addNewStandaloneDatabaseApi(databasesForAdding[1]);
6557
await browserPage.addHashKey(keys[0].name, '2147476121', longFieldName, longFieldName);
6658
await browserPage.addListKey(keys[1].name, '2147476121', 'element');
6759
await browserPage.addZSetKey(keys[2].name, '1', '2147476121', 'member');
@@ -81,18 +73,18 @@ test('Resize of columns in Hash, List, Zset Key details', async t => {
8173
// Remember initial column width
8274
key.fieldWidthStart = await field.clientWidth;
8375
await t.hover(tableHeaderResizeTrigger);
84-
await t.drag(tableHeaderResizeTrigger, -key.offsetX, 0, { speed: 0.2 });
76+
await t.drag(tableHeaderResizeTrigger, -key.offsetX, 0, { speed: 0.1 });
8577
// Remember last column width
8678
key.fieldWidthEnd = await field.clientWidth;
8779
// Verify that user can resize columns for Hash, List, Zset Keys
88-
await t.expect(key.fieldWidthEnd).eql(key.fieldWidthStart - key.offsetX, `Field is not resized for ${key.type} key`);
80+
await t.expect(key.fieldWidthEnd).within(key.fieldWidthStart - key.offsetX - 5, key.fieldWidthStart - key.offsetX + 5, `Field is not resized for ${key.type} key`);
8981
}
9082

9183
// Verify that resize saved when switching between pages
9284
await t.click(myRedisDatabasePage.NavigationPanel.workbenchButton);
9385
await t.click(myRedisDatabasePage.NavigationPanel.browserButton);
9486
await browserPage.openKeyDetails(keys[0].name);
95-
await t.expect(field.clientWidth).eql(keys[0].fieldWidthEnd, 'Resize context not saved for key when switching between pages');
87+
await t.expect(field.clientWidth).within(keys[0].fieldWidthEnd - 5, keys[0].fieldWidthEnd + 5, 'Resize context not saved for key when switching between pages');
9688

9789
// Apply filter to save it in filter history
9890
await browserPage.searchByKeyName(`${keys[0].name}*`);

0 commit comments

Comments
 (0)