Skip to content

Commit 95fae3c

Browse files
Merge pull request #388 from RedisInsight/fix/RI-2475_RI-2479_RI-2485_RI-2489_bugfixing
#RI2475, #2479, #2485, #2489 - fix settings page, redisstack edit page
2 parents c4df4ee + 389577c commit 95fae3c

File tree

4 files changed

+12
-9
lines changed

4 files changed

+12
-9
lines changed

redisinsight/ui/src/components/instance-header/InstanceHeader.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@ import cx from 'classnames'
55
import { EuiButtonIcon, EuiFlexGroup, EuiFlexItem, EuiIcon, EuiToolTip } from '@elastic/eui'
66

77
import { Pages } from 'uiSrc/constants'
8+
import { BuildType } from 'uiSrc/constants/env'
89
import { ConnectionType } from 'uiSrc/slices/interfaces'
910
import { connectedInstanceOverviewSelector, connectedInstanceSelector } from 'uiSrc/slices/instances'
11+
import { appInfoSelector } from 'uiSrc/slices/app/info'
1012
import ShortInstanceInfo from 'uiSrc/components/instance-header/components/ShortInstanceInfo'
1113
import DatabaseOverviewWrapper from 'uiSrc/components/database-overview/DatabaseOverviewWrapper'
1214

@@ -22,6 +24,7 @@ const InstanceHeader = () => {
2224
db = 0
2325
} = useSelector(connectedInstanceSelector)
2426
const { version } = useSelector(connectedInstanceOverviewSelector)
27+
const { server } = useSelector(appInfoSelector)
2528
const history = useHistory()
2629
const [windowDimensions, setWindowDimensions] = useState(0)
2730

@@ -49,14 +52,14 @@ const InstanceHeader = () => {
4952
<div>
5053
<EuiToolTip
5154
position="bottom"
52-
content="My Redis databases"
55+
content={server?.buildType === BuildType.RedisStack ? 'Edit database' : 'My Redis databases'}
5356
>
5457
<EuiButtonIcon
5558
display="empty"
5659
size="s"
5760
iconSize="l"
5861
iconType="sortLeft"
59-
aria-label="My Redis databases"
62+
aria-label={server?.buildType === BuildType.RedisStack ? 'Edit database' : 'My Redis databases'}
6063
data-testid="my-redis-db-icon"
6164
onClick={goHome}
6265
/>

redisinsight/ui/src/components/main-router/constants/redisStackRoutes.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { PageNames, Pages, IRoute } from 'uiSrc/constants'
22
import {
3-
BrowserPage, InstancePage, SettingsPage,
3+
BrowserPage, InstancePage,
44
} from 'uiSrc/pages'
55
import WorkbenchPage from 'uiSrc/pages/workbench'
66
import EditConnection from 'uiSrc/pages/redisStack/components/edit-connection'
@@ -28,10 +28,6 @@ const ROUTES: IRoute[] = [
2828
component: EditConnection,
2929
},
3030
...COMMON_ROUTES,
31-
{
32-
path: Pages.settings,
33-
component: SettingsPage,
34-
},
3531
{
3632
path: '/:instanceId',
3733
protected: true,

redisinsight/ui/src/components/navigation-menu/NavigationMenu.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ const NavigationMenu = ({ buildType }: IProps) => {
233233
<EuiPageSideBar aria-label="Main navigation" className={cx(styles.navigation, 'eui-yScroll')}>
234234
<div className={styles.container}>
235235
<EuiToolTip
236-
content={buildType === BuildType.RedisStack ? 'Redis Stack' : 'My Redis databases'}
236+
content={buildType === BuildType.RedisStack ? 'Edit database' : 'My Redis databases'}
237237
position="right"
238238
>
239239
<span className={styles.iconLogo}>

redisinsight/ui/src/pages/redisStack/components/edit-connection/EditConnection.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ const EditConnection = () => {
4949
}
5050
}, [])
5151

52+
const onClose = () => history.goBack()
53+
5254
const getInstanceInfo = async () => {
5355
try {
5456
setState(DEFAULT_STATE)
@@ -68,7 +70,7 @@ const EditConnection = () => {
6870
const onInstanceChanged = () => {
6971
if (server?.fixedDatabaseId) {
7072
dispatch(setConnectedInstanceId(server.fixedDatabaseId))
71-
history.push(Pages.browser(server?.fixedDatabaseId))
73+
history.goBack()
7274
}
7375
}
7476

@@ -78,6 +80,7 @@ const EditConnection = () => {
7880

7981
const CreateCloudBtn = ({ content }: { content: ContentCreateRedis }) => {
8082
const { title, description, styles, links } = content
83+
8184
// @ts-ignore
8285
const linkStyles = styles ? styles[theme] : {}
8386
return (
@@ -123,6 +126,7 @@ const EditConnection = () => {
123126
onDbAdded={() => {}}
124127
onDbEdited={onInstanceChanged}
125128
onAliasEdited={onAliasChanged}
129+
onClose={onClose}
126130
/>
127131
</div>
128132
<div id="footerDatabaseForm" />

0 commit comments

Comments
 (0)