Skip to content

Commit 978284e

Browse files
committed
updates for ssh e2e
1 parent 0db4087 commit 978284e

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

tests/e2e/tests/electron/critical-path/database/add-ssh-db.e2e.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ fixture `Adding database with SSH`
4343
await databaseAPIRequests.deleteStandaloneDatabasesByNamesApi([sshDbPass.databaseName, sshDbPrivateKey.databaseName, sshDbPasscode.databaseName, newClonedDatabaseAlias]);
4444
});
4545
test('Adding database with SSH', async t => {
46+
const hiddenPass = '************';
4647
const sshWithPass = {
4748
...sshParams,
4849
sshPassword: 'pass'
@@ -94,9 +95,10 @@ test('Adding database with SSH', async t => {
9495
await t.click(myRedisDatabasePage.AddRedisDatabase.addRedisDatabaseButton);
9596
await t.expect(myRedisDatabasePage.AddRedisDatabase.addRedisDatabaseButton.exists).notOk('Edit database panel still displayed');
9697
await databaseHelper.clickOnEditDatabaseByName(sshDbPrivateKey.databaseName);
98+
// Verify that password, passphrase and private key are hidden for SSH option
9799
await t
98-
.expect(myRedisDatabasePage.AddRedisDatabase.sshPrivateKeyInput.value).eql(sshWithPassphrase.sshPrivateKey, 'Edited Private key not saved')
99-
.expect(myRedisDatabasePage.AddRedisDatabase.sshPassphraseInput.value).eql(sshWithPassphrase.sshPassphrase, 'Edited Passphrase not saved');
100+
.expect(myRedisDatabasePage.AddRedisDatabase.sshPrivateKeyInput.textContent).eql(hiddenPass, 'Edited Private key not saved')
101+
.expect(myRedisDatabasePage.AddRedisDatabase.sshPassphraseInput.value).eql(hiddenPass, 'Edited Passphrase not saved');
100102

101103
// Verify that user can clone database with SSH tunnel
102104
await databaseHelper.clickOnEditDatabaseByName(sshDbPrivateKey.databaseName);

tests/e2e/tests/web/critical-path/database/connecting-to-the-db.e2e.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ test
8989
// Delete databases
9090
await databaseAPIRequests.deleteStandaloneDatabasesByNamesApi([sshDbPass.databaseName, sshDbPrivateKey.databaseName, sshDbPasscode.databaseName, newClonedDatabaseAlias]);
9191
})('Adding database with SSH', async t => {
92+
const hiddenPass = '************';
9293
// const tooltipText = [
9394
// 'Enter a value for required fields (3):',
9495
// 'SSH Host',
@@ -146,9 +147,10 @@ test
146147
await t.click(myRedisDatabasePage.AddRedisDatabase.addRedisDatabaseButton);
147148
await t.expect(myRedisDatabasePage.AddRedisDatabase.addRedisDatabaseButton.exists).notOk('Edit database panel still displayed');
148149
await databaseHelper.clickOnEditDatabaseByName(sshDbPrivateKey.databaseName);
150+
// Verify that password, passphrase and private key are hidden for SSH option
149151
await t
150-
.expect(myRedisDatabasePage.AddRedisDatabase.sshPrivateKeyInput.value).eql(sshWithPassphrase.sshPrivateKey, 'Edited Private key not saved')
151-
.expect(myRedisDatabasePage.AddRedisDatabase.sshPassphraseInput.value).eql(sshWithPassphrase.sshPassphrase, 'Edited Passphrase not saved');
152+
.expect(myRedisDatabasePage.AddRedisDatabase.sshPrivateKeyInput.textContent).eql(hiddenPass, 'Edited Private key not saved')
153+
.expect(myRedisDatabasePage.AddRedisDatabase.sshPassphraseInput.value).eql(hiddenPass, 'Edited Passphrase not saved');
152154

153155
// Verify that user can clone database with SSH tunnel
154156
await databaseHelper.clickOnEditDatabaseByName(sshDbPrivateKey.databaseName);

0 commit comments

Comments
 (0)