fix unit tests

Author: egor-zalenski

redisinsight/ui/src/components/cli/CliWrapper.spec.tsx

@@ -1,16 +1,15 @@
 import { cloneDeep } from 'lodash'
 import React from 'react'
-import { processCliClient, setCliEnteringCommand } from 'uiSrc/slices/cli/cli-settings'
-import { cleanup, mockedStore, render } from 'uiSrc/utils/test-utils'
+import { InitOutputText } from 'uiSrc/constants/cliOutput'
+import { concatToOutput } from 'uiSrc/slices/cli/cli-output'
+import { setCliEnteringCommand } from 'uiSrc/slices/cli/cli-settings'
+import { cleanup, clearStoreActions, mockedStore, render } from 'uiSrc/utils/test-utils'
 import CliWrapper from './CliWrapper'
 
-jest.mock('uiSrc/slices/cli/cli-output', () => ({
-  ...jest.requireActual('uiSrc/slices/cli/cli-output'),
-  concatToOutput: () => jest.fn(),
-}))
-
 const redisCommandsPath = 'uiSrc/slices/app/redis-commands'
 
+let mathRandom: jest.SpyInstance<number>
+const random = 0.91911
 let store: typeof mockedStore
 beforeEach(() => {
   cleanup()
@@ -32,6 +31,14 @@ jest.mock(redisCommandsPath, () => {
 })
 
 describe('CliWrapper', () => {
+  beforeAll(() => {
+    mathRandom = jest.spyOn(Math, 'random').mockImplementation(() => random)
+  })
+
+  afterAll(() => {
+    mathRandom.mockRestore()
+  })
+
   it('should render', () => {
     expect(render(<CliWrapper />)).toBeTruthy()
   })
@@ -40,7 +47,12 @@ describe('CliWrapper', () => {
 
     unmount()
 
-    const expectedActions = [processCliClient(), setCliEnteringCommand()]
-    expect(store.getActions().slice(-2)).toEqual(expectedActions)
+    const handleWorkbenchClick = () => {}
+
+    const expectedActions = [
+      concatToOutput(InitOutputText('', 0, 0, true, handleWorkbenchClick)),
+      setCliEnteringCommand(),
+    ]
+    expect(clearStoreActions(store.getActions().slice(-2))).toEqual(clearStoreActions(expectedActions))
   })
 })

redisinsight/ui/src/components/cli/components/cli-body/CliBodyWrapper.tsx

@@ -53,7 +53,7 @@ const CliBodyWrapper = () => {
   const { db: currentDbIndex } = useSelector(outputSelector)
 
   useEffect(() => {
-    !cliClientUuid && dispatch(createCliClientAction(handleWorkbenchClick))
+    !cliClientUuid && dispatch(createCliClientAction(instanceId, handleWorkbenchClick))
   }, [])
 
   useEffect(() => {

redisinsight/ui/src/mocks/handlers/app/index.ts

@@ -0,0 +1,6 @@
+import { DefaultBodyType, MockedRequest, RestHandler } from 'msw'
+
+import info from './infoHandlers'
+
+const handlers: RestHandler<MockedRequest<DefaultBodyType>>[] = [].concat(info)
+export default handlers

redisinsight/ui/src/mocks/handlers/app/infoHandlers.ts

@@ -0,0 +1,22 @@
+import { DatabaseInstanceResponse } from 'apiSrc/modules/instances/dto/database-instance.dto'
+import { rest, RestHandler } from 'msw'
+import { ApiEndpoints } from 'uiSrc/constants'
+import { getMswURL } from 'uiSrc/utils/test-utils'
+
+export const APP_INFO_DATA_MOCK = {
+  id: 'id1',
+  createDateTime: '2000-01-01T00:00:00.000Z',
+  appVersion: '2.0.0',
+  osPlatform: 'win32',
+  buildType: 'ELECTRON'
+}
+
+const handlers: RestHandler[] = [
+  // fetchServerInfo
+  rest.get<DatabaseInstanceResponse[]>(getMswURL(ApiEndpoints.INFO), async (req, res, ctx) => res(
+    ctx.status(200),
+    ctx.json(APP_INFO_DATA_MOCK),
+  ))
+]
+
+export default handlers

redisinsight/ui/src/mocks/handlers/index.ts

@@ -1,5 +1,6 @@
 import { MockedRequest, RestHandler } from 'msw'
 import instances from './instances'
 import content from './content'
+import app from './app'
 
-export const handlers: RestHandler<MockedRequest>[] = [].concat(instances, content)
+export const handlers: RestHandler<MockedRequest>[] = [].concat(instances, content, app)

redisinsight/ui/src/mocks/handlers/instances/instancesHandlers.ts

@@ -4,6 +4,8 @@ import { ApiEndpoints } from 'uiSrc/constants'
 import { ConnectionType } from 'uiSrc/slices/interfaces'
 import { getMswURL } from 'uiSrc/utils/test-utils'
 
+export const INSTANCE_ID_MOCK = 'instanceId'
+
 const handlers: RestHandler[] = [
   // fetchInstancesAction
   rest.get<DatabaseInstanceResponse[]>(getMswURL(ApiEndpoints.INSTANCE), async (req, res, ctx) => res(

redisinsight/ui/src/slices/cli/cli-settings.ts

@@ -182,6 +182,7 @@ export default cliSettingsSlice.reducer
 
 // Asynchronous thunk action
 export function createCliClientAction(
+  instanceId: string,
   onWorkbenchClick: () => void,
   onSuccessAction?: () => void,
   onFailAction?: (message: string) => void
@@ -195,7 +196,7 @@ export function createCliClientAction(
 
     try {
       const { data, status } = await apiService.post<CreateCliClientResponse>(
-        getUrl(state.connections.instances.connectedInstance?.id ?? '', ApiEndpoints.CLI)
+        getUrl(instanceId ?? '', ApiEndpoints.CLI)
       )
 
       if (isStatusSuccessful(status)) {

redisinsight/ui/src/slices/tests/cli/cli-output.spec.ts

@@ -8,7 +8,7 @@ import { apiService } from 'uiSrc/services'
 import { cliTexts } from 'uiSrc/constants/cliOutput'
 import { cliParseTextResponseWithOffset, cliParseTextResponseWithRedirect } from 'uiSrc/utils/cliHelper'
 import ApiErrors from 'uiSrc/constants/apiErrors'
-import { updateCliClientAction } from 'uiSrc/slices/cli/cli-settings'
+import { processCliClient, updateCliClientAction } from 'uiSrc/slices/cli/cli-settings'
 import reducer, {
   concatToOutput,
   initialState,
@@ -354,10 +354,8 @@ describe('cliOutput slice', () => {
           sendCliCommand(),
           sendCliCommandFailure(responsePayload.response.data.message),
           concatToOutput(cliParseTextResponseWithOffset(errorMessage, command, CommandExecutionStatus.Fail)),
-          concatToOutput(['\n']),
-          concatToOutput(['\n'])
+          processCliClient(),
         ]
-        expect(updateCliClientAction).toHaveBeenCalled()
         expect(clearStoreActions(tempStore.getActions())).toEqual(clearStoreActions(expectedActions))
       })
     })
@@ -484,10 +482,8 @@ describe('cliOutput slice', () => {
           sendCliCommand(),
           sendCliCommandFailure(responsePayload.response.data.message),
           concatToOutput(cliParseTextResponseWithOffset(errorMessage, command, CommandExecutionStatus.Fail)),
-          concatToOutput(['\n']),
-          concatToOutput(['\n'])
+          processCliClient(),
         ]
-        expect(updateCliClientAction).toHaveBeenCalled()
         expect(clearStoreActions(tempStore.getActions())).toEqual(clearStoreActions(expectedActions))
       })
     })

redisinsight/ui/src/slices/tests/cli/cli-settings.spec.ts

@@ -7,6 +7,7 @@ import {
   ConnectionSuccessOutputText,
   InitOutputText,
 } from 'uiSrc/constants/cliOutput'
+import { INSTANCE_ID_MOCK } from 'uiSrc/mocks/handlers/instances/instancesHandlers'
 import reducer, {
   initialState,
   toggleCli,
@@ -32,11 +33,8 @@ import reducer, {
   resetCliHelperSettings, goBackFromCommand,
 } from '../../cli/cli-settings'
 
-jest.mock('uiSrc/constants/cliOutput', () => ({
-  ...jest.requireActual('uiSrc/constants/cliOutput'),
-  InitOutputText: jest.fn().mockReturnValue([]),
-}))
-
+let mathRandom: jest.SpyInstance<number>
+const random = 0.91911
 let store: typeof mockedStore
 beforeEach(() => {
   cleanup()
@@ -53,6 +51,14 @@ jest.mock('uiSrc/services', () => ({
 }))
 
 describe('cliSettings slice', () => {
+  beforeAll(() => {
+    mathRandom = jest.spyOn(Math, 'random').mockImplementation(() => random)
+  })
+
+  afterAll(() => {
+    mathRandom.mockRestore()
+  })
+
   describe('toggleCliHelper', () => {
     it('default state.isShowHelper should be falsy', () => {
       // Arrange
@@ -479,17 +485,17 @@ describe('cliSettings slice', () => {
       apiService.post = jest.fn().mockResolvedValue(responsePayload)
 
       // Act
-      await store.dispatch<any>(createCliClientAction())
+      await store.dispatch<any>(createCliClientAction(INSTANCE_ID_MOCK, () => {}))
 
       // Assert
       const expectedActions = [
         processCliClient(),
-        concatToOutput(InitOutputText()),
+        concatToOutput(InitOutputText('', 0, 0, true, () => {})),
         processCliClientSuccess(responsePayload.data?.uuid),
         concatToOutput(ConnectionSuccessOutputText),
         setCliDbIndex(0)
       ]
-      expect(store.getActions()).toEqual(expectedActions)
+      expect(clearStoreActions(store.getActions())).toEqual(clearStoreActions(expectedActions))
     })
 
     it('call both createCliClientAction and processCliClientFailure when fetch is fail', async () => {
@@ -505,12 +511,12 @@ describe('cliSettings slice', () => {
       apiService.post = jest.fn().mockRejectedValueOnce(responsePayload)
 
       // Act
-      await store.dispatch<any>(createCliClientAction())
+      await store.dispatch<any>(createCliClientAction(INSTANCE_ID_MOCK, () => {}))
 
       // Assert
       const expectedActions = [
         processCliClient(),
-        concatToOutput(InitOutputText()),
+        concatToOutput(InitOutputText('', 0, 0, true, () => {})),
         processCliClientFailure(responsePayload.response.data.message),
         concatToOutput(cliTexts.CLI_ERROR_MESSAGE(errorMessage))
       ]

yarn.lock

@@ -13676,14 +13676,7 @@ [email protected], rxjs@^6.5.2, rxjs@^6.6.0, rxjs@^6.6.3:
   dependencies:
     tslib "^1.9.0"
 
-rxjs@^7.5.2:
-  version "7.5.5"
-  resolved "https://registry.yarnpkg.com/rxjs/-/rxjs-7.5.5.tgz#2ebad89af0f560f460ad5cc4213219e1f7dd4e9f"
-  integrity sha512-sy+H0pQofO95VDmFLzyaw9xNJU4KTRSwQIGM6+iG3SypAtCiLDzpeG8sJrNCWn2Up9km+KhkvTdbkrdy+yzZdw==
-  dependencies:
-    tslib "^2.1.0"
-
-rxjs@^7.5.5:
+rxjs@^7.5.2, rxjs@^7.5.5:
   version "7.5.6"
   resolved "https://registry.yarnpkg.com/rxjs/-/rxjs-7.5.6.tgz#0446577557862afd6903517ce7cae79ecb9662bc"
   integrity sha512-dnyv2/YsXhnm461G+R/Pe5bWP41Nm6LBXEYWI6eiFP4fiwx6WRI/CD0zbdVAudd9xwLEF2IDcKXLHit0FYjUzw==
@@ -15285,12 +15278,7 @@ type-fest@^0.8.1:
   resolved "https://registry.yarnpkg.com/type-fest/-/type-fest-0.8.1.tgz#09e249ebde851d3b1e48d27c105444667f17b83d"
   integrity sha512-4dbzIzqvjtgiM5rw1k5rEHtBANKmdudhGyBEajN01fEyhaAIhsoKNy6y7+IN93IfpFtwY9iqi7kD+xwKhQsNJA==
 
-type-fest@^1.0.2:
-  version "1.2.2"
-  resolved "https://registry.yarnpkg.com/type-fest/-/type-fest-1.2.2.tgz#1930bc36b2064f7ab4aa307a6d1b65965199c698"
-  integrity sha512-pfkPYCcuV0TJoo/jlsUeWNV8rk7uMU6ocnYNvca1Vu+pyKi8Rl8Zo2scPt9O72gCsXIm+dMxOOWuA3VFDSdzWA==
-
-type-fest@^1.2.2:
+type-fest@^1.0.2, type-fest@^1.2.2:
   version "1.4.0"
   resolved "https://registry.yarnpkg.com/type-fest/-/type-fest-1.4.0.tgz#e9fb813fe3bf1744ec359d55d1affefa76f14be1"
   integrity sha512-yGSza74xk0UG8k+pLh5oeoYirvIiWo5t0/o3zHHAO2tRDiZcxWP7fywNlXhqb6/r6sWvwi+RsyQMWhVLe4BVuA==
@@ -16455,20 +16443,7 @@ yargs@^16.2.0:
     y18n "^5.0.5"
     yargs-parser "^20.2.2"
 
-yargs@^17.0.1:
-  version "17.2.1"
-  resolved "https://registry.yarnpkg.com/yargs/-/yargs-17.2.1.tgz#e2c95b9796a0e1f7f3bf4427863b42e0418191ea"
-  integrity sha512-XfR8du6ua4K6uLGm5S6fA+FIJom/MdJcFNVY8geLlp2v8GYbOXD4EB1tPNZsRn4vBzKGMgb5DRZMeWuFc2GO8Q==
-  dependencies:
-    cliui "^7.0.2"
-    escalade "^3.1.1"
-    get-caller-file "^2.0.5"
-    require-directory "^2.1.1"
-    string-width "^4.2.0"
-    y18n "^5.0.5"
-    yargs-parser "^20.2.2"
-
-yargs@^17.3.1:
+yargs@^17.0.1, yargs@^17.3.1:
   version "17.5.1"
   resolved "https://registry.yarnpkg.com/yargs/-/yargs-17.5.1.tgz#e109900cab6fcb7fd44b1d8249166feb0b36e58e"
   integrity sha512-t6YAJcxDkNX7NFYiVtKvWUz8l+PaKTLiL63mJYWR2GnHq2gjEWISzsLp9wg3aY36dY1j+gfIEL3pIF+XlJJfbA==