moved togglePanel to NavigationHeader

Author: vlad-dargel

tests/e2e/pageObjects/components/insights-panel.ts

@@ -2,11 +2,8 @@ import { Selector, t } from 'testcafe';
 import { ExploreTabs } from '../../helpers/constants';
 import { RecommendationsTab } from './recommendations-tab';
 import { ExploreTab } from './explore-tab';
-import { NavigationHeader } from './navigation/navigation-header';
 
 export class InsightsPanel {
-    NavigationHeader = new NavigationHeader();
-
     // CONTAINERS
     sidePanel = Selector('[data-testid=side-panels-insights]');
     closeButton = Selector('[data-testid=close-insights-btn]');
@@ -20,24 +17,13 @@ export class InsightsPanel {
 
     activeTabMask = '[class*=euiTab-isSelected]';
 
-    /**
-     * Open/Close  Panel
-     * @param state State of panel
-     */
-    async togglePanel(state: boolean): Promise<void> {
-        const isPanelExists = await this.sidePanel.exists;
-
-        if (state !== isPanelExists) {
-            await t.click(this.NavigationHeader.insightsTriggerButton);
-        }
-    }
-
     /**
      * get active tab
      */
     async getActiveTabName(): Promise<string> {
         return (this.sidePanel.find(this.activeTabMask)).textContent;
     }
+
     /**
      * Click on Panel tab
      * @param type of the tab
@@ -66,5 +52,4 @@ export class InsightsPanel {
     getInsightsPanel(): Selector {
         return Selector('[class=euiButton__text]').withExactText(ExploreTabs.Tips);
     }
-
 }

tests/e2e/pageObjects/components/navigation/navigation-header.ts

@@ -1,6 +1,19 @@
-import { Selector } from 'testcafe';
+import { t, Selector } from 'testcafe';
+import { InsightsPanel } from '../insights-panel';
 
 export class NavigationHeader {
     insightsTriggerButton = Selector('[data-testid=insights-trigger]');
     cloudSignInButton = Selector('[data-testid=cloud-sign-in-btn]');
+
+    /**
+     * Open/Close  Panel
+     * @param state State of panel
+     */
+    async togglePanel(state: boolean): Promise<void> {
+        const isPanelExists = await (new InsightsPanel()).sidePanel.exists;
+
+        if (state !== isPanelExists) {
+            await t.click(this.insightsTriggerButton);
+        }
+    }
 }

tests/e2e/tests/electron/critical-path/files-auto-update/enablement-area-autoupdate.e2e.ts

@@ -49,7 +49,7 @@ if (fs.existsSync(workingDirectory)) {
         await t.click(myRedisDatabasePage.NavigationPanel.workbenchButton);
 
         // Check Enablement area and validate that removed file is existed in Guides
-        await workbenchPage.InsightsPanel.togglePanel(true);
+        await workbenchPage.NavigationHeader.togglePanel(true);
         const tab = await workbenchPage.InsightsPanel.setActiveTab(ExploreTabs.Tutorials);
         await t.click(tab.guidesGraphAccordion);
         await t.click(tab.guidesIntroductionGraphLink.nth(1));

tests/e2e/tests/electron/regression/workbench/redis-stack-commands.e2e.ts

@@ -28,7 +28,7 @@ fixture `Redis Stack command in Workbench`
 //skipped due the inaccessibility of the iframe
 test.skip('Verify that user can switches between Graph and Text for GRAPH command and see results corresponding to their views', async t => {
     // Send Graph command
-    await workbenchPage.InsightsPanel.togglePanel(true);
+    await workbenchPage.NavigationHeader.togglePanel(true);
     const tutorials = await workbenchPage.InsightsPanel.setActiveTab(ExploreTabs.Tutorials);
     await t.click(tutorials.redisStackTutorialsButton);
     await t.click(tutorials.tutorialsWorkingWithGraphLink);
@@ -45,7 +45,7 @@ test.skip('Verify that user can switches between Graph and Text for GRAPH comman
 //skipped due to Graph no longer displayed in tutorials
 test.skip('Verify that user can see "No data to visualize" message for Graph command', async t => {
     // Send Graph command
-    await workbenchPage.InsightsPanel.togglePanel(true);
+    await workbenchPage.NavigationHeader.togglePanel(true);
     const tutorials = await workbenchPage.InsightsPanel.setActiveTab(ExploreTabs.Tutorials);
     await t.click(tutorials.redisStackTutorialsButton);
     await tutorials.runBlockCode('Show all sales per region');

tests/e2e/tests/web/critical-path/cluster-details/cluster-details.e2e.ts

@@ -75,7 +75,7 @@ test
             await t.expect(clusterDetailsPage.tableRow.nth(nodes.indexOf(node)).textContent).contains(node, `Node ${node} is not displayed in table`);
         }
         //Run Create hash index command to load network and memory
-        await clusterDetailsPage.InsightsPanel.togglePanel(true);
+        await clusterDetailsPage.NavigationHeader.togglePanel(true);
         const tutorials = await clusterDetailsPage.InsightsPanel.setActiveTab(ExploreTabs.Tutorials);
 
         await t.click(tutorials.dataStructureAccordionTutorialButton);

tests/e2e/tests/web/critical-path/database-overview/database-overview.e2e.ts

@@ -156,7 +156,7 @@ test
         await t.expect(browserPage.OverviewPanel.overviewCommandsSec.exists).ok('Commands/Sec is dispalyed in the Overview');
         await t.expect(browserPage.OverviewPanel.overviewCpu.exists).ok('CPU (%) is dispalyed in the Overview');
         //Run Create hash index command
-        await browserPage.InsightsPanel.togglePanel(true);
+        await browserPage.NavigationHeader.togglePanel(true);
         const tutorials = await browserPage.InsightsPanel.setActiveTab(ExploreTabs.Tutorials);
         await t.click(tutorials.dataStructureAccordionTutorialButton);
         await t.click(tutorials.internalLinkWorkingWithHashes);

tests/e2e/tests/web/critical-path/database/modules.e2e.ts

@@ -65,7 +65,7 @@ test('Verify that user can see full module list in the Edit mode', async t => {
     await t.expect(myRedisDatabasePage.connectionTypeTitle.visible).ok('connection type column not found');
     // Open Edit mode
     await t.click(myRedisDatabasePage.editDatabaseButton);
-    await myRedisDatabasePage.InsightsPanel.togglePanel(true);
+    await myRedisDatabasePage.NavigationHeader.togglePanel(true);
     // Verify that module column is not displayed
     await t.expect(myRedisDatabasePage.connectionTypeTitle.visible).notOk('connection type column not found');
     // Verify modules in Edit mode

tests/e2e/tests/web/critical-path/memory-efficiency/recommendations.e2e.ts

@@ -192,7 +192,7 @@ test
         await t.expect(recommendation.exists).ok('Query and search JSON documents recommendation not displayed');
         // Verify that tutorial opened
         await t.click(memoryEfficiencyPage.getToTutorialBtnByRecomName(searchJsonRecommendation));
-        await workbenchPage.InsightsPanel.togglePanel(true);
+        await workbenchPage.NavigationHeader.togglePanel(true);
         const tutorial = await workbenchPage.InsightsPanel.setActiveTab(ExploreTabs.Tutorials);
         await t.expect(tutorial.preselectArea.visible).ok('Workbench Enablement area not opened');
         // Verify that REDIS FOR TIME SERIES tutorial expanded

tests/e2e/tests/web/critical-path/rdi/navigation.e2e.ts

@@ -80,7 +80,7 @@ test('Verify that context is saved after navigation panel', async() => {
 
 test('Verify that Insight and Sign in buttons are displayed ', async() => {
     await t.expect(rdiInstancePage.NavigationHeader.insightsTriggerButton.exists).ok('Insight panel is not exist');
-    await rdiInstancePage.RdiHeader.InsightsPanel.togglePanel(true);
+    await rdiInstancePage.NavigationHeader.togglePanel(true);
     const tab = await rdiInstancePage.RdiHeader.InsightsPanel.getActiveTabName();
     await t.expect(tab).eql('Tutorials');
     await t.expect(rdiInstancePage.NavigationHeader.cloudSignInButton.exists).ok('sight in button is not exist');

tests/e2e/tests/web/critical-path/rdi/rdi-recommendation.e2e.ts

@@ -28,7 +28,7 @@ fixture.skip `Rdi recommendation`
     });
 // it doesn't work until recommendation.json is not updated
 test('Verify that rdi recommendation is displayed for oss cluster', async() => {
-    await browserPage.InsightsPanel.togglePanel(true);
+    await browserPage.NavigationHeader.togglePanel(true);
     const tab = await browserPage.InsightsPanel.setActiveTab(ExploreTabs.Tips);
     await t.expect(tab.getRecommendationByName(rdiRecommendation).exists).ok('Redis Version recommendation not displayed');
     await tab.clickOnNavigationButton(rdiRecommendation);