Skip to content

Commit 9c30e13

Browse files
committed
fixes
1 parent e3f77b3 commit 9c30e13

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

tests/e2e/docker.web.docker-compose.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ services:
77
dockerfile: static-server.Dockerfile
88
volumes:
99
- ./remote:/app/remote
10+
- ./test-data/features-configs:/app/test-data/features-configs
1011
ports:
1112
- 5551:5551
1213

tests/e2e/tests/regression/insights/feature-flag.e2e.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ test
9494
let featureVersion = await JSON.parse(await getColumnValueFromTableInDB(featuresConfigTable, 'data')).version;
9595
let versionFromConfig = await Common.getJsonPropertyValue('version', pathes.validConfig);
9696

97-
// Verify that config file updated from the GitHub repository if the GitHub file has the latest timestamp
9897
await t.expect(featureVersion).eql(versionFromConfig, 'Config with invalid data applied');
9998
// Verify that Insights panel displayed if user's controlNumber is in range from config file
10099
await t.expect(browserPage.InsightsPanel.insightsBtn.exists).ok('Insights panel not displayed when enabled from remote config');
@@ -104,7 +103,6 @@ test
104103
await myRedisDatabasePage.clickOnDBByName(ossStandaloneV5Config.databaseName);
105104
await t.expect(browserPage.InsightsPanel.insightsBtn.exists).ok('Insights panel not displayed for the other db connection');
106105
await browserPage.InsightsPanel.toggleInsightsPanel(true);
107-
// Verify that Insights panel displayed if user's controlNumber is in range from config file
108106
await t.expect(browserPage.InsightsPanel.getRecommendationByName(redisVersionRecom).exists).ok('Redis Version recommendation not displayed');
109107

110108
await browserPage.InsightsPanel.toggleInsightsPanel(false);
@@ -117,11 +115,11 @@ test
117115
// Update remote config .json to config without analytics filter
118116
await modifyFeaturesConfigJson(pathes.analyticsConfig);
119117
await updateControlNumber(48.2);
118+
// Verify that Insights panel can be displayed for WebStack app according to filters
120119
await t.expect(browserPage.InsightsPanel.insightsBtn.exists).ok('Insights panel not displayed without analytics when its filter is off');
121120

122-
// Verify that Insights panel not displayed if the local config file has it disabled
121+
// Verify that Insights panel displayed if user's controlNumber is out of range from config file
123122
await updateControlNumber(30.1);
124-
// Verify that Insights panel can be displayed for Electron/WebStack app according to filters
125123
await t.expect(browserPage.InsightsPanel.insightsBtn.exists).notOk('Insights panel displayed for user with control number out of the config');
126124

127125
// Update remote config .json to config with buildType filter excluding current app build
@@ -162,6 +160,5 @@ test
162160
// Update remote config .json to config with buildType filter including current app build
163161
await modifyFeaturesConfigJson(pathes.electronConfig);
164162
await updateControlNumber(48.2);
165-
// Verify that Insights panel can be displayed for Electron/WebStack app according to filters
166163
await t.expect(browserPage.InsightsPanel.insightsBtn.exists).ok('Insights panel not displayed when filter includes this buildType');
167164
});

0 commit comments

Comments
 (0)