Skip to content

Commit 9c3fea1

Browse files
authored
Merge pull request #1301 from RedisInsight/fe/feature/RI-3679_fix-negative-pipeline
#RI-3679 - fix negative pipeline param
2 parents daa82c2 + de2b7db commit 9c3fea1

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

redisinsight/ui/src/utils/tests/workbench.spec.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,20 @@ describe('getExecuteParams', () => {
1515
const btnParams3: CodeButtonParams = { pipeline: 'abc' }
1616
const btnParams4: CodeButtonParams = { results: 'single', mode: 'raw' }
1717
const btnParams5: CodeButtonParams = { results: 'single', mode: 'raw', pipeline: '4' }
18+
const btnParams6: CodeButtonParams = { results: 'single', mode: 'raw', pipeline: '-4' }
1819

1920
const expect1 = { activeRunQueryMode: RunQueryMode.Raw, resultsMode: ResultsMode.GroupMode, batchSize: 5 }
2021
const expect2 = { activeRunQueryMode: RunQueryMode.ASCII, resultsMode: ResultsMode.GroupMode, batchSize: 10 }
2122
const expect3 = { activeRunQueryMode: RunQueryMode.ASCII, resultsMode: ResultsMode.GroupMode, batchSize: 10 }
2223
const expect4 = { activeRunQueryMode: RunQueryMode.Raw, resultsMode: ResultsMode.Default, batchSize: 10 }
2324
const expect5 = { activeRunQueryMode: RunQueryMode.Raw, resultsMode: ResultsMode.Default, batchSize: 4 }
25+
const expect6 = { activeRunQueryMode: RunQueryMode.Raw, resultsMode: ResultsMode.Default, batchSize: 10 }
2426

2527
expect(getExecuteParams(btnParams1, paramsState)).toEqual(expect1)
2628
expect(getExecuteParams(btnParams2, paramsState)).toEqual(expect2)
2729
expect(getExecuteParams(btnParams3, paramsState)).toEqual(expect3)
2830
expect(getExecuteParams(btnParams4, paramsState)).toEqual(expect4)
2931
expect(getExecuteParams(btnParams5, paramsState)).toEqual(expect5)
32+
expect(getExecuteParams(btnParams6, paramsState)).toEqual(expect6)
3033
})
3134
})

redisinsight/ui/src/utils/workbench.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const getExecuteParams = (params: CodeButtonParams = {}, state: ExecuteQueryPara
2020
} = state
2121
const { results, mode, pipeline } = params
2222

23-
const batchSize = (pipeline && isInteger(+pipeline)) ? +pipeline : batchSizeState
23+
const batchSize = (pipeline && isInteger(+pipeline) && +pipeline >= 0) ? +pipeline : batchSizeState
2424
const resultsMode = (results && results in CodeButtonResults) ? CodeButtonResults[results] : resultsModeState
2525
const activeRunQueryMode = (mode && mode in CodeButtonRunQueryMode)
2626
? CodeButtonRunQueryMode[mode]

0 commit comments

Comments
 (0)