- Add null checks for generate profile command functions

- #1537 (comment)

Author: GnaneshKunal

redisinsight/ui/src/pages/workbench/constants.ts

@@ -34,7 +34,7 @@ export const GRAPH_COMMANDS = ['graph.query']
 const ALLOWED_PROFILE_COMMANDS = [...SEARCH_COMMANDS, ...GRAPH_COMMANDS]
 
 export const isCommandAllowedForProfile = (query: string) => {
-  return ALLOWED_PROFILE_COMMANDS.includes(query.split(' ')[0].toLowerCase())
+  return ALLOWED_PROFILE_COMMANDS.includes(query?.split(' ')?.[0]?.toLowerCase())
 }
 
 export enum ProfileQueryType {

redisinsight/ui/src/pages/workbench/utils.spec.ts

@@ -12,14 +12,14 @@ const generateGraphProfileQueryTests: Record<string, any>[] = [
   { input: 'GRAPH.QUERY key "MATCH (n) RETURN n"', output: 'graph.explain key "MATCH (n) RETURN n"', type: ProfileQueryType.Explain },
   { input: 'graph.query key "MATCH (n) RETURN n"', output: 'graph.profile key "MATCH (n) RETURN n"', type: ProfileQueryType.Profile },
   { input: 'graph.query key "MATCH (n) RETURN n"', output: 'graph.explain key "MATCH (n) RETURN n"', type: ProfileQueryType.Explain },
+  { input: null, output: null, type: ProfileQueryType.Profile },
+  { input: null, output: null, type: ProfileQueryType.Explain },
 ]
 
 describe('generateGraphProfileQuery', () => {
-
   generateGraphProfileQueryTests.forEach(test => {
     it(`should be output: ${test.output} for input: ${test.input} and type: ${test.type}`, () => {
       const result = generateGraphProfileQuery(test.input, test.type);
-
       expect(result).toEqual(test.output);
     });
   })
@@ -29,24 +29,24 @@ describe('generateGraphProfileQuery', () => {
 const generateSearchProfileQueryTests: Record<string, any>[] = [
   { input: 'FT.SEARCH index tomatoes', output: 'ft.profile index SEARCH QUERY tomatoes', type: ProfileQueryType.Profile },
   { input: 'FT.AGGREGATE index tomatoes', output: 'ft.profile index AGGREGATE QUERY tomatoes', type: ProfileQueryType.Profile },
-{ input: 'FT.SEARCH index tomatoes', output: 'ft.explain index tomatoes', type: ProfileQueryType.Explain },
+  { input: 'FT.SEARCH index tomatoes', output: 'ft.explain index tomatoes', type: ProfileQueryType.Explain },
   { input: 'FT.AGGREGATE index tomatoes', output: 'ft.explain index tomatoes', type: ProfileQueryType.Explain },
-{ input: 'ft.search index tomatoes', output: 'ft.profile index search QUERY tomatoes', type: ProfileQueryType.Profile },
+  { input: 'ft.search index tomatoes', output: 'ft.profile index search QUERY tomatoes', type: ProfileQueryType.Profile },
   { input: 'ft.aggregate index tomatoes', output: 'ft.profile index aggregate QUERY tomatoes', type: ProfileQueryType.Profile },
-{ input: 'ft.search index tomatoes', output: 'ft.explain index tomatoes', type: ProfileQueryType.Explain },
+  { input: 'ft.search index tomatoes', output: 'ft.explain index tomatoes', type: ProfileQueryType.Explain },
   { input: 'ft.aggregate index tomatoes', output: 'ft.explain index tomatoes', type: ProfileQueryType.Explain },
-{ input: 'ft.SEARCH index tomatoes', output: 'ft.profile index SEARCH QUERY tomatoes', type: ProfileQueryType.Profile },
+  { input: 'ft.SEARCH index tomatoes', output: 'ft.profile index SEARCH QUERY tomatoes', type: ProfileQueryType.Profile },
   { input: 'ft.AGGREGATE index tomatoes', output: 'ft.profile index AGGREGATE QUERY tomatoes', type: ProfileQueryType.Profile },
-{ input: 'ft.SEARCH index tomatoes', output: 'ft.explain index tomatoes', type: ProfileQueryType.Explain },
+  { input: 'ft.SEARCH index tomatoes', output: 'ft.explain index tomatoes', type: ProfileQueryType.Explain },
   { input: 'ft.AGGREGATE index tomatoes', output: 'ft.explain index tomatoes', type: ProfileQueryType.Explain },
+  { input: null, output: null, type: ProfileQueryType.Profile },
+  { input: null, output: null, type: ProfileQueryType.Explain },
 ]
 
 describe('generateSearchProfileQuery', () => {
-
   generateSearchProfileQueryTests.forEach(test => {
     it(`should be output: ${test.output} for input: ${test.input} and type: ${test.type}`, () => {
       const result = generateSearchProfileQuery(test.input, test.type);
-
       expect(result).toEqual(test.output);
     });
   })
@@ -63,9 +63,9 @@ const generateProfileQueryForCommandTests: Record<string, any>[] = [
   { input: 'GRAPH.EXPLAIN key "MATCH (n) RETURN n"', output: null, type: ProfileQueryType.Explain },
   { input: 'ft._LIST', output: null, type: ProfileQueryType.Profile },
   { input: 'ft._LIST', output: null, type: ProfileQueryType.Explain },
-{ input: 'ft.profile index SEARCH QUERY tomatoes', output: null, type: ProfileQueryType.Profile },
+  { input: 'ft.profile index SEARCH QUERY tomatoes', output: null, type: ProfileQueryType.Profile },
   { input: 'ft.profile index AGGREGATE QUERY tomatoes', output: null, type: ProfileQueryType.Explain },
-{ input: 'ft.explain index tomatoes', output: null, type: ProfileQueryType.Profile },
+  { input: 'ft.explain index tomatoes', output: null, type: ProfileQueryType.Profile },
   { input: 'ft.explain index tomatoes', output: null, type: ProfileQueryType.Explain },
 ]
 describe('generateProfileQueryForCommand', () => {

redisinsight/ui/src/pages/workbench/utils.ts

@@ -1,25 +1,35 @@
 import { ProfileQueryType, SEARCH_COMMANDS, GRAPH_COMMANDS } from './constants'
 
 export const generateGraphProfileQuery = (query: string, type: ProfileQueryType) => {
-  return [`graph.${type.toLowerCase()}`, ...query.split(' ').slice(1)].join(' ')
+  const q = query?.split(' ')?.slice(1)
+
+  if (q) {
+    return [`graph.${type.toLowerCase()}`, ...q].join(' ')
+  }
+
+  return null
 }
 
 export const generateSearchProfileQuery = (query: string, type: ProfileQueryType) => {
-  const commandSplit = query.split(' ')
-  const cmd = commandSplit[0]
+  const commandSplit = query?.split(' ')
+  const cmd = commandSplit?.[0]
+
+  if (!commandSplit || !cmd) {
+    return null
+  }
 
   if (type === ProfileQueryType.Explain) {
-    return [`ft.${type.toLowerCase()}`, ...commandSplit.slice(1)].join(' ')
+    return [`ft.${type.toLowerCase()}`, ...commandSplit?.slice(1)].join(' ')
   } else {
-    let index = commandSplit[1]
+    let index = commandSplit?.[1]
 
-    const queryType = cmd.split('.')[1] // SEARCH / AGGREGATE
-    return [`ft.${type.toLowerCase()}`, index, queryType, 'QUERY', ...commandSplit.slice(2)].join(' ')
+    const queryType = cmd.split('.')?.[1] // SEARCH / AGGREGATE
+    return [`ft.${type.toLowerCase()}`, index, queryType, 'QUERY', ...commandSplit?.slice(2)].join(' ')
   }
 }
 
 export const generateProfileQueryForCommand = (query: string, type: ProfileQueryType) => {
-  const cmd = query.split(' ')[0].toLowerCase()
+  const cmd = query?.split(' ')?.[0]?.toLowerCase()
 
   if (GRAPH_COMMANDS.includes(cmd)) {
     return generateGraphProfileQuery(query, type)