Skip to content

Commit 9e0f074

Browse files
#RI-3941 - resolve comments
1 parent a02461a commit 9e0f074

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

redisinsight/ui/src/pages/databaseAnalysis/components/recommendations-view/Recommendations.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ describe('Recommendations', () => {
341341

342342
render(<Recommendations />)
343343

344-
expect(screen.queryByTestId('redis-stack-link')).toBeInTheDocument()
345-
expect(screen.queryByTestId('redis-stack-link')).toHaveAttribute('href', 'https://redis.io/docs/stack/')
344+
expect(screen.queryByTestId('bigSets-redis-stack-link')).toBeInTheDocument()
345+
expect(screen.queryByTestId('bigSets-redis-stack-link')).toHaveAttribute('href', 'https://redis.io/docs/stack/')
346346
})
347347
})

redisinsight/ui/src/pages/databaseAnalysis/components/recommendations-view/Recommendations.tsx

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,23 +40,22 @@ const Recommendations = () => {
4040
}
4141
})
4242

43-
const onRedisStackClick = (event: React.MouseEvent<HTMLDivElement, MouseEvent>) => event.stopPropagation()
43+
const onRedisStackClick = (event: React.MouseEvent<HTMLButtonElement, MouseEvent>) => event.stopPropagation()
4444

4545
const sortedRecommendations = sortBy(recommendations, ({ name }) =>
4646
(recommendationsContent[name]?.redisStack ? -1 : 0))
4747

48-
const renderButtonContent = (redisStack: boolean, title: string, badges: string[]) => (
48+
const renderButtonContent = (redisStack: boolean, title: string, badges: string[], id: string) => (
4949
<EuiFlexGroup className={styles.accordionButton} responsive={false} alignItems="center" justifyContent="spaceBetween">
5050
<EuiFlexGroup alignItems="center">
51-
<EuiFlexItem grow={false}>
51+
<EuiFlexItem onClick={onRedisStackClick} grow={false}>
5252
{redisStack && (
5353
<EuiLink
5454
external={false}
5555
target="_blank"
5656
href="https://redis.io/docs/stack/"
5757
className={styles.redisStackLink}
58-
data-testid="redis-stack-link"
59-
onClick={onRedisStackClick}
58+
data-testid={`${id}-redis-stack-link`}
6059
>
6160
<EuiToolTip
6261
content="Redis Stack"
@@ -67,7 +66,7 @@ const Recommendations = () => {
6766
<EuiIcon
6867
type={theme === Theme.Dark ? RediStackDarkMin : RediStackLightMin}
6968
className={styles.redisStackIcon}
70-
data-testid="redis-stack-icon"
69+
data-testid={`${id}-redis-stack-icon`}
7170
/>
7271
</EuiToolTip>
7372
</EuiLink>
@@ -117,7 +116,7 @@ const Recommendations = () => {
117116
<EuiAccordion
118117
id={name}
119118
arrowDisplay="right"
120-
buttonContent={renderButtonContent(redisStack, title, badges)}
119+
buttonContent={renderButtonContent(redisStack, title, badges, id)}
121120
buttonClassName={styles.accordionBtn}
122121
buttonProps={{ 'data-test-subj': `${id}-button` }}
123122
className={styles.accordion}

0 commit comments

Comments
 (0)