resolve comments

Author: AmirAllayarovSofteq

redisinsight/api/src/constants/error-messages.ts

@@ -111,4 +111,5 @@ export default {
   RDI_DEPLOY_PIPELINE_FAILURE: 'Failed to deploy pipeline',
   RDI_TIMEOUT_ERROR: 'Encountered a timeout error while attempting to retrieve data',
   RDI_VALIDATION_ERROR: 'Validation error',
+  INVALID_RDI_INSTANCE_ID: 'Invalid rdi instance id.',
 };

redisinsight/api/src/modules/rdi/providers/rdi.client.provider.ts

@@ -1,12 +1,15 @@
 import { RdiClient } from 'src/modules/rdi/client/rdi.client';
-import { Injectable } from '@nestjs/common';
+import { Injectable, Logger, NotFoundException } from '@nestjs/common';
 import { RdiClientMetadata } from 'src/modules/rdi/models';
 import { RdiClientStorage } from 'src/modules/rdi/providers/rdi.client.storage';
 import { RdiClientFactory } from 'src/modules/rdi/providers/rdi.client.factory';
 import { RdiRepository } from 'src/modules/rdi/repository/rdi.repository';
+import ERROR_MESSAGES from 'src/constants/error-messages';
 
 @Injectable()
 export class RdiClientProvider {
+  private logger: Logger = new Logger('RdiClientProvider');
+
   constructor(
     private readonly repository: RdiRepository,
     private readonly rdiClientStorage: RdiClientStorage,
@@ -28,7 +31,10 @@ export class RdiClientProvider {
   async create(clientMetadata: RdiClientMetadata): Promise<RdiClient> {
     const rdi = await this.repository.get(clientMetadata.id);
 
-    // TODO add 404
+    if (!rdi) {
+      this.logger.error(`RDI with ${clientMetadata.id} was not Found`);
+      throw new NotFoundException(ERROR_MESSAGES.INVALID_RDI_INSTANCE_ID);
+    }
     return this.rdiClientFactory.createClient(clientMetadata, rdi);
   }
 

redisinsight/api/src/modules/rdi/rdi-pipeline.controller.ts

@@ -38,7 +38,7 @@ export class RdiPipelineController {
   })
   async getPipeline(
     @RequestRdiClientMetadata() rdiClientMetadata: RdiClientMetadata,
-  ): Promise<object> {
+  ): Promise<RdiPipeline> {
     return this.rdiPipelineService.getPipeline(rdiClientMetadata);
   }
 

redisinsight/api/src/modules/rdi/rdi-pipeline.service.ts

@@ -5,6 +5,7 @@ import { RdiDryRunJobDto, RdiTemplateResponseDto, RdiTestConnectionsResponseDto
 import { RdiDryRunJobResponseDto } from 'src/modules/rdi/dto/rdi.dry-run.job.response.dto';
 import { RdiPipelineAnalytics } from 'src/modules/rdi/rdi-pipeline.analytics';
 import { wrapHttpError } from 'src/common/utils';
+import { plainToClass } from 'class-transformer';
 
 @Injectable()
 export class RdiPipelineService {
@@ -22,7 +23,7 @@ export class RdiPipelineService {
     return await client.getSchema();
   }
 
-  async getPipeline(rdiClientMetadata: RdiClientMetadata): Promise<object> {
+  async getPipeline(rdiClientMetadata: RdiClientMetadata): Promise<RdiPipeline> {
     this.logger.log('Getting RDI pipeline');
 
     try {
@@ -33,7 +34,8 @@ export class RdiPipelineService {
       this.analytics.sendRdiPipelineFetched(rdiClientMetadata.id, response);
 
       this.logger.log('Succeed to get RDI pipeline');
-      return response;
+
+      return plainToClass(RdiPipeline, response);
     } catch (e) {
       this.logger.error('Failed to get RDI pipeline', e);