fix tests + avoid using fs-extra ensure dir due to folder permissions

Author: Artem

redisinsight/api/config/default.ts

@@ -1,8 +1,6 @@
 import { join } from 'path';
 
-const prevHomedir = join(__dirname, '..', '.redisinsight-v2.0-dev');
-
-const homedir = join(__dirname, '..', '.redisinsight-v2-dev');
+const homedir = join(__dirname, '..');
 
 const buildInfoFileName = 'build.json';
 const dataZipFileName = 'data.zip';
@@ -18,7 +16,7 @@ const defaultsDir = process.env.BUILD_TYPE === 'ELECTRON' && process['resourcesP
 export default {
   dir_path: {
     homedir,
-    prevHomedir,
+    prevHomedir: homedir,
     staticDir,
     defaultsDir,
     logs: join(homedir, 'logs'),

redisinsight/api/src/app.module.ts

@@ -1,4 +1,4 @@
-import * as fs from 'fs-extra';
+import * as fs from 'fs';
 import {
   MiddlewareConsumer, Module, NestModule, OnModuleInit,
 } from '@nestjs/common';
@@ -73,14 +73,18 @@ const PATH_CONFIG = config.get('dir_path');
   providers: [],
 })
 export class AppModule implements OnModuleInit, NestModule {
-  async onModuleInit() {
+  onModuleInit() {
     // creating required folders
     const foldersToCreate = [
       PATH_CONFIG.pluginsAssets,
       PATH_CONFIG.customPlugins,
     ];
 
-    await Promise.all(foldersToCreate.map(fs.ensureDir));
+    foldersToCreate.forEach((folder) => {
+      if (!fs.existsSync(folder)) {
+        fs.mkdirSync(folder, { recursive: true });
+      }
+    });
   }
 
   configure(consumer: MiddlewareConsumer) {

redisinsight/api/src/init-helper.ts

@@ -5,19 +5,32 @@ import { join } from 'path';
 const PATH_CONFIG = config.get('dir_path');
 const DB_CONFIG = config.get('db');
 
+/**
+ * Copy source if exists
+ * @param source
+ * @param destination
+ */
+const copySource = async (source, destination) => {
+  if (await fs.pathExists(source)) {
+    await fs.copy(source, destination).catch();
+  }
+};
+
+/**
+ * Migrate data from previous home folder defined in configs
+ */
 export const migrateHomeFolder = async () => {
   try {
-    if (!await fs.pathExists(DB_CONFIG.database) && await fs.pathExists(PATH_CONFIG.prevHomedir)) {
+    if (!(await fs.pathExists(DB_CONFIG.database)) && await fs.pathExists(PATH_CONFIG.prevHomedir)) {
       await fs.ensureDir(PATH_CONFIG.homedir);
 
       await Promise.all([
         'redisinsight.db',
         'plugins',
-        'plugins2',
-      ].map((target) => fs.copy(
+      ].map((target) => copySource(
         join(PATH_CONFIG.prevHomedir, target),
         join(PATH_CONFIG.homedir, target),
-      ).catch()));
+      )));
     }
   } catch (e) {
     // continue initialization even without migration

redisinsight/api/test/test-runs/docker.build.env

@@ -1,4 +1,3 @@
-APP_DATA_HOMEDIR=/root/.redisinsight-v2.0
 COV_FOLDER=./coverage
 ID=defaultid
 RTE=defaultrte

redisinsight/api/test/test-runs/local.build.env

@@ -1,4 +1,3 @@
-APP_DATA_HOMEDIR=/root/.redisinsight-2.0
 COV_FOLDER=./coverage
 ID=defaultid
 RTE=defaultrte