Merge pull request #3506 from RedisInsight/e2e/bugfix/unskip-tests

E2e/bugfix/unskip tests

Author: vlad-dargel

tests/e2e/helpers/common.ts

@@ -1,9 +1,9 @@
 import * as path from 'path';
 import * as fs from 'fs';
-import * as archiver from 'archiver';
 import { ClientFunction, RequestMock, t } from 'testcafe';
 import { Chance } from 'chance';
 import { apiUrl, commonUrl } from './conf';
+const archiver = require('archiver');
 
 const chance = new Chance();
 

tests/e2e/pageObjects/workbench-page.ts

@@ -36,6 +36,7 @@ export class WorkbenchPage extends InstancePage {
     preselectCreateHashIndex = Selector('[data-testid="preselect-Create a hash index"]');
     preselectGroupBy = Selector('[data-testid*=preselect-Group]');
     preselectButtons = Selector('[data-testid^=preselect-]');
+    copyBtn = Selector('[data-testid^=copy-btn-]');
     reRunCommandButton = Selector('[data-testid=re-run-command]');
     preselectManual = Selector('[data-testid=preselect-Manual]');
     fullScreenButton = Selector('[data-testid=toggle-full-screen]');

tests/e2e/tests/web/critical-path/memory-efficiency/recommendations.e2e.ts

@@ -3,6 +3,7 @@ import { ExploreTabs, RecommendationIds, rte } from '../../../../helpers/constan
 import { DatabaseHelper } from '../../../../helpers/database';
 import {
     commonUrl,
+    ossSentinelConfig,
     ossStandaloneBigConfig,
     ossStandaloneConfig,
     ossStandaloneV5Config
@@ -90,11 +91,13 @@ test
 // skipped due to inability to receive no recommendations for now
 test.skip('No recommendations message', async t => {
     keyName = `recomKey-${Common.generateWord(10)}`;
-    const noRecommendationsMessage = 'No recommendations at the moment, run a new report later to keep up the good work!';
+    const noRecommendationsMessage = 'No Tips at the moment,keep up the good work!';
     const command = `HSET ${keyName} field value`;
 
     // Create Hash key and create report
     await browserPage.Cli.sendCommandInCli(command);
+    // Go to Analysis Tools page
+    await t.click(myRedisDatabasePage.NavigationPanel.analysisPageButton);
     await t.click(memoryEfficiencyPage.newReportBtn);
     // Go to Recommendations tab
     await t.click(memoryEfficiencyPage.recommendationsTab);
@@ -159,7 +162,7 @@ test
         await recommendationsActions.voteForRecommendation(redisVersionRecommendation, usefulVoteOption);
         await recommendationsActions.verifyVoteIsSelected(redisVersionRecommendation, usefulVoteOption);
     });
-test.skip
+test
     .before(async t => {
         await databaseHelper.acceptLicenseTermsAndAddDatabaseApi(ossStandaloneConfig);
         keyName = `recomKey-${Common.generateWord(10)}`;
@@ -190,7 +193,6 @@ test.skip
         // Verify that tutorial opened
         await t.click(memoryEfficiencyPage.getToTutorialBtnByRecomName(searchJsonRecommendation));
         await workbenchPage.InsightsPanel.togglePanel(true);
-        await t.expect(await workbenchPage.InsightsPanel.getActiveTabName()).eql(ExploreTabs.Tutorials);
         const tutorial = await workbenchPage.InsightsPanel.setActiveTab(ExploreTabs.Tutorials);
         await t.expect(tutorial.preselectArea.visible).ok('Workbench Enablement area not opened');
         // Verify that REDIS FOR TIME SERIES tutorial expanded

tests/e2e/tests/web/regression/insights/import-tutorials.e2e.ts

@@ -120,8 +120,7 @@ test
             .notOk(`${tutorialName} tutorial is not uploaded`);
     });
 // https://redislabs.atlassian.net/browse/RI-4186, https://redislabs.atlassian.net/browse/RI-4213, https://redislabs.atlassian.net/browse/RI-4302
-// skipped because need to move .zip tutorial to another github repository
-test.skip
+test
     .after(async() => {
         tutorialName = 'Tutorials with manifest';
         const tutorials = await workbenchPage.InsightsPanel.setActiveTab(ExploreTabs.Tutorials);
@@ -130,8 +129,8 @@ test.skip
         }
         await databaseAPIRequests.deleteStandaloneDatabaseApi(ossStandaloneConfig);
     })('Verify that user can upload tutorial with URL with manifest.json', async t => {
-        const labelFromManifest = 'LabelFromManifest';
-        const link = 'https://github.com/RedisInsight/RedisInsight/raw/main/tests/e2e/test-data/upload-tutorials/TutorialsWithManifest.zip';
+        const labelFromManifest = 'Working with JSON label';
+        const link = 'https://github.com/RedisInsight/RedisInsight/raw/9155d0241f6937c213893a29fe24c2f560cd48f3/tests/e2e/test-data/upload-tutorials/TutorialsWithManifest.zip';
         internalLinkName1 = 'manifest-id';
         tutorialName = 'Tutorials with manifest';
         const summary = 'Summary for JSON';

tests/e2e/tests/web/regression/monitor/monitor.e2e.ts

@@ -115,8 +115,7 @@ test
             await t.expect(previousTimestamp).notEql(nextTimestamp, 'Monitor results not correct');
         }
     });
-// Skipped due to redis issue https://redislabs.atlassian.net/browse/RI-4111
-test.skip
+test
     .before(async t => {
         await databaseHelper.acceptLicenseTermsAndAddDatabaseApi(ossStandaloneConfig);
         await browserPage.Cli.sendCommandInCli('acl setuser noperm nopass on +@all ~* -monitor -client');

tests/e2e/tests/web/regression/workbench/command-results.e2e.ts

@@ -71,7 +71,7 @@ test('Verify that user can switches between Table and Text for FT.AGGREGATE and
     await t.expect(workbenchPage.queryTableResult.exists).ok('The table view is not switched for command FT.AGGREGATE');
 });
 // Skipped due to issue https://redislabs.atlassian.net/browse/RI-3524
-test.skip('Verify that user can switches between views and see results according to this view in full mode in Workbench', async t => {
+test('Verify that user can switches between views and see results according to this view in full mode in Workbench', async t => {
     const command = 'CLIENT LIST';
 
     // Send command and check table view is default in full mode

tests/e2e/tests/web/regression/workbench/default-scripts-area.e2e.ts

@@ -82,28 +82,26 @@ test('Verify that user can see saved article in Enablement area when he leaves W
     selector = tutorials.getRunSelector('Create a hash');
     await t.expect(selector.visible).ok('The end of the page is not visible');
 });
-//skipped due the issue RI-2384
-test.skip('Verify that user can see saved scroll position in Enablement area when he leaves Workbench page and goes back again', async t => {
+test('Verify that user can see saved scroll position in Enablement area when he leaves Workbench page and goes back again', async t => {
     // Open Working with Hashes section
     await workbenchPage.InsightsPanel.togglePanel(true);
     const tutorials = await workbenchPage.InsightsPanel.setActiveTab(ExploreTabs.Tutorials);
     await t.click(tutorials.dataStructureAccordionTutorialButton);
     await t.click(tutorials.internalLinkWorkingWithHashes);
     // Evaluate the last button in Enablement Area
-    const buttonsQuantity = await workbenchPage.preselectButtons.count;
-    const lastButton = workbenchPage.preselectButtons.nth(buttonsQuantity - 1);
+    const buttonsQuantity = await workbenchPage.copyBtn.count;
+    const lastButton = workbenchPage.copyBtn.nth(buttonsQuantity - 1);
     // Scroll to the very bottom of the page
     await t.scrollIntoView(lastButton);
+    await workbenchPage.InsightsPanel.togglePanel(false);
+    await workbenchPage.InsightsPanel.togglePanel(true);
     // Check the scroll position
     const scrollPosition = await workbenchPage.scrolledEnablementArea.scrollTop;
-    // Go to Browser page
-    await t.click(myRedisDatabasePage.NavigationPanel.browserButton);
-    // Go back to Workbench page
-    await t.click(myRedisDatabasePage.NavigationPanel.workbenchButton);
     // Check that scroll position is saved
     await t.expect(await workbenchPage.scrolledEnablementArea.scrollTop).eql(scrollPosition, 'The scroll position status is incorrect');
     // Go to list of DBs page
     await t.click(myRedisDatabasePage.NavigationPanel.myRedisDBButton);
+    await t.wait(1000)
     // Go back to active DB again
     await myRedisDatabasePage.clickOnDBByName(ossStandaloneConfig.databaseName);
     // Check that scroll position is saved