Skip to content

Commit ae373d8

Browse files
author
KIvanow
committed
RI-6336 - simplified approach for per db setting
1 parent 6a3f380 commit ae373d8

File tree

5 files changed

+8
-16
lines changed

5 files changed

+8
-16
lines changed

redisinsight/ui/src/pages/browser/components/key-list/KeyList.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,6 @@ const KeyList = forwardRef((props: Props, ref) => {
284284
dispatch(fetchKeysMetadata(
285285
itemsToFetch.map(({ name }) => name),
286286
commonFilterType,
287-
shownColumns,
288287
controller.current?.signal,
289288
(loadedItems) => onSuccessFetchedMetadata(startIndex, loadedItems),
290289
() => { rerender({}) }

redisinsight/ui/src/pages/browser/components/virtual-tree/VirtualTree.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ const VirtualTree = (props: Props) => {
7373

7474
const { theme } = useContext(ThemeContext)
7575
const [rerenderState, rerender] = useState({})
76-
const { shownColumns } = useSelector(appContextDbConfig)
7776
const controller = useRef<Nullable<AbortController>>(null)
7877
const elements = useRef<any>({})
7978
const nodes = useRef<TreeNode[]>([])
@@ -146,7 +145,6 @@ const VirtualTree = (props: Props) => {
146145
dispatch(fetchKeysMetadataTree(
147146
itemsInit,
148147
filter,
149-
shownColumns,
150148
controller.current?.signal,
151149
(loadedItems) =>
152150
onSuccessFetchedMetadata(loadedItems),

redisinsight/ui/src/pages/browser/modules/key-details/KeyDetails.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ const KeyDetails = (props: Props) => {
4444

4545
const { instanceId } = useParams<{ instanceId: string }>()
4646
const { viewType } = useSelector(keysSelector)
47-
const { shownColumns } = useSelector(appContextDbConfig)
4847
const { loading, error = '', data } = useSelector(selectedKeySelector)
4948
const isKeySelected = !isNull(useSelector(selectedKeyDataSelector))
5049
const { type: keyType } = useSelector(selectedKeyDataSelector) ?? { type: KeyTypes.String }
@@ -56,7 +55,6 @@ const KeyDetails = (props: Props) => {
5655

5756
dispatch(fetchKeyInfo(
5857
keyProp,
59-
shownColumns,
6058
undefined,
6159
(data) => {
6260
if (!data) return

redisinsight/ui/src/slices/browser/keys.ts

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { createSlice, PayloadAction } from '@reduxjs/toolkit'
22
import { cloneDeep, remove, get, isUndefined } from 'lodash'
33
import axios, { AxiosError, CancelTokenSource } from 'axios'
4+
import { useSelector } from 'react-redux'
45
import { apiService, localStorageService } from 'uiSrc/services'
56
import {
67
ApiEndpoints,
@@ -31,7 +32,7 @@ import { DEFAULT_SEARCH_MATCH, SCAN_COUNT_DEFAULT } from 'uiSrc/constants/api'
3132
import { getBasedOnViewTypeEvent, sendEventTelemetry, TelemetryEvent, getAdditionalAddedEventData, getMatchType } from 'uiSrc/telemetry'
3233
import successMessages from 'uiSrc/components/notifications/success-messages'
3334
import { IFetchKeyArgs, IKeyPropTypes } from 'uiSrc/constants/prop-types/keys'
34-
import { resetBrowserTree } from 'uiSrc/slices/app/context'
35+
import { appContextDbConfig, resetBrowserTree } from 'uiSrc/slices/app/context'
3536

3637
import { CreateListWithExpireDto, } from 'apiSrc/modules/browser/list/dto'
3738
import { SetStringWithExpireDto } from 'apiSrc/modules/browser/string/dto'
@@ -656,13 +657,11 @@ export function fetchMorePatternKeysAction(oldKeys: IKeyPropTypes[] = [], cursor
656657
// Asynchronous thunk action
657658
export function fetchKeyInfo(
658659
key: RedisResponseBuffer,
659-
shownColumns: BrowserColumns[] = [BrowserColumns.Size, BrowserColumns.TTL],
660660
resetData?: boolean,
661661
onSuccess?: (data: Nullable<IKeyPropTypes>) => void
662662
) {
663663
return async (dispatch: AppDispatch, stateInit: () => RootState) => {
664-
dispatch(defaultSelectedKeyAction())
665-
664+
const { shownColumns } = stateInit()?.app?.context?.dbConfig
666665
try {
667666
const state = stateInit()
668667
const { encoding } = state.app.info
@@ -729,11 +728,9 @@ export function fetchKeyInfo(
729728
}
730729

731730
// Asynchronous thunk action
732-
export function refreshKeyInfoAction(
733-
key: RedisResponseBuffer,
734-
shownColumns: BrowserColumns[] = [BrowserColumns.Size, BrowserColumns.TTL]
735-
) {
731+
export function refreshKeyInfoAction(key: RedisResponseBuffer) {
736732
return async (dispatch: AppDispatch, stateInit: () => RootState) => {
733+
const { shownColumns } = stateInit()?.app?.context?.dbConfig
737734
dispatch(refreshKeyInfo())
738735
try {
739736
const state = stateInit()
@@ -1040,12 +1037,12 @@ export function editKeyTTL(key: RedisResponseBuffer, ttl: number) {
10401037
export function fetchKeysMetadata(
10411038
keys: RedisString[],
10421039
filter: Nullable<KeyTypes>,
1043-
shownColumns: BrowserColumns[] = [BrowserColumns.Size, BrowserColumns.TTL],
10441040
signal?: AbortSignal,
10451041
onSuccessAction?: (data: GetKeyInfoResponse[]) => void,
10461042
onFailAction?: () => void
10471043
) {
10481044
return async (_dispatch: AppDispatch, stateInit: () => RootState) => {
1045+
const { shownColumns } = stateInit()?.app?.context?.dbConfig
10491046
try {
10501047
const state = stateInit()
10511048
const { data } = await apiService.post<GetKeyInfoResponse[]>(
@@ -1077,12 +1074,12 @@ export function fetchKeysMetadata(
10771074
export function fetchKeysMetadataTree(
10781075
keys: RedisString[],
10791076
filter: Nullable<KeyTypes>,
1080-
shownColumns: BrowserColumns[] = [BrowserColumns.Size, BrowserColumns.TTL],
10811077
signal?: AbortSignal,
10821078
onSuccessAction?: (data: GetKeyInfoResponse[]) => void,
10831079
onFailAction?: () => void
10841080
) {
10851081
return async (_dispatch: AppDispatch, stateInit: () => RootState) => {
1082+
const { shownColumns } = stateInit()?.app?.context?.dbConfig
10861083
try {
10871084
const state = stateInit()
10881085
const { data } = await apiService.post<GetKeyInfoResponse[]>(

redisinsight/ui/src/slices/browser/zset.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ const zsetSlice = createSlice({
5555
state.data.members = payload
5656
},
5757
// load ZSet members
58-
loadZSetMembers: (state, { payload: [sortOrder, resetData = true] }:PayloadAction<[SortOrder, Maybe<boolean>]>) => {
58+
loadZSetMembers: (state, { payload: [sortOrder, resetData = true] }: PayloadAction<[SortOrder, Maybe<boolean>]>) => {
5959
state.loading = true
6060
state.searching = false
6161
state.error = ''

0 commit comments

Comments
 (0)