Skip to content

Commit b39031a

Browse files
authored
Merge pull request #2258 from RedisInsight/e2e/bugfix/fixes-for-web-tests
fixes for failed e2e
2 parents 13d903a + c1e02f1 commit b39031a

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

electron-builder.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"type": "distribution",
3030
"hardenedRuntime": true,
3131
"darkModeSupport": true,
32-
"bundleVersion": "30",
32+
"bundleVersion": "40",
3333
"icon": "resources/icon.icns",
3434
"artifactName": "${productName}-${os}-${arch}.${ext}",
3535
"entitlements": "resources/entitlements.mac.plist",

tests/e2e/pageObjects/browser-page.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ export class BrowserPage extends InstancePage {
135135
relativeTimeOption = Selector('#idle');
136136
timestampOption = Selector('#time');
137137
formatSwitcher = Selector('[data-testid=select-format-key-value]', { timeout: 2000 });
138-
formatSwitcherIcon = Selector('img[data-testid^=key-value-formatter-option-selected]');
138+
formatSwitcherIcon = Selector('[data-testid^=key-value-formatter-option-selected]');
139139
selectIndexDdn = Selector('[data-testid=select-index-placeholder],[data-testid=select-search-mode]', { timeout: 1000 });
140140
createIndexBtn = Selector('[data-testid=create-index-btn]');
141141
cancelIndexCreationBtn = Selector('[data-testid=create-index-cancel-btn]');

tests/e2e/tests/regression/browser/format-switcher.e2e.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,17 +74,17 @@ test('Verify that user can see switcher icon for narrow screen and tooltip by ho
7474
for (let i = 0; i < keysWithoutSwitcher.length; i++) {
7575
await browserPage.openKeyDetailsByKeyName(keysWithoutSwitcher[i].keyName);
7676
// Verify that user don`t see format switcher for JSON, GRAPH, TS keys
77-
await t.expect(browserPage.formatSwitcher.visible).notOk(`Formatter is displayed for ${keysWithoutSwitcher[i].textType} type`, { timeout: 1000 });
77+
await t.expect(browserPage.formatSwitcher.exists).notOk(`Formatter is displayed for ${keysWithoutSwitcher[i].textType} type`, { timeout: 1000 });
7878
}
7979

80-
await browserPage.openKeyDetails(keysData[0].keyName);
80+
await browserPage.openKeyDetailsByKeyName(keysData[0].keyName);
8181
await browserPage.selectFormatter('JSON');
8282
// Verify icon is not displayed with high screen resolution
83-
await t.expect(browserPage.formatSwitcherIcon.visible).notOk('Format switcher Icon is displayed with high screen resolution');
83+
await t.expect(browserPage.formatSwitcherIcon.exists).notOk('Format switcher Icon is displayed with high screen resolution');
8484
// Minimize the window to check icon
8585
await t.resizeWindow(1500, 900);
8686
// Verify icon is displayed with low screen resolution
87-
await t.expect(browserPage.formatSwitcherIcon.visible).ok('Format switcher Icon is not displayed with low screen resolution');
87+
await t.expect(browserPage.formatSwitcherIcon.exists).ok('Format switcher Icon is not displayed with low screen resolution');
8888
await t.hover(browserPage.formatSwitcher);
8989
// Verify tooltip is displayed on hover with low screen resolution
9090
await t.expect(browserPage.tooltip.textContent).contains('JSON', 'Selected formatter is not displayed in tooltip');

tests/e2e/tests/regression/workbench/command-results.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ test
129129
const command = 'CLIENT LIST';
130130
// Send command in workbench to view client list
131131
await workbenchPage.sendCommandInWorkbench(command);
132-
await t.expect(workbenchPage.typeSelectedClientsList.visible).ok('client list view button is not visible');
132+
await t.expect(workbenchPage.typeSelectedClientsList.exists).ok('client list view button is not visible');
133133
await workBenchActions.verifyClientListColumnsAreVisible(['id', 'addr', 'name', 'user']);
134134
// verify table view row count match with text view after client list command
135135
await workBenchActions.verifyClientListTableViewRowCount();

tests/e2e/tests/regression/workbench/redis-stack-commands.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ test('Verify that user can switches between Chart and Text for TimeSeries comman
6868
await t.click(workbenchPage.showSalesPerRegiomButton);
6969
await t.click(workbenchPage.submitCommandButton);
7070
// Check result is in chart view
71-
await t.expect(workbenchPage.chartViewTypeOptionSelected.visible).ok('The chart view option is not selected by default');
71+
await t.expect(workbenchPage.chartViewTypeOptionSelected.exists).ok('The chart view option is not selected by default');
7272
// Switch to Text view and check result
7373
await workbenchPage.selectViewTypeText();
7474
await t.expect(workbenchPage.queryCardContainer.nth(0).find(workbenchPage.cssQueryTextResult).exists).ok('The result in text view is not displayed');

0 commit comments

Comments
 (0)