Skip to content

Commit b539a1e

Browse files
#RI-5750 - update with latest rdi
1 parent dc63728 commit b539a1e

File tree

4 files changed

+8
-18
lines changed

4 files changed

+8
-18
lines changed

redisinsight/api/src/modules/rdi/client/api.rdi.client.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import axios, { AxiosInstance } from 'axios';
22
import { plainToClass } from 'class-transformer';
33
import { decode } from 'jsonwebtoken';
4-
import { Request } from 'express';
54

65
import { RdiClient } from 'src/modules/rdi/client/rdi.client';
76
import {
@@ -112,21 +111,14 @@ export class ApiRdiClient extends RdiClient {
112111
}
113112
}
114113

115-
async testConnections(config: string, req: Request): Promise<RdiTestConnectionsResponseDto> {
114+
async testConnections(config: object): Promise<RdiTestConnectionsResponseDto> {
116115
try {
117-
const abortController = new AbortController();
118-
req.socket.on('close', () => {
119-
abortController.abort();
120-
});
121116
const response = await this.client.post(
122117
RdiUrl.TestConnections,
123118
config,
124-
{ signal: abortController.signal },
125119
);
126120

127-
const actionId = response.data.action_id;
128-
129-
return this.pollActionStatus(actionId, abortController.signal);
121+
return response.data;
130122
} catch (e) {
131123
throw wrapRdiPipelineError(e);
132124
}

redisinsight/api/src/modules/rdi/client/rdi.client.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { Request } from 'express';
21
import {
32
Rdi,
43
RdiClientMetadata, RdiPipeline, RdiStatisticsResult,
@@ -38,7 +37,7 @@ export abstract class RdiClient {
3837

3938
abstract dryRunJob(data: RdiDryRunJobDto): Promise<RdiDryRunJobResponseDto>;
4039

41-
abstract testConnections(config: string, req: Request): Promise<RdiTestConnectionsResponseDto>;
40+
abstract testConnections(config: object): Promise<RdiTestConnectionsResponseDto>;
4241

4342
abstract getStatistics(sections?: string): Promise<RdiStatisticsResult>;
4443

redisinsight/api/src/modules/rdi/rdi-pipeline.controller.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,10 @@ export class RdiPipelineController {
7373
responses: [{ status: 200, type: RdiTestConnectionsResponseDto }],
7474
})
7575
async testConnections(
76-
@Req() req: Request,
77-
@RequestRdiClientMetadata() rdiClientMetadata: RdiClientMetadata,
78-
@Body() config: string,
76+
@RequestRdiClientMetadata() rdiClientMetadata: RdiClientMetadata,
77+
@Body() config: object,
7978
): Promise<RdiTestConnectionsResponseDto> {
80-
return this.rdiPipelineService.testConnections(rdiClientMetadata, config, req);
79+
return this.rdiPipelineService.testConnections(rdiClientMetadata, config);
8180
}
8281

8382
@Get('/strategies')

redisinsight/api/src/modules/rdi/rdi-pipeline.service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,12 @@ export class RdiPipelineService {
7070
}
7171
}
7272

73-
async testConnections(rdiClientMetadata: RdiClientMetadata, config: string, req: Request): Promise<RdiTestConnectionsResponseDto> {
73+
async testConnections(rdiClientMetadata: RdiClientMetadata, config: object): Promise<RdiTestConnectionsResponseDto> {
7474
this.logger.log('Trying to test connections');
7575

7676
const client = await this.rdiClientProvider.getOrCreate(rdiClientMetadata);
7777

78-
return await client.testConnections(config, req);
78+
return await client.testConnections(config);
7979
}
8080

8181
async getStrategies(rdiClientMetadata: RdiClientMetadata): Promise<object> {

0 commit comments

Comments
 (0)