#3977 - demo comments resolve

Author: AmirAllayarovSofteq

redisinsight/api/src/modules/database-analysis/models/recommendation.ts

@@ -19,7 +19,7 @@ export class Recommendation {
 
   @ApiPropertyOptional({
     description: 'User vote',
-    example: 'Amazing',
+    example: 'useful',
   })
   @Expose()
   vote?: string;

redisinsight/api/src/modules/database-analysis/providers/database-analysis.provider.spec.ts

@@ -152,12 +152,12 @@ const mockDatabaseAnalysis = {
 
 const mockDatabaseAnalysisWithVote = {
   ...mockDatabaseAnalysis,
-  recommendations: [{ name: 'luaScript', vote: 'amazing' }],
+  recommendations: [{ name: 'luaScript', vote: 'useful' }],
 } as DatabaseAnalysis;
 
 const mockRecommendationVoteDto: RecommendationVoteDto = {
   name: 'luaScript',
-  vote: 'amazing',
+  vote: 'useful',
 };
 
 describe('DatabaseAnalysisProvider', () => {

redisinsight/api/test/api/database-analysis/PATCH-databases-id-analysis.test.ts

@@ -53,7 +53,7 @@ describe('PATCH /databases/:instanceId/analysis/:id', () => {
           name: 'Should add vote for RTS recommendation',
           data: {
             name: 'luaScript',
-            vote: 'amazing',
+            vote: 'useful',
           },
           statusCode: 200,
           responseSchema,

redisinsight/api/test/helpers/constants.ts

@@ -516,7 +516,7 @@ export const constants = {
 
   TEST_LUA_SCRIPT_VOTE_RECOMMENDATION: {
     name: RECOMMENDATION_NAMES.LUA_SCRIPT,
-    vote: 'amazing',
+    vote: 'useful',
   },
   // etc...
 }

redisinsight/ui/src/constants/recommendations.ts

@@ -1,5 +1,5 @@
 export enum Vote {
-  DoubleLike = 'amazing',
+  DoubleLike = 'very useful',
   Like = 'useful',
   Dislike = 'not useful'
 }

redisinsight/ui/src/pages/databaseAnalysis/components/recommendation-voting/RecommendationVoting.spec.tsx

@@ -39,9 +39,9 @@ describe('RecommendationVoting', () => {
     expect(render(<RecommendationVoting {...instance(mockedProps)} />)).toBeTruthy()
   })
 
-  it('should call "setRecommendationVote" action be called after click "amazing-vote-btn"', () => {
+  it('should call "setRecommendationVote" action be called after click "very-useful-vote-btn"', () => {
     render(<RecommendationVoting {...instance(mockedProps)} />)
-    fireEvent.click(screen.getByTestId('amazing-vote-btn'))
+    fireEvent.click(screen.getByTestId('very-useful-vote-btn'))
 
     const expectedActions = [setRecommendationVote()]
     expect(store.getActions()).toEqual(expectedActions)
@@ -75,9 +75,9 @@ describe('RecommendationVoting', () => {
   })
 
   it('should render component where all buttons are disabled"', async () => {
-    render(<RecommendationVoting {...instance(mockedProps)} vote="amazing" />)
+    render(<RecommendationVoting {...instance(mockedProps)} vote="useful" />)
 
-    expect(screen.getByTestId('amazing-vote-btn')).toBeDisabled()
+    expect(screen.getByTestId('very-useful-vote-btn')).toBeDisabled()
     expect(screen.getByTestId('useful-vote-btn')).toBeDisabled()
     expect(screen.getByTestId('not-useful-vote-btn')).toBeDisabled()
   })

redisinsight/ui/src/pages/databaseAnalysis/components/recommendation-voting/RecommendationVoting.tsx

@@ -1,5 +1,5 @@
 import React, { useState } from 'react'
-import { useDispatch } from 'react-redux'
+import { useDispatch, useSelector } from 'react-redux'
 import cx from 'classnames'
 import {
   EuiButton,
@@ -11,6 +11,7 @@ import {
   EuiIcon,
   EuiLink,
 } from '@elastic/eui'
+import { userSettingsConfigSelector } from 'uiSrc/slices/user/user-settings'
 import { putRecommendationVote } from 'uiSrc/slices/analytics/dbAnalysis'
 import { sendEventTelemetry, TelemetryEvent } from 'uiSrc/telemetry'
 import { EXTERNAL_LINKS } from 'uiSrc/constants/links'
@@ -25,6 +26,7 @@ import styles from './styles.module.scss'
 export interface Props { vote?: Vote, name: string }
 
 const RecommendationVoting = ({ vote, name }: Props) => {
+  const config = useSelector(userSettingsConfigSelector)
   const [isPopoverOpen, setIsPopoverOpen] = useState(false)
   const dispatch = useDispatch()
 
@@ -46,29 +48,33 @@ const RecommendationVoting = ({ vote, name }: Props) => {
     dispatch(putRecommendationVote(name, vote, onSuccessVoted))
   }
 
+  const getTooltipContent = (content: string) => (config?.agreements?.analytics
+    ? content
+    : 'Enable Analytics on the Settings page to vote for a recommendation')
+
   return (
     <EuiFlexGroup alignItems="center" className={styles.votingContainer}>
       <EuiText size="m">Rate Recommendation</EuiText>
       <div className={styles.vote}>
         <EuiToolTip
-          content="Amazing"
+          content={getTooltipContent('Very Useful')}
           position="bottom"
         >
           <EuiButtonIcon
-            disabled={!!vote}
+            disabled={!!vote || !config?.agreements?.analytics}
             iconType={DoubleLikeIcon}
             className={cx(styles.voteBtn, { [styles.selected]: vote === Vote.DoubleLike })}
-            aria-label="vote amazing"
-            data-testid="amazing-vote-btn"
+            aria-label="vote very useful"
+            data-testid="very-useful-vote-btn"
             onClick={() => handleClick(name, Vote.DoubleLike)}
           />
         </EuiToolTip>
         <EuiToolTip
-          content="Useful"
+          content={getTooltipContent('Useful')}
           position="bottom"
         >
           <EuiButtonIcon
-            disabled={!!vote}
+            disabled={!!vote || !config?.agreements?.analytics}
             iconType={LikeIcon}
             className={cx(styles.voteBtn, { [styles.selected]: vote === Vote.Like })}
             aria-label="vote useful"
@@ -77,7 +83,7 @@ const RecommendationVoting = ({ vote, name }: Props) => {
           />
         </EuiToolTip>
         <EuiToolTip
-          content="Not Useful"
+          content={getTooltipContent('Not Useful')}
           position="bottom"
         >
           <EuiPopover
@@ -89,7 +95,7 @@ const RecommendationVoting = ({ vote, name }: Props) => {
             panelClassName={cx('euiToolTip', 'popoverLikeTooltip', styles.popover)}
             button={(
               <EuiButtonIcon
-                disabled={!!vote}
+                disabled={!!vote || !config?.agreements?.analytics}
                 iconType={DislikeIcon}
                 className={cx(styles.voteBtn, { [styles.selected]: vote === Vote.Dislike })}
                 aria-label="vote not useful"