remove auth command logic from recommendation

Author: ArtemHoruzhenko

redisinsight/api/src/modules/recommendation/providers/recommendation.provider.spec.ts

@@ -515,17 +515,6 @@ describe('RecommendationProvider', () => {
           .determineSetPasswordRecommendation(client);
         expect(setPasswordRecommendation).toEqual(null);
       });
-
-    it('should return setPassword recommendation when acl command executed with no password error',
-      async () => {
-        when(client.sendCommand)
-          .calledWith(jasmine.arrayContaining(['auth']))
-          .mockRejectedValue(mockRedisNoPasswordError);
-
-        const setPasswordRecommendation = await service
-          .determineSetPasswordRecommendation(client);
-        expect(setPasswordRecommendation).toEqual({ name: RECOMMENDATION_NAMES.SET_PASSWORD });
-      });
   });
 
   describe('determineRedisVersionRecommendation', () => {

redisinsight/api/src/modules/recommendation/providers/recommendation.provider.ts

@@ -367,10 +367,6 @@ export class RecommendationProvider {
   async determineSetPasswordRecommendation(
     redisClient: RedisClient,
   ): Promise<Recommendation> {
-    if (await this.checkAuth(redisClient)) {
-      return { name: RECOMMENDATION_NAMES.SET_PASSWORD };
-    }
-
     try {
       const users = await redisClient.sendCommand(
         ['acl', 'list'],
@@ -438,17 +434,6 @@ export class RecommendationProvider {
     }
   }
 
-  private async checkAuth(redisClient: RedisClient): Promise<boolean> {
-    try {
-      await redisClient.sendCommand(['auth', 'pass']);
-    } catch (err) {
-      if (err.message.includes('Client sent AUTH, but no password is set')) {
-        return true;
-      }
-    }
-    return false;
-  }
-
   private async determineSearchIndexesForCluster(keys: Key[], client: RedisClient): Promise<RedisString> {
     let processedKeysNumber = 0;
     let keyName;