Skip to content

Commit b7c6dc5

Browse files
Merge pull request #4224 from RedisInsight/e2e/feature/RI-6386-fix-e2e-cluster-ssh-config
RI-6386 fix e2e oss cluster ssh config and tests
2 parents 1d58f1f + e45209f commit b7c6dc5

File tree

3 files changed

+13
-11
lines changed

3 files changed

+13
-11
lines changed

tests/e2e/helpers/conf.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -142,11 +142,11 @@ export const ossStandaloneForSSHConfig = {
142142
};
143143

144144
export const ossClusterForSSHConfig = {
145-
host: process.env.OSS_STANDALONE_SSH_HOST || '172.33.100.211',
146-
port: process.env.OSS_STANDALONE_SSH_PORT || '6379',
147-
databaseName: `${process.env.OSS_STANDALONE_SSH_DATABASE_NAME || 'oss-cluster-for-ssh'}-${uniqueId}`,
148-
databaseUsername: process.env.OSS_STANDALONE_SSH_USERNAME,
149-
databasePassword: process.env.OSS_STANDALONE_SSH_PASSWORD
145+
host: process.env.OSS_CLUSTER_SSH_HOST || '172.31.100.211',
146+
port: process.env.OSS_CLUSTER_SSH_PORT || '6379',
147+
databaseName: `${process.env.OSS_CLUSTER_SSH_DATABASE_NAME || 'oss-cluster-for-ssh'}-${uniqueId}`,
148+
databaseUsername: process.env.OSS_CLUSTER_SSH_USERNAME,
149+
databasePassword: process.env.OSS_CLUSTER_SSH_PASSWORD
150150
};
151151

152152
export const ossStandaloneTlsConfig = {

tests/e2e/tests/electron/critical-path/database/add-ssh-db.e2e.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,17 @@ const sshDbClusterPass = {
3838
};
3939

4040
fixture `Adding database with SSH`
41-
.meta({ type: 'critical_path', rte: rte.standalone })
41+
.meta({ type: 'critical_path'})
4242
.page(commonUrl)
4343
.beforeEach(async() => {
4444
await databaseHelper.acceptLicenseTerms();
4545
})
4646
.after(async() => {
4747
// Delete databases
48-
await databaseAPIRequests.deleteStandaloneDatabasesByNamesApi([sshDbPass.databaseName, sshDbPrivateKey.databaseName, sshDbPasscode.databaseName, newClonedDatabaseAlias]);
48+
await databaseAPIRequests.deleteStandaloneDatabasesByNamesApi([sshDbPass.databaseName, sshDbPrivateKey.databaseName, sshDbPasscode.databaseName, newClonedDatabaseAlias, sshDbClusterPass.databaseName]);
4949
});
50-
test('Adding database with SSH', async t => {
50+
test
51+
.meta({ rte: rte.standalone })('Adding database with SSH', async t => {
5152
const tooltipText = [
5253
'Enter a value for required fields (3):',
5354
'SSH Host',
@@ -122,14 +123,15 @@ test('Adding database with SSH', async t => {
122123
await myRedisDatabasePage.clickOnDBByName(sshDbPasscode.databaseName);
123124
await Common.checkURLContainsText('browser');
124125
});
125-
test('Verify that OSS Cluster database with SSH can be added and work correctly', async t => {
126+
test
127+
.meta({ rte: rte.ossCluster })('Verify that OSS Cluster database with SSH can be added and work correctly', async t => {
126128
const sshWithPass = {
127129
...sshParams,
128130
sshPassword: 'pass'
129131
};
130132
// Verify that user can add SSH tunnel with Password for OSS Cluster database
131133
await myRedisDatabasePage.AddRedisDatabaseDialog.addStandaloneSSHDatabase(sshDbClusterPass, sshWithPass);
132-
await myRedisDatabasePage.clickOnDBByName(sshDbPass.databaseName);
134+
await myRedisDatabasePage.clickOnDBByName(sshDbClusterPass.databaseName);
133135

134136
//verify that db is added and profiler works
135137
await t.click(browserPage.Profiler.expandMonitor);

tests/e2e/tests/web/critical-path/database/connecting-to-the-db.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ test
192192
};
193193
// Verify that user can add SSH tunnel with Password for OSS Cluster database
194194
await myRedisDatabasePage.AddRedisDatabaseDialog.addStandaloneSSHDatabase(sshDbClusterPass, sshWithPass);
195-
await myRedisDatabasePage.clickOnDBByName(sshDbPass.databaseName);
195+
await myRedisDatabasePage.clickOnDBByName(sshDbClusterPass.databaseName);
196196
await Common.checkURLContainsText('browser');
197197
});
198198
test

0 commit comments

Comments
 (0)