Skip to content

Commit ba6a660

Browse files
authored
Merge pull request #2016 from RedisInsight/feature/update-bundle-version
Feature/update bundle version
2 parents ab65041 + 571dcb3 commit ba6a660

File tree

7 files changed

+17
-14
lines changed

7 files changed

+17
-14
lines changed

electron-builder.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"type": "distribution",
3434
"hardenedRuntime": true,
3535
"darkModeSupport": true,
36-
"bundleVersion": "3",
36+
"bundleVersion": "4",
3737
"icon": "resources/icon.icns",
3838
"artifactName": "${productName}-${os}-${arch}.${ext}",
3939
"entitlements": "resources/entitlements.mac.plist",

redisinsight/api/src/modules/database-import/database-import.service.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,10 +161,12 @@ describe('DatabaseImportService', () => {
161161
it('should create standalone database', async () => {
162162
await service['createDatabase']({
163163
...mockDatabase,
164+
provider: 'RE_CLOUD',
164165
}, 0);
165166

166167
expect(databaseRepository.create).toHaveBeenCalledWith({
167168
...pick(mockDatabase, ['host', 'port', 'name', 'connectionType', 'timeout']),
169+
provider: 'RE_CLOUD',
168170
new: true,
169171
});
170172
});

redisinsight/api/src/modules/database-import/database-import.service.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ export class DatabaseImportService {
3737
['host', ['host']],
3838
['port', ['port']],
3939
['db', ['db']],
40+
['provider', ['provider']],
4041
['isCluster', ['cluster']],
4142
['type', ['type']],
4243
['connectionType', ['connectionType']],

redisinsight/api/src/modules/database-import/dto/import.database.dto.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import { UseClientCertificateDto } from 'src/modules/certificate/dto/use.client-
1414
export class ImportDatabaseDto extends PickType(Database, [
1515
'host', 'port', 'name', 'db', 'username', 'password',
1616
'connectionType', 'tls', 'verifyServerCert', 'sentinelMaster', 'nodes',
17-
'new', 'ssh', 'sshOptions',
17+
'new', 'ssh', 'sshOptions', 'provider',
1818
] as const) {
1919
@Expose()
2020
@IsNotEmpty()

tests/e2e/tests/critical-path/database/modules.e2e.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,12 @@ test
3232
await t.expect(myRedisDatabasePage.moduleColumn.exists).ok('Module column not found');
3333
// Verify that user can see the following sorting order: Search, JSON, Graph, TimeSeries, Bloom, Gears, AI for modules
3434
const databaseLine = myRedisDatabasePage.dbNameList.withExactText(ossStandaloneRedisearch.databaseName).parent('tr');
35+
await t.expect(databaseLine.visible).ok('Database not found in db list');
3536
const moduleIcons = databaseLine.find('[data-testid^=Redi]');
36-
const numberOfIcons = await moduleIcons.count;
37-
for (let i = 0; i < numberOfIcons; i++) {
37+
const numberOfIcons = moduleIcons.count;
38+
for (let i = 0; i < await numberOfIcons; i++) {
3839
const moduleName = moduleIcons.nth(i).getAttribute('data-testid');
39-
await t.expect(await moduleName).eql(await moduleList[i].getAttribute('data-testid'), 'Correct icon not found');
40+
await t.expect(moduleName).eql(await moduleList[i].getAttribute('data-testid'), `${moduleName} icon not found`);
4041
}
4142
//Minimize the window to check quantifier
4243
await t.resizeWindow(1000, 700);

tests/e2e/tests/regression/workbench/import-tutorials.e2e.ts

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ https://redislabs.atlassian.net/browse/RI-4302, https://redislabs.atlassian.net/
3333
*/
3434
test('Verify that user can upload tutorial with local zip file without manifest.json', async t => {
3535
// Verify that user can upload custom tutorials on docker version
36-
const imageExternalPath = 'RedisInsight screen external';
37-
// const imageRelativePath = 'RedisInsight screen relative';
3836
folder1 = 'folder-1';
3937
folder2 = 'folder-2';
4038
internalLinkName1 = 'probably-1';
@@ -64,14 +62,15 @@ test('Verify that user can upload tutorial with local zip file without manifest.
6462
await t.click((await workbenchPage.getInternalLinkWithManifest(internalLinkName1)));
6563
await t.expect(workbenchPage.scrolledEnablementArea.visible).ok('enablement area is not visible after clicked');
6664

65+
// Error when github upload .zip with relative path in .md
66+
// const imageExternalPath = 'RedisInsight screen external';
67+
// const imageRelativePath = 'RedisInsight screen relative';
6768
// Verify that user can see image in custom tutorials by providing absolute external path in md file
68-
const imageExternal = await workbenchPage.getTutorialImageByAlt(imageExternalPath);
69-
await workbenchPage.waitUntilImageRendered(imageExternal);
70-
const imageExternalHeight = await imageExternal.getStyleProperty('height');
71-
await t.expect(parseInt(imageExternalHeight.replace(/[^\d]/g, ''))).gte(150);
72-
69+
// const imageExternal = await workbenchPage.getTutorialImageByAlt(imageExternalPath);
70+
// await workbenchPage.waitUntilImageRendered(imageExternal);
71+
// const imageExternalHeight = await imageExternal.getStyleProperty('height');
72+
// await t.expect(parseInt(imageExternalHeight.replace(/[^\d]/g, ''))).gte(150);
7373
// Verify that user can see image in custom tutorials by providing relative path in md file
74-
// Error when github upload .zip with relative path in .md
7574
// const imageRelative = await workbenchPage.getTutorialImageByAlt(imageRelativePath);
7675
// await workbenchPage.waitUntilImageRendered(imageRelative);
7776
// const imageRelativeHeight = await imageRelative.getStyleProperty('height');

tests/e2e/wait-for-it.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ wait_for()
4444
echoerr "$WAITFORIT_cmdname: $WAITFORIT_HOST:$WAITFORIT_PORT is available after $((WAITFORIT_end_ts - WAITFORIT_start_ts)) seconds"
4545
break
4646
fi
47-
sleep 1
47+
sleep 30
4848
done
4949
return $WAITFORIT_result
5050
}

0 commit comments

Comments
 (0)