Skip to content

Commit bd09d61

Browse files
committed
#RI-4828 - fix pr comments
1 parent 8265f1e commit bd09d61

File tree

7 files changed

+14
-13
lines changed

7 files changed

+14
-13
lines changed

jest.config.cjs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ module.exports = {
3939
'json',
4040
],
4141
testEnvironment: 'jest-environment-jsdom',
42-
// type: 'module',
4342
transformIgnorePatterns: [
4443
'node_modules/(?!(monaco-editor|react-monaco-editor)/)',
4544
],
@@ -61,8 +60,5 @@ module.exports = {
6160
functions: 72,
6261
lines: 80,
6362
},
64-
// './redisinsight/ui/src/slices/**/*.ts': {
65-
// statements: 90,
66-
// },
6763
},
6864
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"start:web": "cross-env NODE_ENV=development TS_NODE_TRANSPILE_ONLY=true webpack serve --config ./configs/webpack.config.web.dev.ts",
4242
"start:web:public": "cross-env PUBLIC_DEV=true NODE_ENV=development TS_NODE_TRANSPILE_ONLY=true webpack serve --config ./configs/webpack.config.web.dev.ts",
4343
"test": "jest ./redisinsight/ui -w 1",
44-
"test:watch": "jest ./redisinsight/ui/src/slices/tests/app/context.spec.ts --watch -w 1",
44+
"test:watch": "jest ./redisinsight/ui --watch -w 1",
4545
"test:cov": "jest ./redisinsight/ui --silent --coverage --no-cache --forceExit -w 3",
4646
"test:cov:unit": "jest ./redisinsight/ui --group=-component --coverage -w 1",
4747
"test:cov:component": "jest ./redisinsight/ui --group=component --coverage -w 1",

redisinsight/ui/src/pages/browser/components/filter-key-type/FilterKeyType.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,9 @@ const FilterKeyType = () => {
7575
setTypeSelected(value)
7676
setIsSelectOpen(false)
7777
dispatch(setFilter(value === ALL_KEY_TYPES_VALUE ? null : value))
78-
viewType === KeyViewType.Tree && dispatch(resetBrowserTree())
78+
if (viewType === KeyViewType.Tree) {
79+
dispatch(resetBrowserTree())
80+
}
7981
dispatch(
8082
fetchKeys(
8183
{

redisinsight/ui/src/pages/browser/components/key-tree/KeyTreeSettings/KeyTreeSettings.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ const KeyTreeSettings = ({ loading }: Props) => {
3838
const dispatch = useDispatch()
3939

4040
useEffect(() => {
41+
setSorting(treeViewSort)
4142
}, [treeViewSort])
4243

4344
useEffect(() => {

redisinsight/ui/src/pages/browser/components/no-keys-message/NoKeysMessage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export interface Props {
2121
onBulkActionsPanel: (value: boolean) => void
2222
}
2323

24-
const NoKeysMessage = (props:Props) => {
24+
const NoKeysMessage = (props: Props) => {
2525
const {
2626
total,
2727
scanned,

redisinsight/ui/src/pages/browser/components/search-key-list/SearchKeyList.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,9 @@ const SearchKeyList = () => {
6767

6868
dispatch(setSearchMatch(match, searchMode))
6969

70-
viewType === KeyViewType.Tree && dispatch(resetBrowserTree())
70+
if (viewType === KeyViewType.Tree) {
71+
dispatch(resetBrowserTree())
72+
}
7173

7274
dispatch(fetchKeys(
7375
{

redisinsight/ui/src/pages/browser/components/virtual-tree/VirtualTree.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export interface Props {
4444
}
4545

4646
interface OpenedNodes {
47-
[key: string]: boolean;
47+
[key: string]: boolean
4848
}
4949

5050
export const KEYS = 'keys'
@@ -81,7 +81,7 @@ const VirtualTree = (props: Props) => {
8181
useEffect(() =>
8282
() => {
8383
nodes.current = []
84-
elements.current = []
84+
elements.current = {}
8585
}, [])
8686

8787
// receive result from the "runWebworker"
@@ -90,7 +90,7 @@ const VirtualTree = (props: Props) => {
9090
return
9191
}
9292

93-
elements.current = []
93+
elements.current = {}
9494
nodes.current = result
9595
rerender({})
9696
setConstructingTree?.(false)
@@ -99,7 +99,7 @@ const VirtualTree = (props: Props) => {
9999
useEffect(() => {
100100
if (!items?.length) {
101101
nodes.current = []
102-
elements.current = []
102+
elements.current = {}
103103
rerender({})
104104
runWebworker?.({ items: [], delimiter, sorting })
105105
return
@@ -161,7 +161,7 @@ const VirtualTree = (props: Props) => {
161161

162162
getMetadata(entries)
163163

164-
elements.current = []
164+
elements.current = {}
165165
}, 100)
166166

167167
const getMetadataNode = useCallback((nameBuffer: any, path: string) => {

0 commit comments

Comments
 (0)