Skip to content

Commit bec7de2

Browse files
fix for regression tests#2
1 parent 9b2bff3 commit bec7de2

File tree

4 files changed

+9
-2
lines changed

4 files changed

+9
-2
lines changed

tests/e2e/pageObjects/dialogs/add-redis-database-dialog.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ export class AddRedisDatabaseDialog {
7272
aiChatMessage = Selector('[data-testid=ai-chat-message-btn]');
7373
aiCloseMessage = Selector('[aria-label="Closes this modal window"]');
7474

75+
getDeleteCertificate = (certificate: TlsCertificates) => Selector(`[data-testid^=delete-${certificate}-cert]`);
76+
7577
/**
7678
* Adding a new redis database
7779
* @param parameters the parameters of the database
@@ -266,7 +268,7 @@ export class AddRedisDatabaseDialog {
266268
const row = Selector('button')
267269
.find('div')
268270
.withText(name);
269-
const removeButton = `[data-testid^=delete-${certificate}-cert]`;
271+
const removeButton = String(this.getDeleteCertificate(certificate));
270272
const removeButtonFooter = Selector('[class^=_popoverFooter]');
271273

272274
if(certificate === TlsCertificates.CA){

tests/e2e/tests/web/critical-path/database/connecting-to-the-db.e2e.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@ test
192192
};
193193
// Verify that user can add SSH tunnel with Password for OSS Cluster database
194194
await myRedisDatabasePage.AddRedisDatabaseDialog.addStandaloneSSHDatabase(sshDbClusterPass, sshWithPass);
195+
// should be deleted after https://redislabs.atlassian.net/browse/RI-5995
195196
await t.wait(6000)
196197
await myRedisDatabasePage.clickOnDBByName(sshDbClusterPass.databaseName);
197198
await Common.checkURLContainsText('browser');

tests/e2e/tests/web/regression/database-overview/database-overview.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ test('Verify that user can set overview refresh', async t => {
4949
const common_command = 'info';
5050

5151
await t.click(browserPage.OverviewPanel.autoRefreshArrow);
52-
await t.expect(browserPage.OverviewPanel.autoRefreshRateInput.textContent).eql('5000 s', 'default value is incorrect');
52+
await t.expect(browserPage.OverviewPanel.autoRefreshRateInput.textContent).eql('5 s', 'default value is incorrect');
5353
await t.click(browserPage.OverviewPanel.autoRefreshCheckbox);
5454
//Start Monitor
5555
await browserPage.Profiler.startMonitor();

tests/e2e/tests/web/regression/database-overview/database-tls-certificates.e2e.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ test('Verify that user can remove added certificates', async t => {
2727
await t.click(browserPage.NavigationPanel.myRedisDBButton);
2828
await myRedisDatabasePage.clickOnEditDBByName(ossStandaloneTlsConfig.databaseName);
2929
await myRedisDatabasePage.AddRedisDatabaseDialog.removeCertificateButton(TlsCertificates.CA, 'ca');
30+
// remove if other Certificates were added
31+
if( await myRedisDatabasePage.AddRedisDatabaseDialog.getDeleteCertificate(TlsCertificates.CA).exists){
32+
await myRedisDatabasePage.AddRedisDatabaseDialog.removeCertificateButton(TlsCertificates.CA, 'ca');
33+
}
3034
await myRedisDatabasePage.reloadPage();
3135
// wait for dbs are displayed
3236
await t.expect(myRedisDatabasePage.dbNameList.count).gt(0);

0 commit comments

Comments
 (0)