Skip to content

Commit bffe4ec

Browse files
authored
Merge pull request #2446 from RedisInsight/fe/bugfix/RI-4838
#RI-4838 - fix closing processing message on error
2 parents b1c3654 + 9a9f16e commit bffe4ec

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

redisinsight/ui/src/components/oauth/oauth-select-account-dialog/OAuthSelectAccountDialog.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,9 @@ const OAuthSelectAccountDialog = () => {
7070
dispatch(removeInfiniteNotification(InfiniteMessagesIds.oAuthProgress))
7171
history.push(Pages.redisCloudSubscriptions)
7272
},
73+
() => {
74+
dispatch(removeInfiniteNotification(InfiniteMessagesIds.oAuthProgress))
75+
}
7376
))
7477
dispatch(setSelectAccountDialogState(false))
7578
} else {

redisinsight/ui/src/slices/oauth/cloud.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import { CloudJobInfo } from 'apiSrc/modules/cloud/job/models'
1616
import { CloudSubscriptionPlanResponse } from 'apiSrc/modules/cloud/subscription/dto'
1717

1818
import { AppDispatch, RootState } from '../store'
19-
import { CloudCapiKey, Instance, OAuthSocialSource, StateAppOAuth } from '../interfaces'
19+
import { CloudCapiKey, CloudJobInfoState, Instance, OAuthSocialSource, StateAppOAuth } from '../interfaces'
2020
import {
2121
addErrorNotification,
2222
addInfiniteNotification,
@@ -117,7 +117,7 @@ const oauthCloudSlice = createSlice({
117117
setSelectAccountDialogState: (state, { payload }: PayloadAction<boolean>) => {
118118
state.isOpenSelectAccountDialog = payload
119119
},
120-
setJob: (state, { payload }: PayloadAction<CloudJobInfo>) => {
120+
setJob: (state, { payload }: PayloadAction<CloudJobInfoState>) => {
121121
state.job = payload
122122
},
123123

@@ -365,6 +365,7 @@ export function fetchPlans(onSuccessAction?: () => void, onFailAction?: () => vo
365365
const error = _err as AxiosError
366366
dispatch(addErrorNotification(error))
367367
dispatch(getPlansFailure())
368+
dispatch(removeInfiniteNotification(InfiniteMessagesIds.oAuthProgress))
368369
onFailAction?.()
369370
}
370371
}

redisinsight/ui/src/slices/tests/oauth/cloud.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1017,6 +1017,7 @@ describe('oauth cloud slice', () => {
10171017
getPlans(),
10181018
addErrorNotification(responsePayload as AxiosError),
10191019
getPlansFailure(),
1020+
removeInfiniteNotification(InfiniteMessagesIds.oAuthProgress),
10201021
]
10211022
expect(store.getActions()).toEqual(expectedActions)
10221023
})

0 commit comments

Comments
 (0)