Skip to content

Commit c0195f4

Browse files
authored
Merge pull request #1524 from RedisInsight/e2e/bugfix/tree_view_improvement
Add 'flushdb', change from big standalone db to standalone db
2 parents 36b03fa + b88f0bb commit c0195f4

File tree

1 file changed

+40
-26
lines changed

1 file changed

+40
-26
lines changed

tests/e2e/tests/critical-path/tree-view/tree-view-improvements.e2e.ts

Lines changed: 40 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import {
55
} from '../../../pageObjects';
66
import {
77
commonUrl,
8-
ossStandaloneBigConfig,
98
ossStandaloneConfig
109
} from '../../../helpers/conf';
1110
import { KeyTypesTexts, rte } from '../../../helpers/constants';
@@ -19,27 +18,28 @@ const cliPage = new CliPage();
1918
let keyNames: string[];
2019
let keyName1: string;
2120
let keyName2: string;
22-
let keynameSingle: string;
21+
let keyNameSingle: string;
2322
let index: string;
2423

2524
fixture`Tree view navigations improvement tests`
2625
.meta({ type: 'critical_path', rte: rte.standalone })
2726
.page(commonUrl);
2827
test
29-
.before(async () => {
28+
.before(async() => {
3029
await acceptLicenseTermsAndAddDatabaseApi(ossStandaloneConfig, ossStandaloneConfig.databaseName);
3130
})
32-
.after(async () => {
31+
.after(async() => {
3332
await t.click(browserPage.patternModeBtn);
3433
await browserPage.deleteKeysByNames(keyNames);
3534
await deleteStandaloneDatabaseApi(ossStandaloneConfig);
3635
})('Tree view preselected folder', async t => {
3736
keyName1 = common.generateWord(10); // used to create index name
3837
keyName2 = common.generateWord(10); // used to create index name
39-
keynameSingle = common.generateWord(10);
40-
keyNames = [`${keyName1}:1`, `${keyName1}:2`, `${keyName2}:1`, `${keyName2}:2`, keynameSingle];
38+
keyNameSingle = common.generateWord(10);
39+
keyNames = [`${keyName1}:1`, `${keyName1}:2`, `${keyName2}:1`, `${keyName2}:2`, keyNameSingle];
4140

4241
const commands = [
42+
'flushdb',
4343
`HSET ${keyNames[0]} field value`,
4444
`HSET ${keyNames[1]} field value`,
4545
`HSET ${keyNames[2]} field value`,
@@ -51,16 +51,16 @@ test
5151
await cliPage.sendCommandsInCli(commands);
5252
await t.click(browserPage.treeViewButton);
5353
// The folder without any patterns selected and the list of keys is displayed when there is a folder without any patterns
54-
await verifyKeysDisplayedInTheList([keynameSingle]);
54+
await verifyKeysDisplayedInTheList([keyNameSingle]);
5555

5656
await browserPage.openTreeFolders([await browserPage.getTextFromNthTreeElement(1)]);
5757
await browserPage.selectFilterGroupType(KeyTypesTexts.Set);
5858
// The folder without any namespaces is selected (if exists) when folder does not exist after search/filter
59-
await verifyKeysDisplayedInTheList([keynameSingle]);
59+
await verifyKeysDisplayedInTheList([keyNameSingle]);
6060

6161
await t.click(browserPage.setDeleteButton);
6262
// The folder without any patterns selected and the list of keys is displayed when there is a folder without any patterns
63-
await verifyKeysDisplayedInTheList([keynameSingle]);
63+
await verifyKeysDisplayedInTheList([keyNameSingle]);
6464
await verifyKeysNotDisplayedInTheList([`${keyNames[0]}:1`, `${keyNames[2]}:2`]);
6565

6666
// switch between browser view and tree view
@@ -82,48 +82,61 @@ test
8282

8383
await cliPage.sendCommandsInCli(commands1);
8484
await t.click(browserPage.refreshKeysButton);
85-
// Refreshed Tree view preselected folder
85+
// Refreshed Tree view preselected folder
8686
await t.expect(firstTreeItemKeys.visible)
8787
.ok('Folder is not selected');
8888
await verifyKeysDisplayedInTheList([`${firstTreeItemText}:1`, `${firstTreeItemText}:2`]);
8989

9090
await browserPage.selectFilterGroupType(KeyTypesTexts.Hash);
9191
await t.expect(firstTreeItemKeys.visible).ok('Folder is not selected after searching with HASH');
92-
// Filterred Tree view preselected folder
92+
// Filtered Tree view preselected folder
9393
await verifyKeysDisplayedInTheList([`${firstTreeItemText}:1`, `${firstTreeItemText}:2`]);
9494

9595
await browserPage.searchByKeyName('*');
96-
// Search capability Filterred Tree view preselected folder
96+
// Search capability Filtered Tree view preselected folder
9797
await t.expect(firstTreeItemKeys.visible).ok('Folder is not selected');
9898
await verifyKeysDisplayedInTheList([`${firstTreeItemText}:1`, `${firstTreeItemText}:2`]);
9999

100100
await t.click(browserPage.clearFilterButton);
101-
// Filterred Tree view preselected folder
101+
// Filtered Tree view preselected folder
102102
await t.expect(firstTreeItemKeys.visible).ok('Folder is not selected');
103103
await verifyKeysDisplayedInTheList([`${firstTreeItemText}:1`, `${firstTreeItemText}:2`]);
104104

105105
await browserPage.selectFilterGroupType(KeyTypesTexts.Stream);
106-
// Filterred Tree view preselected folder
106+
// Filtered Tree view preselected folder
107107
await t.expect(browserPage.keyListTable.textContent).contains('No results found.', 'Key is not found message not displayed');
108108

109109
await t.click(browserPage.streamDeleteButton); // clear stream from filter
110-
// Filterred Tree view preselected folder
110+
// Filtered Tree view preselected folder
111111
await t.expect(browserPage.keyListTable.textContent).notContains('No results found.', 'Key is not found message still displayed');
112112
await t.expect(
113113
firstTreeItemKeys.visible)
114114
.notOk('First folder is expanded');
115115
});
116116

117117
test
118-
.before(async () => {
119-
await acceptLicenseTermsAndAddDatabaseApi(ossStandaloneBigConfig, ossStandaloneBigConfig.databaseName);
118+
.before(async() => {
119+
await acceptLicenseTermsAndAddDatabaseApi(ossStandaloneConfig, ossStandaloneConfig.databaseName);
120120
})
121-
.after(async () => {
121+
.after(async() => {
122122
await cliPage.sendCommandInCli(`FT.DROPINDEX ${index}`);
123-
await deleteStandaloneDatabaseApi(ossStandaloneBigConfig);
123+
await deleteStandaloneDatabaseApi(ossStandaloneConfig);
124124
})('Verify tree view navigation for index based search', async t => {
125+
keyName1 = common.generateWord(10); // used to create index name
126+
keyName2 = common.generateWord(10); // used to create index name
127+
const subFolder1 = common.generateWord(10); // used to create index name
128+
keyNames = [`${keyName1}:${subFolder1}:1`, `${keyName1}:${subFolder1}:2`, `${keyName2}:1:1`, `${keyName2}:1:2`];
129+
const commands = [
130+
'flushdb',
131+
`HSET ${keyNames[0]} field value`,
132+
`HSET ${keyNames[1]} field value`,
133+
`HSET ${keyNames[2]} field value`,
134+
`HSET ${keyNames[3]} field value`
135+
];
136+
await cliPage.sendCommandsInCli(commands);
137+
125138
// generate index based on keyName
126-
const folders = ['mobile', '2014'];
139+
const folders = [keyName1, subFolder1];
127140
index = await cliPage.createIndexwithCLI(folders.join(':'));
128141
await t.click(browserPage.redisearchModeBtn); // click redisearch button
129142
await browserPage.selectIndexByName(index);
@@ -138,19 +151,20 @@ test
138151
});
139152

140153
test
141-
.before(async () => {
154+
.before(async() => {
142155
await acceptLicenseTermsAndAddDatabaseApi(ossStandaloneConfig, ossStandaloneConfig.databaseName);
143156
})
144-
.after(async () => {
157+
.after(async() => {
145158
await t.click(browserPage.patternModeBtn);
146159
await browserPage.deleteKeysByNames(keyNames.slice(1));
147160
await deleteStandaloneDatabaseApi(ossStandaloneConfig);
148161
})('Search capability Refreshed Tree view preselected folder', async t => {
149162
keyName1 = common.generateWord(10); // used to create index name
150163
keyName2 = common.generateWord(10); // used to create index name
151-
keynameSingle = common.generateWord(10);
152-
keyNames = [`${keyName1}:1`, `${keyName1}:2`, `${keyName2}:1`, `${keyName2}:2`, keynameSingle];
164+
keyNameSingle = common.generateWord(10);
165+
keyNames = [`${keyName1}:1`, `${keyName1}:2`, `${keyName2}:1`, `${keyName2}:2`, keyNameSingle];
153166
const commands = [
167+
'flushdb',
154168
`HSET ${keyNames[0]} field value`,
155169
`HSET ${keyNames[1]} field value`,
156170
`RPUSH ${keyNames[2]} field`,
@@ -160,7 +174,7 @@ test
160174
await cliPage.sendCommandsInCli(commands);
161175
await t.click(browserPage.treeViewButton);
162176
// The folder without any patterns selected and the list of keys is displayed when there is a folder without any patterns
163-
await verifyKeysDisplayedInTheList([keynameSingle]);
177+
await verifyKeysDisplayedInTheList([keyNameSingle]);
164178

165179
await browserPage.openTreeFolders([keyName1]); // Type: hash
166180
await browserPage.openTreeFolders([keyName2]); // Type: list
@@ -171,7 +185,7 @@ test
171185
await t.click(browserPage.hashDeleteButton);
172186
await cliPage.sendCommandsInCli([`DEL ${keyNames[0]}`]);
173187
await t.click(browserPage.refreshKeysButton); // refresh keys
174-
// The previously selected folder is preselected when key does not exist after keys refresh
188+
// The previously selected folder is preselected when key does not exist after keys refresh
175189
await verifyKeysDisplayedInTheList([keyNames[1]]);
176190
await verifyKeysNotDisplayedInTheList([keyNames[0], keyNames[2], keyNames[3], keyNames[4]]);
177191

0 commit comments

Comments
 (0)