Skip to content

Commit c2d87f9

Browse files
fix comments
1 parent 83ca836 commit c2d87f9

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

redisinsight/api/src/modules/custom-tutorial/providers/custom-tutorial.fs.provider.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,8 @@ export class CustomTutorialFsProvider {
8686
return Promise.reject(new BadRequestException(ERROR_MESSAGES.CUSTOM_TUTORIAL_UNSUPPORTED_ORIGIN));
8787
}
8888

89+
// false positive. we have whitelist checks above.
90+
// lgtm[js/request-forgery]
8991
const { data } = await axios.get(link, {
9092
responseType: 'arraybuffer',
9193
});

redisinsight/api/src/modules/rdi/client/api.rdi.client.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ export class ApiRdiClient extends RdiClient {
4444
baseURL: rdi.url,
4545
timeout: RDI_TIMEOUT,
4646
httpsAgent: new https.Agent({
47+
// we might work with self-signed certificates for local builds
48+
// lgtm[js/disabling-certificate-validation]
4749
rejectUnauthorized: false,
4850
}),
4951
});

redisinsight/api/src/modules/redis-enterprise/redis-enterprise.service.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,9 @@ export class RedisEnterpriseService {
4141
// TODO: maybe find a workaround without Disabling certificate validation.
4242
private api = axios.create({
4343
httpsAgent: new https.Agent({
44-
rejectUnauthorized: false, // lgtm[js/disabling-certificate-validation]
44+
// we might work with self-signed certificates for local builds
45+
// lgtm[js/disabling-certificate-validation]
46+
rejectUnauthorized: false,
4547
}),
4648
});
4749

0 commit comments

Comments
 (0)