#RI-4537 - remove uniq condition (#2114)

Author: AmirAllayarovSofteq

redisinsight/api/src/modules/database-recommendation/scanner/strategies/integer-in-set.strategy.spec.ts

@@ -36,13 +36,13 @@ describe('IntegersInSetStrategy', () => {
       })).toEqual({ isReached: false });
     });
 
-    it('should return false when some member is not an integer in the first 50 members and not all members are uniq', async () => {
+    it('should return false when some member is not an integer in the first 50 members', async () => {
       expect(await strategy.isRecommendationReached({
         client: nodeClient,
         databaseId: mockDatabaseId,
-        members: [...mockIntegerMembers, ...mockNotIntegerMembers, ...mockNotIntegerMembers] as RedisString[],
+        members: [...mockIntegerMembers, ...mockNotIntegerMembers] as RedisString[],
         keyName: mockKeyName,
-      })).toEqual({ isReached: false });
+      })).toEqual({ isReached: true, params: { keys: [mockKeyName] } });
     });
 
     it('should return false when 51th member is not an integer', async () => {
@@ -53,14 +53,5 @@ describe('IntegersInSetStrategy', () => {
         keyName: mockKeyName,
       })).toEqual({ isReached: false });
     });
-
-    it('should return true when some member is not an integer in the first 50 members and all members are uniq', async () => {
-      expect(await strategy.isRecommendationReached({
-        client: nodeClient,
-        databaseId: mockDatabaseId,
-        members: [...mockIntegerMembers, ...mockNotIntegerMembers] as RedisString[],
-        keyName: mockKeyName,
-      })).toEqual({ isReached: true, params: { keys: [mockKeyName] } });
-    });
   });
 });

redisinsight/api/src/modules/database-recommendation/scanner/strategies/integer-in-set.strategy.ts

@@ -1,4 +1,4 @@
-import { isNaN, toNumber, uniq } from 'lodash';
+import { isNaN, toNumber } from 'lodash';
 import { AbstractRecommendationStrategy }
   from 'src/modules/database-recommendation/scanner/strategies/abstract.recommendation.strategy';
 import { IDatabaseRecommendationStrategyData }
@@ -21,9 +21,7 @@ export class IntegersInSetStrategy extends AbstractRecommendationStrategy {
       (member) => isNaN(toNumber(getUTF8FromRedisString(member))),
     );
 
-    const isAllMembersUniq = uniq(membersForCheck).length === membersForCheck.length;
-
-    return isNotIntegerInSet && isAllMembersUniq
+    return isNotIntegerInSet
       ? { isReached: true, params: { keys: [data?.keyName] } }
       : { isReached: false };
   }