Skip to content

Commit c607512

Browse files
author
Artem
committed
#RI-3736 reimplement functionality to send all commands in uppercase
1 parent 4ba32f8 commit c607512

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

redisinsight/api/src/modules/analytics/telemetry.base.service.spec.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ describe('TelemetryBaseService', () => {
3333

3434
describe('sendEvent', () => {
3535
it('should emit event', () => {
36-
service.sendEvent(TelemetryEvents.RedisInstanceAdded, { data: 'Some data' });
36+
service.sendEvent(TelemetryEvents.RedisInstanceAdded, { data: 'Some data', command: 'lowercase' });
3737

3838
expect(eventEmitter.emit).toHaveBeenCalledWith(AppAnalyticsEvents.Track, {
3939
event: TelemetryEvents.RedisInstanceAdded,
40-
eventData: { data: 'Some data' },
40+
eventData: { data: 'Some data', command: 'LOWERCASE' },
4141
});
4242
});
4343
it('should emit event with empty event data', () => {
@@ -87,13 +87,18 @@ describe('TelemetryBaseService', () => {
8787
});
8888
});
8989
it('should emit event with additional event data', () => {
90-
service.sendFailedEvent(TelemetryEvents.RedisInstanceAddFailed, httpException, { data: 'Some data' });
90+
service.sendFailedEvent(
91+
TelemetryEvents.RedisInstanceAddFailed,
92+
httpException,
93+
{ data: 'Some data', command: 'lowercase' },
94+
);
9195

9296
expect(eventEmitter.emit).toHaveBeenCalledWith(AppAnalyticsEvents.Track, {
9397
event: TelemetryEvents.RedisInstanceAddFailed,
9498
eventData: {
9599
error: 'Internal Server Error',
96100
data: 'Some data',
101+
command: 'LOWERCASE',
97102
},
98103
});
99104
});

redisinsight/api/src/modules/analytics/telemetry.base.service.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { isString } from 'lodash';
12
import { EventEmitter2 } from '@nestjs/event-emitter';
23
import { HttpException } from '@nestjs/common';
34
import { AppAnalyticsEvents } from 'src/constants';
@@ -13,7 +14,10 @@ export abstract class TelemetryBaseService {
1314
try {
1415
this.eventEmitter.emit(AppAnalyticsEvents.Track, {
1516
event,
16-
eventData,
17+
eventData: {
18+
...eventData,
19+
command: isString(eventData['command']) ? eventData['command'].toUpperCase() : eventData['command'],
20+
},
1721
});
1822
} catch (e) {
1923
// continue regardless of error
@@ -27,6 +31,7 @@ export abstract class TelemetryBaseService {
2731
eventData: {
2832
error: exception.getResponse()['error'] || exception.message,
2933
...eventData,
34+
command: isString(eventData['command']) ? eventData['command'].toUpperCase() : eventData['command'],
3035
},
3136
});
3237
} catch (e) {

0 commit comments

Comments
 (0)