RI-6280 put telemetry in the right place

Author: kchepikava

redisinsight/ui/src/components/navigation-menu/NavigationMenu.spec.tsx

@@ -4,17 +4,11 @@ import { BuildType } from 'uiSrc/constants/env'
 import { EXTERNAL_LINKS } from 'uiSrc/constants/links'
 import { appInfoSelector } from 'uiSrc/slices/app/info'
 import { cleanup, mockedStore, render, screen, fireEvent } from 'uiSrc/utils/test-utils'
-import { sendEventTelemetry, TelemetryEvent } from 'uiSrc/telemetry'
 
 import { connectedInstanceSelector } from 'uiSrc/slices/instances/instances'
 import { appContextSelector } from 'uiSrc/slices/app/context'
 import NavigationMenu from './NavigationMenu'
 
-jest.mock('uiSrc/telemetry', () => ({
-  ...jest.requireActual('uiSrc/telemetry'),
-  sendEventTelemetry: jest.fn(),
-}))
-
 let store: typeof mockedStore
 beforeEach(() => {
   cleanup()
@@ -190,35 +184,4 @@ describe('NavigationMenu', () => {
     expect(screen.getByTestId('pipeline-status-page-btn')).toBeTruthy()
     expect(screen.getByTestId('pipeline-management-page-btn')).toBeTruthy()
   })
-
-  it('should call proper telemetry event after click on rdi button', () => {
-    (appContextSelector as jest.Mock).mockImplementation(() => ({
-      ...appContextSelector,
-      workspace: 'redisDataIntegration'
-    }))
-    const sendEventTelemetryMock = jest.fn();
-    (sendEventTelemetry as jest.Mock).mockImplementation(() => sendEventTelemetryMock)
-
-    render(<NavigationMenu />)
-
-    fireEvent.click(screen.getByTestId('pipeline-status-page-btn'))
-
-    expect(sendEventTelemetry).toBeCalledWith({
-      event: TelemetryEvent.OPEN_RDI_CLICKED,
-      eventData: {
-        rdiId: 'mockRdiId',
-        source: 'button',
-      }
-    })
-
-    fireEvent.click(screen.getByTestId('pipeline-management-page-btn'))
-
-    expect(sendEventTelemetry).toBeCalledWith({
-      event: TelemetryEvent.OPEN_RDI_CLICKED,
-      eventData: {
-        rdiId: 'mockRdiId',
-        source: 'button',
-      }
-    })
-  })
 })

redisinsight/ui/src/components/navigation-menu/NavigationMenu.tsx

@@ -43,7 +43,6 @@ import { FeatureFlagComponent } from 'uiSrc/components'
 
 import { appContextSelector } from 'uiSrc/slices/app/context'
 import { AppWorkspace } from 'uiSrc/slices/interfaces'
-import { TelemetryEvent, sendEventTelemetry } from 'uiSrc/telemetry'
 import HelpMenu from './components/help-menu/HelpMenu'
 import NotificationMenu from './components/notifications-center'
 
@@ -178,16 +177,7 @@ const NavigationMenu = () => {
       tooltipText: 'Pipeline Status',
       pageName: PageNames.rdiStatistics,
       ariaLabel: 'Pipeline Status page button',
-      onClick: () => {
-        sendEventTelemetry({
-          event: TelemetryEvent.OPEN_RDI_CLICKED,
-          eventData: {
-            rdiId: connectedRdiInstanceId,
-            source: 'button',
-          }
-        })
-        handleGoPage(Pages.rdiStatistics(connectedRdiInstanceId))
-      },
+      onClick: () => handleGoPage(Pages.rdiStatistics(connectedRdiInstanceId)),
       dataTestId: 'pipeline-status-page-btn',
       isActivePage: activePage === `/${PageNames.rdiStatistics}`,
       getClassName() {
@@ -201,16 +191,7 @@ const NavigationMenu = () => {
       tooltipText: 'Pipeline Management',
       pageName: PageNames.rdiPipelineManagement,
       ariaLabel: 'Pipeline Management page button',
-      onClick: () => {
-        sendEventTelemetry({
-          event: TelemetryEvent.OPEN_RDI_CLICKED,
-          eventData: {
-            rdiId: connectedRdiInstanceId,
-            source: 'button',
-          }
-        })
-        handleGoPage(Pages.rdiPipelineManagement(connectedRdiInstanceId))
-      },
+      onClick: () => handleGoPage(Pages.rdiPipelineManagement(connectedRdiInstanceId)),
       dataTestId: 'pipeline-management-page-btn',
       isActivePage: isPipelineManagementPath(),
       getClassName() {

redisinsight/ui/src/pages/rdi/home/instance-list/RdiInstancesListWrapper.tsx

@@ -71,7 +71,15 @@ const RdiInstancesListWrapper = ({ width, onEditInstance, editedInstance, onDele
   const handleCheckConnectToInstance = (id: string) => {
     dispatch(checkConnectToRdiInstanceAction(
       id,
-      (id: string) => history.push(Pages.rdiPipeline(id)),
+      (id: string) => {
+        sendEventTelemetry({
+          event: TelemetryEvent.OPEN_RDI_CLICKED,
+          eventData: {
+            rdiId: id,
+          }
+        })
+        history.push(Pages.rdiPipeline(id))
+      },
       () => dispatch(setAppContextConnectedRdiInstanceId(''))
     ))
   }