#RI-4489 fix bind issue + UTests

Author: Artem

redisinsight/api/src/__mocks__/feature.ts

@@ -43,9 +43,9 @@ export const mockFeaturesConfigJsonComplex = {
         {
           or: [
             {
-              name: 'env.FORCE_ENABLE_LIVE_RECOMMENDATIONS',
-              value: 'true',
-              type: 'eq',
+              name: 'settings.testValue',
+              value: 'test',
+              cond: 'eq',
             },
             {
               and: [
@@ -98,9 +98,9 @@ export const mockFeaturesConfigDataComplex = Object.assign(new FeaturesConfigDat
         Object.assign(new FeatureConfigFilterOr(), {
           or: [
             Object.assign(new FeatureConfigFilter(), {
-              name: 'env.FORCE_ENABLE_LIVE_RECOMMENDATIONS',
-              value: 'true',
-              type: 'eq',
+              name: 'settings.testValue',
+              value: 'test',
+              cond: 'eq',
             }),
             Object.assign(new FeatureConfigFilterAnd(), {
               and: [

redisinsight/api/src/modules/feature/feature.service.ts

@@ -71,9 +71,9 @@ export class FeatureService {
       actions.toDelete = featuresFromDatabase.filter((feature) => !featuresConfig?.data?.features?.[feature.name]);
 
       // delete features
-      await Promise.all(actions.toDelete.map(this.repository.delete.bind(this)));
+      await Promise.all(actions.toDelete.map(this.repository.delete.bind(this.repository)));
       // upsert modified features
-      await Promise.all(actions.toUpsert.map(this.repository.upsert.bind(this)));
+      await Promise.all(actions.toUpsert.map(this.repository.upsert.bind(this.repository)));
 
       this.logger.log(
         `Features flags recalculated. Updated: ${actions.toUpsert.length} deleted: ${actions.toDelete.length}`,

redisinsight/api/src/modules/feature/providers/feature-flag/strategies/feature.flag.strategy.spec.ts

@@ -212,11 +212,33 @@ describe('FeatureFlagStrategy', () => {
   });
 
   describe('filter (complex)', () => {
-    it('should return true for single filter by agreements (eq)', async () => {
+    it('should return true since 2nd or is true', async () => {
       settingsService.getAppSettings.mockResolvedValueOnce({
+        ...mockAppSettings,
         agreements: { analytics: true },
       });
 
+      expect(
+        await service['filter'](mockFeaturesConfigDataComplex.features.get('liveRecommendations').filters),
+      ).toEqual(true);
+    });
+    it('should return false since all 2 or conditions are false', async () => {
+      settingsService.getAppSettings.mockResolvedValueOnce({
+        ...mockAppSettings,
+        agreements: { analytics: false },
+      });
+
+      expect(
+        await service['filter'](mockFeaturesConfigDataComplex.features.get('liveRecommendations').filters),
+      ).toEqual(false);
+    });
+    it('should return true since all 1st or is true', async () => {
+      settingsService.getAppSettings.mockResolvedValueOnce({
+        ...mockAppSettings,
+        testValue: 'test',
+        agreements: { analytics: false },
+      });
+
       expect(
         await service['filter'](mockFeaturesConfigDataComplex.features.get('liveRecommendations').filters),
       ).toEqual(true);