Skip to content

Commit cc454fa

Browse files
authored
Merge pull request #3769 from RedisInsight/fe/bugfix/RI-6066-time-format-fixes
RI-6066 fixes in datetime formatter
2 parents ffaac92 + 19e2fdb commit cc454fa

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed

redisinsight/ui/src/constants/datetime.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1+
import { DATETIME_FORMATTER_DEFAULT } from './keys'
2+
13
export const dateTimeOptions = [
2-
{ inputDisplay: 'HH:mm:ss.SSS d MMM yyyy', value: 'HH:mm:ss.SSS d MMM yyyy' },
4+
{ inputDisplay: DATETIME_FORMATTER_DEFAULT, value: DATETIME_FORMATTER_DEFAULT },
35
{ inputDisplay: 'yyyy-MM-dd HH:mm:ss.sss', value: 'yyyy-MM-dd HH:mm:ss.sss' },
46
{ inputDisplay: 'dd-MMM-yyyy HH:mm:ss.SSS', value: 'dd-MMM-yyyy HH:mm:ss.SSS' },
57
{ inputDisplay: 'dd.MM.yyyy HH:mm:ss', value: 'dd.MM.yyyy HH:mm:ss' }

redisinsight/ui/src/constants/keys.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ export enum KeyValueFormat {
151151
DateTime = 'DateTime',
152152
}
153153

154-
export const DATETIME_FORMATTER_DEFAULT = 'HH:mm:ss.SSS d MMM yyyy'
154+
export const DATETIME_FORMATTER_DEFAULT = 'HH:mm:ss d MMM yyyy'
155155

156156
export enum KeyValueCompressor {
157157
GZIP = 'GZIP',

redisinsight/ui/src/pages/settings/components/general-settings/datetime-formatter/components/datetime-form/DatetimeForm.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,9 @@ const DatetimeForm = ({ onFormatChange }: Props) => {
8484

8585
const handleFormatCheck = (format = formik.values.format) => {
8686
const { valid, error: errorMsg } = checkDateTimeFormat(format)
87-
if (!valid) {
87+
if (format.length > 50) {
88+
setError('Format should not exceed 50 characters')
89+
} else if (!valid) {
8890
setError(errorMsg || 'This format is not supported')
8991
onFormatChange?.('Invalid Format')
9092
} else {

redisinsight/ui/src/pages/settings/components/general-settings/datetime-formatter/styles.module.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,7 @@
2020
background-color: var(--euiPageBackgroundColor);
2121
padding: 4px;
2222
margin-left: 4px;
23+
overflow-x: hidden;
24+
text-overflow: ellipsis;
25+
max-width: 330px;
2326
}

0 commit comments

Comments
 (0)