Skip to content

Commit ceb0c26

Browse files
committed
fix for formatters
1 parent 50de863 commit ceb0c26

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

tests/e2e/pageObjects/browser-page.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export class BrowserPage extends InstancePage {
3939
refreshKeysButton = Selector('[data-testid=refresh-keys-btn]');
4040
refreshKeyButton = Selector('[data-testid=refresh-key-btn]');
4141
editKeyNameButton = Selector('[data-testid=edit-key-btn]');
42-
editKeyValueButton = Selector('[data-testid=edit-key-value-btn]');
42+
editKeyValueButton = Selector('[data-testid=edit-key-value-btn]', { timeout: 500 });
4343
closeKeyButton = Selector('[data-testid=close-key-btn]');
4444
plusAddKeyButton = Selector('[data-testid=btn-add-key]');
4545
addKeyValueItemsButton = Selector('[data-testid=add-key-value-items-btn]');

tests/e2e/tests/web/critical-path/browser/formatters.e2e.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,11 @@ formattersHighlightedSet.forEach(formatter => {
5757
// Verify that value is formatted and highlighted
5858
await t.expect(valueSelector.find(browserPage.cssJsonValue).exists).ok(`${key.textType} Value is not formatted to ${formatter.format}`);
5959
// Verify that Hash field is formatted and highlighted for JSON and PHP serialized
60-
if (key.keyName === 'hash') {
60+
if (key.textType === 'Hash') {
6161
await t.expect(browserPage.hashField.find(browserPage.cssJsonValue).exists).ok(`Hash field is not formatted to ${formatter.format}`);
6262
}
6363
// Verify that Stream field is formatted and highlighted for JSON and PHP serialized
64-
if (key.keyName === 'stream') {
64+
if (key.textType === 'Stream') {
6565
await t.expect(Selector(browserPage.cssJsonValue).count).eql(2, `Hash field is not formatted to ${formatter.format}`);
6666
}
6767
}
@@ -193,10 +193,10 @@ notEditableFormattersSet.forEach(formatter => {
193193
// Verify for Protobuf, Java serialized, Pickle
194194
// Verify for Hash, List, ZSet, String keys
195195
for (const key of keysData) {
196-
if (key.keyName === 'hash' || key.keyName === 'list' || key.keyName === 'zset' || key.keyName === 'string') {
197-
const editBtn = (key.keyName === 'string')
196+
if (key.textType === 'Hash' || key.textType === 'List' || key.textType === 'Sorted Set' || key.textType === 'String') {
197+
const editBtn = (key.textType === 'String')
198198
? browserPage.editKeyValueButton
199-
: Selector(`[data-testid^=edit-][data-testid*=${key.keyName.split('-')[0]}]`);
199+
: Selector(`[data-testid*=edit-][data-testid*=${key.keyName.split('-')[0]}]`, { timeout: 500 });
200200
await browserPage.openKeyDetailsByKeyName(key.keyName);
201201
await browserPage.selectFormatter(formatter.format);
202202
// Verify that edit button disabled
@@ -205,8 +205,6 @@ notEditableFormattersSet.forEach(formatter => {
205205
await t.hover(editBtn);
206206
// Verify tooltip content
207207
await t.expect(browserPage.tooltip.textContent).contains('Cannot edit the value in this format', 'Tooltip has wrong text');
208-
await t.click(editBtn);
209-
await t.expect(browserPage.applyButton.exists).notOk('Edit field is displayed even if disabled');
210208
}
211209
}
212210
});

0 commit comments

Comments
 (0)