Skip to content

Commit cf64f88

Browse files
author
arthosofteq
authored
Merge pull request #1886 from RedisInsight/fe/feature/RI-4149-Enhance_syntax_in_auto-completion
#RI-4149 Enhance syntax in auto-completion
2 parents 8a109e9 + 516a1a9 commit cf64f88

File tree

7 files changed

+915
-388
lines changed

7 files changed

+915
-388
lines changed

redisinsight/ui/src/components/cli/components/cli-input/CliAutocomplete/CliAutocomplete.spec.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,19 +22,19 @@ const scanArgs = [
2222
type: 'integer',
2323
},
2424
{
25-
command: 'MATCH',
25+
token: 'MATCH',
2626
name: 'pattern',
2727
type: 'pattern',
2828
optional: true,
2929
},
3030
{
31-
command: 'COUNT',
31+
token: 'COUNT',
3232
name: 'count',
3333
type: 'integer',
3434
optional: true,
3535
},
3636
{
37-
command: 'TYPE',
37+
token: 'TYPE',
3838
name: 'type',
3939
type: 'string',
4040
optional: true,

redisinsight/ui/src/components/cli/components/cli-input/CliInputWrapper.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const CliInputWrapper = (props: Props) => {
2626
const firstCommandMatch = firstCommand.toUpperCase()
2727
const secondCommandMatch = `${firstCommandMatch} ${secondCommand ? secondCommand.toUpperCase() : null}`
2828

29-
const matchedCmd = ALL_REDIS_COMMANDS[firstCommandMatch] || ALL_REDIS_COMMANDS[secondCommandMatch]
29+
const matchedCmd = ALL_REDIS_COMMANDS[secondCommandMatch] || ALL_REDIS_COMMANDS[firstCommandMatch]
3030
const commandName = !isUndefined(ALL_REDIS_COMMANDS[secondCommandMatch])
3131
? `${firstCommand} ${secondCommand}`
3232
: firstCommand

redisinsight/ui/src/components/command-helper/CommandHelperWrapper.spec.tsx

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,8 @@ const mockedCommands: IMockedCommands[] = [
5151
{
5252
matchedCommand: 'xgroup',
5353
argStr:
54-
'XGROUP [CREATE key groupname ID|$ [MKSTREAM]] [SETID key groupname ID|$] [DESTROY key groupname] [CREATECONSUMER key groupname consumername] [DELCONSUMER key groupname consumername]',
55-
argListText:
56-
'Arguments:Optional[CREATE key groupname id [MKSTREAM]]Optional[SETID key groupname id]Optional[DESTROY key groupname]Optional[CREATECONSUMER key groupname consumername]Optional[DELCONSUMER key groupname consumername]',
54+
'XGROUP',
55+
argListText: '',
5756
},
5857
{
5958
matchedCommand: 'hset',
@@ -68,28 +67,28 @@ const mockedCommands: IMockedCommands[] = [
6867
{
6968
matchedCommand: 'bitfield',
7069
argStr:
71-
'BITFIELD key [GET type offset] [SET type offset value] [INCRBY type offset increment] [OVERFLOW WRAP|SAT|FAIL]',
70+
'BITFIELD key [GET encoding offset | [OVERFLOW <WRAP | SAT | FAIL>] <SET encoding offset value | INCRBY encoding offset increment> [GET encoding offset | [OVERFLOW <WRAP | SAT | FAIL>] <SET encoding offset value | INCRBY encoding offset increment> ...]]',
7271
argListText:
73-
'Arguments:RequiredkeyOptional[GET type offset]Optional[SET type offset value]Optional[INCRBY type offset increment]Optional[OVERFLOW WRAP|SAT|FAIL]',
72+
'Arguments:RequiredkeyMultiple[GET encoding offset | [OVERFLOW <WRAP | SAT | FAIL>] <SET encoding offset value | INCRBY encoding offset increment>]',
7473
},
7574
{
7675
matchedCommand: 'client kill',
7776
argStr:
78-
'CLIENT KILL [ip:port] [ID client-id] [TYPE normal|master|slave|pubsub] [USER username] [ADDR ip:port] [LADDR ip:port] [SKIPME yes/no]',
77+
'CLIENT KILL <ip:port | <[ID client-id] | [TYPE <NORMAL | MASTER | SLAVE | REPLICA | PUBSUB>] | [USER username] | [ADDR ip:port] | [LADDR ip:port] | [SKIPME <YES | NO>] [[ID client-id] | [TYPE <NORMAL | MASTER | SLAVE | REPLICA | PUBSUB>] | [USER username] | [ADDR ip:port] | [LADDR ip:port] | [SKIPME <YES | NO>] ...]>>',
7978
argListText:
80-
'Arguments:Optional[ip:port]Optional[ID client-id]Optional[TYPE normal|master|slave|pubsub]Optional[USER username]Optional[ADDR ip:port]Optional[LADDR ip:port]Optional[SKIPME yes/no]',
79+
'Arguments:Required<ip:port | <[ID client-id] | [TYPE <NORMAL | MASTER | SLAVE | REPLICA | PUBSUB>] | [USER username] | [ADDR ip:port] | [LADDR ip:port] | [SKIPME <YES | NO>] [[ID client-id] | [TYPE <NORMAL | MASTER | SLAVE | REPLICA | PUBSUB>] | [USER username] | [ADDR ip:port] | [LADDR ip:port] | [SKIPME <YES | NO>] ...]>>',
8180
},
8281
{
8382
matchedCommand: 'geoadd',
84-
argStr: 'GEOADD key [NX|XX] [CH] longitude latitude member [longitude latitude member ...]',
83+
argStr: 'GEOADD key [NX | XX] [CH] longitude latitude member [longitude latitude member ...]',
8584
argListText:
86-
'Arguments:RequiredkeyOptional[condition]Optional[change]Multiplelongitude latitude member',
85+
'Arguments:RequiredkeyOptional[NX | XX]Optional[CH]Multiplelongitude latitude member',
8786
},
8887
{
8988
matchedCommand: 'zadd',
90-
argStr: 'ZADD key [NX|XX] [GT|LT] [CH] [INCR] score member [score member ...]',
89+
argStr: 'ZADD key [NX | XX] [GT | LT] [CH] [INCR] score member [score member ...]',
9190
argListText:
92-
'Arguments:RequiredkeyOptional[condition]Optional[comparison]Optional[change]Optional[increment]Multiplescore member',
91+
'Arguments:RequiredkeyOptional[NX | XX]Optional[GT | LT]Optional[CH]Optional[INCR]Multiplescore member',
9392
},
9493
]
9594

@@ -127,8 +126,10 @@ describe('CliBodyWrapper', () => {
127126

128127
const { unmount } = render(<CommandHelperWrapper />)
129128

130-
expect(screen.getByTestId(cliHelperTestId)).toBeInTheDocument()
131-
expect(screen.getByTestId(argsId)).toHaveTextContent(argListText)
129+
if (argListText) {
130+
expect(screen.getByTestId(cliHelperTestId)).toBeInTheDocument()
131+
expect(screen.getByTestId(argsId)).toHaveTextContent(argListText)
132+
}
132133

133134
unmount()
134135
})

redisinsight/ui/src/components/command-helper/components/command-helper-search-output/CliSearchOutput.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ const mockedCommands: IMockedCommands[] = [
2727
},
2828
{
2929
matchedCommand: 'GEOADD',
30-
argStr: 'key [NX|XX] [CH] longitude latitude member [longitude latitude member ...]',
30+
argStr: 'key [NX | XX] [CH] longitude latitude member [longitude latitude member ...]',
3131
},
3232
{
3333
matchedCommand: 'ZADD',
34-
argStr: 'key [NX|XX] [GT|LT] [CH] [INCR] score member [score member ...]',
34+
argStr: 'key [NX | XX] [GT | LT] [CH] [INCR] score member [score member ...]',
3535
},
3636
{
3737
matchedCommand: 'RESET',

0 commit comments

Comments
 (0)