Skip to content

Commit dc42d98

Browse files
author
Roman.Sergeenko
committed
#RI-2163 - Update events for CLI and Command Helper
1 parent a10feb2 commit dc42d98

File tree

4 files changed

+18
-12
lines changed

4 files changed

+18
-12
lines changed

redisinsight/ui/src/components/bottom-group-components/components/bottom-group-minimized/BottomGroupMinimized.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ const BottomGroupMinimized = () => {
2828

2929
const handleExpandCli = () => {
3030
sendEventTelemetry({
31-
event: TelemetryEvent.CLI_OPENED,
31+
event: isShowCli ? TelemetryEvent.CLI_MINIMIZED : TelemetryEvent.CLI_OPENED,
3232
eventData: {
3333
databaseId: instanceId
3434
}
@@ -38,7 +38,7 @@ const BottomGroupMinimized = () => {
3838

3939
const handleExpandHelper = () => {
4040
sendEventTelemetry({
41-
event: isShowHelper ? TelemetryEvent.COMMAND_HELPER_COLLAPSED : TelemetryEvent.COMMAND_HELPER_EXPANDED,
41+
event: isShowHelper ? TelemetryEvent.COMMAND_HELPER_MINIMIZED : TelemetryEvent.COMMAND_HELPER_OPENED,
4242
eventData: {
4343
databaseId: instanceId
4444
}

redisinsight/ui/src/components/cli/components/cli-header/CliHeader.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ const CliHeader = () => {
4848

4949
const handleCloseCli = () => {
5050
sendEventTelemetry({
51-
event: TelemetryEvent.CLI_HIDDEN,
51+
event: TelemetryEvent.CLI_CLOSED,
5252
eventData: {
5353
databaseId: instanceId
5454
}

redisinsight/ui/src/components/command-helper/CommandHelperHeader/CommandHelperHeader.tsx

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from 'react'
2-
import { useDispatch, useSelector } from 'react-redux'
2+
import { useDispatch } from 'react-redux'
33
import { useParams } from 'react-router-dom'
44

55
import {
@@ -11,18 +11,17 @@ import {
1111
EuiIcon,
1212
} from '@elastic/eui'
1313
import { sendEventTelemetry, TelemetryEvent } from 'uiSrc/telemetry'
14-
import { cliSettingsSelector, resetCliHelperSettings, toggleCliHelper } from 'uiSrc/slices/cli/cli-settings'
14+
import { resetCliHelperSettings, toggleCliHelper } from 'uiSrc/slices/cli/cli-settings'
1515

1616
import styles from './styles.module.scss'
1717

1818
const CommandHelperHeader = () => {
19-
const { isShowHelper } = useSelector(cliSettingsSelector)
2019
const { instanceId = '' } = useParams<{ instanceId: string }>()
2120
const dispatch = useDispatch()
2221

23-
const handleExpandHelper = () => {
22+
const handleCloseHelper = () => {
2423
sendEventTelemetry({
25-
event: isShowHelper ? TelemetryEvent.COMMAND_HELPER_COLLAPSED : TelemetryEvent.COMMAND_HELPER_EXPANDED,
24+
event: TelemetryEvent.COMMAND_HELPER_CLOSED,
2625
eventData: {
2726
databaseId: instanceId
2827
}
@@ -31,6 +30,12 @@ const CommandHelperHeader = () => {
3130
}
3231

3332
const handleHideHelper = () => {
33+
sendEventTelemetry({
34+
event: TelemetryEvent.COMMAND_HELPER_MINIMIZED,
35+
eventData: {
36+
databaseId: instanceId
37+
}
38+
})
3439
dispatch(toggleCliHelper())
3540
}
3641

@@ -80,7 +85,7 @@ const CommandHelperHeader = () => {
8085
aria-label="close command helper"
8186
data-testid="close-command-helper"
8287
className={styles.icon}
83-
onClick={handleExpandHelper}
88+
onClick={handleCloseHelper}
8489
/>
8590
</EuiToolTip>
8691
</EuiFlexItem>

redisinsight/ui/src/telemetry/events.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,12 @@ export enum TelemetryEvent {
4040
BROWSER_JSON_KEY_COLLAPSED = 'BROWSER_JSON_KEY_COLLAPSED',
4141

4242
CLI_OPENED = 'CLI_OPENED',
43-
CLI_HIDDEN = 'CLI_HIDDEN',
43+
CLI_CLOSED = 'CLI_CLOSED',
4444
CLI_MINIMIZED = 'CLI_MINIMIZED',
4545
CLI_COMMAND_SUBMITTED = 'CLI_COMMAND_SUBMITTED',
46-
COMMAND_HELPER_EXPANDED = 'COMMAND_HELPER_EXPANDED',
47-
COMMAND_HELPER_COLLAPSED = 'COMMAND_HELPER_COLLAPSED',
46+
COMMAND_HELPER_OPENED = 'COMMAND_HELPER_OPENED',
47+
COMMAND_HELPER_CLOSED = 'COMMAND_HELPER_CLOSED',
48+
COMMAND_HELPER_MINIMIZED = 'COMMAND_HELPER_MINIMIZED',
4849
COMMAND_HELPER_INFO_DISPLAYED_FOR_CLI_INPUT = 'COMMAND_HELPER_INFO_DISPLAYED_FOR_CLI_INPUT',
4950
COMMAND_HELPER_COMMAND_FILTERED = 'COMMAND_HELPER_COMMAND_FILTERED',
5051
COMMAND_HELPER_COMMAND_OPENED = 'COMMAND_HELPER_COMMAND_OPENED',

0 commit comments

Comments
 (0)