Skip to content

Commit dee54a2

Browse files
committed
fix tests
1 parent 5e9db8b commit dee54a2

File tree

7 files changed

+18
-13
lines changed

7 files changed

+18
-13
lines changed

redisinsight/ui/src/pages/browser/BrowserPage.test.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { useSelector } from 'react-redux'
55
import { render, screen, fireEvent, mockedStore, cleanup, act, waitForEuiToolTipVisible } from 'uiSrc/utils/test-utils'
66
import { KeyTypes } from 'uiSrc/constants'
77
import { RootState } from 'uiSrc/slices/store'
8-
import { toggleBrowserFullScreen } from 'uiSrc/slices/browser/keys'
8+
import { setSelectedKeyRefreshDisabled, toggleBrowserFullScreen } from 'uiSrc/slices/browser/keys'
99
import BrowserPage from './BrowserPage'
1010
import KeyList, { Props as KeyListProps } from './components/key-list/KeyList'
1111

@@ -198,7 +198,7 @@ describe('KeyDetailsWrapper', () => {
198198
expect(queryByTestId('apply-btn')).toBeInTheDocument()
199199
expect(queryByTestId('apply-btn')).toBeDisabled()
200200

201-
expect(store.getActions()).toEqual([...afterRenderActions])
201+
expect(store.getActions()).toEqual([...afterRenderActions, setSelectedKeyRefreshDisabled(true)])
202202

203203
await act(async () => {
204204
fireEvent.mouseOver(screen.getByTestId('apply-btn'))
@@ -259,7 +259,7 @@ describe('KeyDetailsWrapper', () => {
259259
expect(queryByTestId('apply-btn')).toBeInTheDocument()
260260
expect(queryByTestId('apply-btn')).toBeDisabled()
261261

262-
expect(store.getActions()).toEqual([...afterRenderActions])
262+
expect(store.getActions()).toEqual([...afterRenderActions, setSelectedKeyRefreshDisabled(true)])
263263
})
264264

265265
it('Verify that user cannot save key value (List) with unprintable characters', () => {
@@ -313,7 +313,7 @@ describe('KeyDetailsWrapper', () => {
313313
expect(queryByTestId('apply-btn')).toBeInTheDocument()
314314
expect(queryByTestId('apply-btn')).toBeDisabled()
315315

316-
expect(store.getActions()).toEqual([...afterRenderActions])
316+
expect(store.getActions()).toEqual([...afterRenderActions, setSelectedKeyRefreshDisabled(true)])
317317
})
318318
})
319319

redisinsight/ui/src/pages/browser/modules/key-details/components/hash-details/hash-details-table/HashDetailsTable.spec.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,12 +143,14 @@ describe('HashDetailsTable', () => {
143143
})
144144
})
145145

146-
it('should disable refresh after click on edit', () => {
146+
it('should disable refresh after click on edit', async () => {
147147
render(<HashDetailsTable {...instance(mockedProps)} />)
148148

149149
const afterRenderActions = [...store.getActions()]
150150

151-
fireEvent.click(screen.getAllByTestId(/edit-hash-button/)[0])
151+
await act(() => {
152+
fireEvent.click(screen.getByTestId('edit-hash-button-2'))
153+
})
152154

153155
expect(store.getActions()).toEqual([
154156
...afterRenderActions,

redisinsight/ui/src/pages/browser/modules/key-details/components/list-details/list-details-table/ListDetailsTable.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ describe('ListDetailsTable', () => {
145145
const afterRenderActions = [...store.getActions()]
146146

147147
await act(() => {
148-
fireEvent.click(screen.getAllByTestId(/edit-list-button/)[0])
148+
fireEvent.click(screen.getByTestId('edit-list-button-0'))
149149
})
150150

151151
expect(store.getActions()).toEqual([

redisinsight/ui/src/pages/browser/modules/key-details/components/string-details/StringDetails.spec.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import React from 'react'
22
import { instance, mock } from 'ts-mockito'
33
import { cloneDeep } from 'lodash'
4-
import { fireEvent } from '@testing-library/react'
5-
import { cleanup, mockedStore, render, screen } from 'uiSrc/utils/test-utils'
4+
import { cleanup, mockedStore, render, screen, fireEvent, act } from 'uiSrc/utils/test-utils'
65
import { stringDataSelector, stringSelector } from 'uiSrc/slices/browser/string'
76
import { setSelectedKeyRefreshDisabled } from 'uiSrc/slices/browser/keys'
87
import { Props, StringDetails } from './StringDetails'
@@ -98,11 +97,14 @@ describe('StringDetails', () => {
9897
expect(queryByTestId('edit-key-value-btn')).toBeInTheDocument()
9998
})
10099

101-
it('should disable refresh when editing', () => {
100+
it('should disable refresh when editing', async () => {
102101
render(<StringDetails {...mockedProps} />)
103102
const afterRenderActions = [...store.getActions()]
104103

105-
fireEvent.click(screen.getByTestId(`${EDIT_VALUE_BTN_TEST_ID}`))
104+
await act(() => {
105+
fireEvent.click(screen.getByTestId(`${EDIT_VALUE_BTN_TEST_ID}`))
106+
})
107+
106108
expect(store.getActions()).toEqual([
107109
...afterRenderActions,
108110
setSelectedKeyRefreshDisabled(true)

redisinsight/ui/src/pages/browser/modules/key-details/components/zset-details/zset-details-table/ZSetDetailsTable.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ describe('ZSetDetailsTable', () => {
113113
const afterRenderActions = [...store.getActions()]
114114

115115
await act(() => {
116-
fireEvent.click(screen.getByTestId(/zset-edit-button-3/))
116+
fireEvent.click(screen.getAllByTestId(/zset-edit-button/)[0])
117117
})
118118

119119
expect(store.getActions()).toEqual([

redisinsight/ui/src/slices/browser/keys.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,9 +179,9 @@ const keysSlice = createSlice({
179179
state.selectedKey = {
180180
...state.selectedKey,
181181
loading: false,
182+
isRefreshDisabled: false,
182183
data: {
183184
...payload,
184-
isRefreshDisabled: false,
185185
nameString: bufferToString(payload.name),
186186
},
187187
}

redisinsight/ui/src/slices/tests/browser/keys.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -383,6 +383,7 @@ describe('keys slice', () => {
383383
selectedKey: {
384384
...initialState.selectedKey,
385385
loading: false,
386+
isRefreshDisabled: false,
386387
data: {
387388
...data,
388389
},

0 commit comments

Comments
 (0)