Skip to content

Commit e0c6b03

Browse files
committed
* #RI-3848 - Button is displayed with incorrect scanned parameters
* Upper case for all commands in workbench
1 parent 2986421 commit e0c6b03

File tree

12 files changed

+76
-24
lines changed

12 files changed

+76
-24
lines changed

redisinsight/ui/src/components/query/QueryWrapper.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ const QueryWrapper = (props: Props) => {
8080
const command = [commandLine, multiCommands].join('') ? [commandLine, multiCommands].join(';') : null
8181

8282
return {
83-
command,
83+
command: command?.toUpperCase(),
8484
databaseId: instanceId,
8585
multiple: multiCommands ? 'Multiple' : 'Single',
8686
pipeline: batchSize > 1,

redisinsight/ui/src/pages/browser/components/browser-left-panel/BrowserLeftPanel.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,14 @@ const BrowserLeftPanel = (props: Props) => {
5454
const { loading: patternLoading, viewType, searchMode, isSearched: patternIsSearched } = useSelector(keysSelector)
5555
const { contextInstanceId } = useSelector(appContextSelector)
5656
const {
57-
keyList: { isDataLoaded, scrollPatternTopPosition, scrollRedisearchTopPosition }
57+
keyList: { isDataPatternLoaded, isDataRedisearchLoaded, scrollPatternTopPosition, scrollRedisearchTopPosition }
5858
} = useSelector(appContextBrowser)
5959

6060
const keyListRef = useRef<any>()
6161

6262
const dispatch = useDispatch()
6363

64+
const isDataLoaded = searchMode === SearchMode.Pattern ? isDataPatternLoaded : isDataRedisearchLoaded
6465
const keysState = searchMode === SearchMode.Pattern ? patternKeysState : redisearchKeysState
6566
const loading = searchMode === SearchMode.Pattern ? patternLoading : redisearchLoading || redisearchListLoading
6667
const isSearched = searchMode === SearchMode.Pattern ? patternIsSearched : redisearchIsSearched
@@ -79,8 +80,8 @@ const BrowserLeftPanel = (props: Props) => {
7980
searchMode,
8081
'0',
8182
keyViewType === KeyViewType.Browser ? SCAN_COUNT_DEFAULT : SCAN_TREE_COUNT_DEFAULT,
82-
() => dispatch(setBrowserKeyListDataLoaded(true)),
83-
() => dispatch(setBrowserKeyListDataLoaded(false))
83+
() => dispatch(setBrowserKeyListDataLoaded(searchMode, true)),
84+
() => dispatch(setBrowserKeyListDataLoaded(searchMode, false))
8485
))
8586
}, [searchMode])
8687

redisinsight/ui/src/pages/browser/components/key-list/KeyList.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ import {
3333
fetchKeysMetadata,
3434
keysDataSelector,
3535
keysSelector,
36+
resetKeysData,
3637
selectedKeySelector,
3738
setLastBatchKeys,
3839
sourceKeysFetch,
@@ -117,6 +118,7 @@ const KeyList = forwardRef((props: Props, ref) => {
117118
if (itemsRef.current.length === 0) {
118119
cancelAllMetadataRequests()
119120
setFirstDataLoaded(true)
121+
dispatch(resetKeysData(searchMode))
120122
rerender({})
121123
return
122124
}

redisinsight/ui/src/pages/browser/components/keys-header/KeysHeader.tsx

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,8 @@ const KeysHeader = (props: Props) => {
168168
searchMode,
169169
'0',
170170
viewType === KeyViewType.Browser ? SCAN_COUNT_DEFAULT : SCAN_TREE_COUNT_DEFAULT,
171-
() => dispatch(setBrowserKeyListDataLoaded(true)),
172-
() => dispatch(setBrowserKeyListDataLoaded(false)),
171+
() => dispatch(setBrowserKeyListDataLoaded(searchMode, true)),
172+
() => dispatch(setBrowserKeyListDataLoaded(searchMode, false)),
173173
))
174174
}
175175

@@ -229,11 +229,14 @@ const KeysHeader = (props: Props) => {
229229
}
230230
})
231231
}
232-
dispatch(resetKeysData(searchMode))
233-
dispatch(changeKeyViewType(type))
234232
dispatch(resetBrowserTree())
233+
dispatch(resetKeysData(searchMode))
235234
localStorageService.set(BrowserStorageItem.browserViewType, type)
236235
loadKeys(type)
236+
237+
setTimeout(() => {
238+
dispatch(changeKeyViewType(type))
239+
}, 0)
237240
}
238241

239242
const handleSwitchSearchMode = (mode: SearchMode) => {

redisinsight/ui/src/pages/databaseAnalysis/components/top-keys/Table.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ const Table = (props: Props) => {
5959
SearchMode.Pattern,
6060
'0',
6161
viewType === KeyViewType.Browser ? SCAN_COUNT_DEFAULT : SCAN_TREE_COUNT_DEFAULT,
62-
() => dispatch(setBrowserKeyListDataLoaded(true)),
63-
() => dispatch(setBrowserKeyListDataLoaded(false)),
62+
() => dispatch(setBrowserKeyListDataLoaded(SearchMode.Pattern, true)),
63+
() => dispatch(setBrowserKeyListDataLoaded(SearchMode.Pattern, false)),
6464
))
6565
dispatch(resetBrowserTree())
6666
dispatch(setBrowserSelectedKey(stringToBuffer(name)))

redisinsight/ui/src/pages/databaseAnalysis/components/top-namespace/Table.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ const NameSpacesTable = (props: Props) => {
7171
SearchMode.Pattern,
7272
'0',
7373
viewType === KeyViewType.Browser ? SCAN_COUNT_DEFAULT : SCAN_TREE_COUNT_DEFAULT,
74-
() => dispatch(setBrowserKeyListDataLoaded(true)),
75-
() => dispatch(setBrowserKeyListDataLoaded(false)),
74+
() => dispatch(setBrowserKeyListDataLoaded(SearchMode.Pattern, true)),
75+
() => dispatch(setBrowserKeyListDataLoaded(SearchMode.Pattern, false)),
7676
))
7777
dispatch(resetBrowserTree())
7878
history.push(Pages.browser(instanceId))

redisinsight/ui/src/pages/workbench/WorkbenchPage.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ describe('Telemetry', () => {
167167
expect(sendEventTelemetry).toBeCalledWith({
168168
event: TelemetryEvent.WORKBENCH_COMMAND_SUBMITTED,
169169
eventData: {
170-
command: 'info;',
170+
command: 'info;'.toUpperCase(),
171171
databaseId: INSTANCE_ID_MOCK,
172172
group: false,
173173
multiple: 'Single',
@@ -205,7 +205,7 @@ describe('Telemetry', () => {
205205
expect(sendEventTelemetry).toBeCalledWith({
206206
event: TelemetryEvent.WORKBENCH_COMMAND_SUBMITTED,
207207
eventData: {
208-
command: 'info;',
208+
command: 'info;'.toUpperCase(),
209209
databaseId: INSTANCE_ID_MOCK,
210210
group: false,
211211
multiple: 'Single',

redisinsight/ui/src/slices/app/context.ts

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,15 @@ import { BrowserStorageItem, DEFAULT_DELIMITER, KeyTypes } from 'uiSrc/constants
55
import { localStorageService } from 'uiSrc/services'
66
import { RootState } from '../store'
77
import { RedisResponseBuffer, StateAppContext } from '../interfaces'
8+
import { SearchMode } from '../interfaces/keys'
89

910
export const initialState: StateAppContext = {
1011
contextInstanceId: '',
1112
lastPage: '',
1213
browser: {
1314
keyList: {
14-
isDataLoaded: false,
15+
isDataPatternLoaded: false,
16+
isDataRedisearchLoaded: false,
1517
scrollPatternTopPosition: 0,
1618
scrollRedisearchTopPosition: 0,
1719
isNotRendered: true,
@@ -73,8 +75,11 @@ const appContextSlice = createSlice({
7375
setBrowserSelectedKey: (state, { payload }: { payload: Nullable<RedisResponseBuffer> }) => {
7476
state.browser.keyList.selectedKey = payload
7577
},
76-
setBrowserKeyListDataLoaded: (state, { payload }: { payload: boolean }) => {
77-
state.browser.keyList.isDataLoaded = payload
78+
setBrowserPatternKeyListDataLoaded: (state, { payload }: { payload: boolean }) => {
79+
state.browser.keyList.isDataPatternLoaded = payload
80+
},
81+
setBrowserRedisearchKeyListDataLoaded: (state, { payload }: { payload: boolean }) => {
82+
state.browser.keyList.isDataRedisearchLoaded = payload
7883
},
7984
setBrowserPatternScrollPosition: (state, { payload }: { payload: number }) => {
8085
state.browser.keyList.scrollPatternTopPosition = payload
@@ -176,7 +181,8 @@ const appContextSlice = createSlice({
176181
export const {
177182
setAppContextInitialState,
178183
setAppContextConnectedInstanceId,
179-
setBrowserKeyListDataLoaded,
184+
setBrowserPatternKeyListDataLoaded,
185+
setBrowserRedisearchKeyListDataLoaded,
180186
setBrowserSelectedKey,
181187
setBrowserPatternScrollPosition,
182188
setBrowserRedisearchScrollPosition,
@@ -222,3 +228,13 @@ export const appContextAnalytics = (state: RootState) =>
222228

223229
// The reducer
224230
export default appContextSlice.reducer
231+
232+
// Asynchronous thunk action
233+
export function setBrowserKeyListDataLoaded(
234+
searchMode: SearchMode,
235+
value: boolean,
236+
) {
237+
return searchMode === SearchMode.Pattern
238+
? setBrowserPatternKeyListDataLoaded(value)
239+
: setBrowserRedisearchKeyListDataLoaded(value)
240+
}

redisinsight/ui/src/slices/browser/keys.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -321,6 +321,8 @@ const keysSlice = createSlice({
321321

322322
resetPatternKeysData: (state) => {
323323
// state.data.keys = []
324+
state.data.total = 0
325+
state.data.scanned = 0
324326
state.data.keys.length = 0
325327
},
326328

redisinsight/ui/src/slices/browser/redisearch.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,8 @@ const redisearchSlice = createSlice({
150150
},
151151

152152
resetRedisearchKeysData: (state) => {
153+
state.data.total = 0
154+
state.data.scanned = 0
153155
state.data.keys.length = 0
154156
},
155157

0 commit comments

Comments
 (0)