Merge pull request #4294 from RedisInsight/be/feature/RI-5747-filter-per-ri-version-in-feature-config

RI-5747 filter per RI version in feature config

Author: mariasergeenko

redisinsight/api/src/modules/feature/providers/feature-flag/strategies/feature.flag.strategy.ts

@@ -11,6 +11,7 @@ import config, { Config } from 'src/utils/config';
 import { Feature } from 'src/modules/feature/model/feature';
 import { IFeatureFlag } from 'src/modules/feature/constants';
 import { SessionMetadata } from 'src/common/models';
+import { filterVersion } from 'src/utils/feature-version-filter.helper';
 
 const PATH_CONFIG = config.get('dir_path') as Config['dir_path'];
 
@@ -105,6 +106,10 @@ export abstract class FeatureFlagStrategy {
       if (filter instanceof FeatureConfigFilter) {
         const value = get(serverState, filter?.name);
 
+        if (filter?.name.match(/version/i)) {
+          return filterVersion(filter.cond, value, filter?.value);
+        }
+
         switch (filter?.cond) {
           case FeatureConfigFilterCondition.Eq:
             return value === filter?.value;

redisinsight/api/src/utils/feature-version-filter.helper.spec.ts

@@ -0,0 +1,65 @@
+// Import the function to test
+import { FeatureConfigFilterCondition } from 'src/modules/feature/model/features-config';
+import { filterVersion } from './feature-version-filter.helper';
+
+describe('filterVersion', () => {
+  it('should return true for Eq condition when versions are equal', () => {
+    expect(filterVersion(FeatureConfigFilterCondition.Eq, '1.0.0', '1.0.0')).toBe(true);
+  });
+
+  it('should return false for Eq condition when versions are not equal', () => {
+    expect(filterVersion(FeatureConfigFilterCondition.Eq, '1.0.1', '1.0.0')).toBe(false);
+  });
+
+  it('should return false for Neq condition when versions are equal', () => {
+    expect(filterVersion(FeatureConfigFilterCondition.Neq, '1.0.0', '1.0.0')).toBe(false);
+  });
+
+  it('should return true for Neq condition when versions are not equal', () => {
+    expect(filterVersion(FeatureConfigFilterCondition.Neq, '1.0.1', '1.0.0')).toBe(true);
+  });
+
+  it('should return true for Gt condition when first version is greater', () => {
+    expect(filterVersion(FeatureConfigFilterCondition.Gt, '1.0.1', '1.0.0')).toBe(true);
+  });
+
+  it('should return false for Gt condition when first version is not greater', () => {
+    expect(filterVersion(FeatureConfigFilterCondition.Gt, '1.0.0', '1.0.1')).toBe(false);
+  });
+
+  it('should return true for Gte condition when first version is greater', () => {
+    expect(filterVersion(FeatureConfigFilterCondition.Gte, '1.0.1', '1.0.0')).toBe(true);
+  });
+
+  it('should return true for Gte condition when versions are equal', () => {
+    expect(filterVersion(FeatureConfigFilterCondition.Gte, '1.0.0', '1.0.0')).toBe(true);
+  });
+
+  it('should return false for Gte condition when first version is less', () => {
+    expect(filterVersion(FeatureConfigFilterCondition.Gte, '1.0.0', '1.0.1')).toBe(false);
+  });
+
+  it('should return true for Lt condition when first version is less', () => {
+    expect(filterVersion(FeatureConfigFilterCondition.Lt, '1.0.0', '1.0.1')).toBe(true);
+  });
+
+  it('should return false for Lt condition when first version is not less', () => {
+    expect(filterVersion(FeatureConfigFilterCondition.Lt, '1.0.1', '1.0.0')).toBe(false);
+  });
+
+  it('should return true for Lte condition when first version is less', () => {
+    expect(filterVersion(FeatureConfigFilterCondition.Lte, '1.0.0', '1.0.1')).toBe(true);
+  });
+
+  it('should return true for Lte condition when versions are equal', () => {
+    expect(filterVersion(FeatureConfigFilterCondition.Lte, '1.0.0', '1.0.0')).toBe(true);
+  });
+
+  it('should return false for Lte condition when first version is greater', () => {
+    expect(filterVersion(FeatureConfigFilterCondition.Lte, '1.0.1', '1.0.0')).toBe(false);
+  });
+
+  it('should return false for unknown condition', () => {
+    expect(filterVersion('UnknownCondition' as FeatureConfigFilterCondition, '1.0.0', '1.0.0')).toBe(false);
+  });
+});

redisinsight/api/src/utils/feature-version-filter.helper.ts

@@ -0,0 +1,22 @@
+import { FeatureConfigFilterCondition } from 'src/modules/feature/model/features-config';
+import * as semverCompare from 'node-version-compare';
+
+export const filterVersion = (cond: FeatureConfigFilterCondition, value: string, filterValue: string) => {
+  const compareRes = semverCompare(value, filterValue);
+  switch (cond) {
+    case FeatureConfigFilterCondition.Eq:
+      return compareRes === 0;
+    case FeatureConfigFilterCondition.Neq:
+      return compareRes !== 0;
+    case FeatureConfigFilterCondition.Gt:
+      return compareRes > 0;
+    case FeatureConfigFilterCondition.Gte:
+      return compareRes >= 0;
+    case FeatureConfigFilterCondition.Lt:
+      return compareRes < 0;
+    case FeatureConfigFilterCondition.Lte:
+      return compareRes <= 0;
+    default:
+      return false;
+  }
+};