Merge pull request #2095 from RedisInsight/be/feature/RI-4521_recommendation_for_cluster

#RI-4521 - [BE] Recommendation doesn't appear correct for cluster

Author: egor-zalenski

redisinsight/api/src/modules/database-recommendation/scanner/strategies/big-amount-connected-clients.strategy.spec.ts

@@ -21,10 +21,13 @@ describe('BigAmountConnectedClientsStrategy', () => {
     });
 
     describe('cluster', () => {
-      it('should return true when connectedClients more then 100 in the first node', async () => {
+      it('should return true when connectedClients more then 100 in one of the nodes', async () => {
         expect(await strategy.isRecommendationReached({
           version: '1',
-          nodes: [{ version: '1', connectedClients: 101 }],
+          nodes: [
+            { version: '1', connectedClients: 1 },
+            { version: '2', connectedClients: 101 },
+          ],
         })).toEqual({ isReached: true });
       });
     });

redisinsight/api/src/modules/database-recommendation/scanner/strategies/big-amount-connected-clients.strategy.ts

@@ -1,3 +1,4 @@
+import { maxBy } from 'lodash';
 import { AbstractRecommendationStrategy }
   from 'src/modules/database-recommendation/scanner/strategies/abstract.recommendation.strategy';
 import { IDatabaseRecommendationStrategyData }
@@ -12,7 +13,7 @@ export class BigAmountConnectedClientsStrategy extends AbstractRecommendationStr
    */
 
   async isRecommendationReached(info: RedisDatabaseInfoResponse): Promise<IDatabaseRecommendationStrategyData> {
-    const nodeInfo = info.nodes?.length ? info.nodes[0] : info;
-    return { isReached: nodeInfo.connectedClients > BIG_AMOUNT_OF_CONNECTED_CLIENTS_RECOMMENDATION_CLIENTS };
+    const nodeInfo = info.nodes?.length ? maxBy(info.nodes, 'connectedClients') : info;
+    return { isReached: nodeInfo?.connectedClients > BIG_AMOUNT_OF_CONNECTED_CLIENTS_RECOMMENDATION_CLIENTS };
   }
 }