Skip to content

Commit e42e71e

Browse files
authored
Merge pull request #1647 from RedisInsight/revert-1633-fe/feature/RI-4021_Telemetry
Revert "#RI-4021 - Update telemetry WORKBENCH_COMMAND_COPY event"
2 parents 2b54301 + 2cd4cb3 commit e42e71e

File tree

2 files changed

+3
-31
lines changed

2 files changed

+3
-31
lines changed

redisinsight/ui/src/components/query-card/QueryCardHeader/QueryCardHeader.spec.tsx

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ import { cloneDeep } from 'lodash'
22
import React from 'react'
33
import { instance, mock } from 'ts-mockito'
44
import { cleanup, mockedStore, render, fireEvent, act, screen, waitForEuiToolTipVisible } from 'uiSrc/utils/test-utils'
5-
import { TelemetryEvent, sendEventTelemetry } from 'uiSrc/telemetry'
6-
import { INSTANCE_ID_MOCK } from 'uiSrc/mocks/handlers/instances/instancesHandlers'
75
import QueryCardHeader, { Props } from './QueryCardHeader'
86

97
const mockedProps = mock<Props>()
@@ -30,11 +28,6 @@ jest.mock('uiSrc/slices/app/plugins', () => ({
3028
}),
3129
}))
3230

33-
jest.mock('uiSrc/telemetry', () => ({
34-
...jest.requireActual('uiSrc/telemetry'),
35-
sendEventTelemetry: jest.fn(),
36-
}))
37-
3831
describe('QueryCardHeader', () => {
3932
it('should render', () => {
4033
// connectedInstanceSelector.mockImplementation(() => ({
@@ -64,25 +57,4 @@ describe('QueryCardHeader', () => {
6457

6558
expect(screen.getByTestId('copy-command')).toBeDisabled()
6659
})
67-
68-
it('should render disabled copy button', async () => {
69-
const command = 'info'
70-
const sendEventTelemetryMock = jest.fn();
71-
(sendEventTelemetry as jest.Mock).mockImplementation(() => sendEventTelemetryMock)
72-
render(<QueryCardHeader {...instance(mockedProps)} query={command} />)
73-
74-
await act(async () => {
75-
fireEvent.click(screen.getByTestId('copy-command'))
76-
})
77-
78-
expect(sendEventTelemetry).toBeCalledWith({
79-
event: TelemetryEvent.WORKBENCH_COMMAND_COPIED,
80-
eventData: {
81-
command,
82-
databaseId: INSTANCE_ID_MOCK,
83-
}
84-
});
85-
86-
(sendEventTelemetry as jest.Mock).mockRestore()
87-
})
8860
})

redisinsight/ui/src/components/query-card/QueryCardHeader/QueryCardHeader.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,8 @@ const QueryCardHeader = (props: Props) => {
129129
eventData: {
130130
databaseId: instanceId,
131131
command: getCommandNameFromQuery(query, COMMANDS_SPEC),
132+
rawMode: isRawMode(activeMode),
133+
group: isGroupMode(activeResultsMode),
132134
...additionalData
133135
}
134136
})
@@ -137,7 +139,7 @@ const QueryCardHeader = (props: Props) => {
137139
const handleCopy = (event: React.MouseEvent, query: string) => {
138140
sendEvent(TelemetryEvent.WORKBENCH_COMMAND_COPIED, query)
139141
eventStop(event)
140-
navigator.clipboard?.writeText?.(query)
142+
navigator.clipboard.writeText(query)
141143
}
142144

143145
const onDropDownViewClick = (event: React.MouseEvent) => {
@@ -154,8 +156,6 @@ const QueryCardHeader = (props: Props) => {
154156
TelemetryEvent.WORKBENCH_RESULT_VIEW_CHANGED,
155157
query,
156158
{
157-
rawMode: isRawMode(activeMode),
158-
group: isGroupMode(activeResultsMode),
159159
previousView: previousView.name,
160160
isPreviousViewInternal: !!previousView?.internal,
161161
currentView: currentView.name,

0 commit comments

Comments
 (0)