Add unit tests for conversion

Author: GnaneshKunal

redisinsight/ui/src/utils/formatters/bufferFormatters.ts

@@ -107,6 +107,53 @@ const ASCIIToBuffer = (strInit: string) => {
   return anyToBuffer(Array.from(Buffer.from(result, 'hex')))
 }
 
+const float32ArrayToBuffer = (vector: Float32Array) => {
+  const buffer = new ArrayBuffer(npVector.length * 4)
+  const dataView = new DataView(buffer)
+
+  for(let i = 0; i < npVector.length; i++) {
+    dataView.setFloat32(i * 4, npVector[i], true)
+  }
+
+  return new Uint8Array(buffer)
+}
+
+
+const float64ArrayToBuffer = (vector: Float64Array) => {
+  const buffer = new ArrayBuffer(npVector.length * 8)
+  const dataView = new DataView(buffer)
+
+  for(let i = 0; i < npVector.length; i++) {
+    dataView.setFloat64(i * 8, npVector[i], true)
+  }
+
+  return new Uint8Array(buffer)
+}
+
+
+const bufferToFloat32Array = (data: Uint8Array) => {
+  const buffer = new Uint8Array(data).buffer
+  const dataView = new DataView(buffer)
+  let vector = []
+
+  for(let i = 0; i < dataView.byteLength; i += 4) {
+    vector.push(dataView.getFloat32(i, true))
+  }
+  return new Float32Array(vector)
+}
+
+const bufferToFloat64Array = (data: Uint8Array) => {
+  const buffer = new Uint8Array(data).buffer
+  const dataView = new DataView(buffer)
+  const vector = []
+
+  for (let i = 0; i < dataView.byteLength; i += 8) {
+    vector.push(dataView.getFloat64(i, true))
+  }
+  return new Float64Array(vector)
+}
+
+
 const bufferToUint8Array = (reply: RedisResponseBuffer): Uint8Array => new Uint8Array(reply.data)
 const bufferToUTF8 = (reply: RedisResponseBuffer): string => decoder.decode(bufferToUint8Array(reply))
 
@@ -186,7 +233,11 @@ export {
   anyToBuffer,
   bufferToBinary,
   binaryToBuffer,
-  bufferToJava
+  bufferToJava,
+  bufferToFloat32Array,
+  bufferToFloat64Array,
+  float32ArrayToBuffer,
+  float64ArrayToBuffer,
 }
 
 window.ri = {

redisinsight/ui/src/utils/formatters/valueFormatters.tsx

@@ -21,6 +21,8 @@ import {
   stringToBuffer,
   binaryToBuffer,
   Maybe,
+  bufferToFloat64Array,
+  bufferToFloat32Array,
 } from 'uiSrc/utils'
 import { reSerializeJSON } from 'uiSrc/utils/formatters/json'
 
@@ -104,29 +106,18 @@ const formattingBuffer = (
     }
     case KeyValueFormat.Vector32Bit: {
       try {
-        let buffer = new Uint8Array(reply.data).buffer;
-        let dataView = new DataView(buffer);
-        let npVector = [];
-
-        for(let i = 0; i < dataView.byteLength; i+=4) {
-          npVector.push(dataView.getFloat32(i, true));
-        }
-        const value = JSONBigInt.stringify(npVector)
+        const vector = Array.from(bufferToFloat32Array(reply.data))
+        const value = JSONBigInt.stringify(vector)
         return JSONViewer({ value, ...props })
       } catch (e) {
         return { value: bufferToUTF8(reply), isValid: false }
       }
     }
     case KeyValueFormat.Vector64Bit: {
       try {
-        let buffer = new Uint8Array(reply.data).buffer;
-        let dataView = new DataView(buffer);
-        let npVector = [];
+        const vector = Array.from(bufferToFloat64Array(reply.data))
+        const value = JSONBigInt.stringify(vector)
 
-        for(let i = 0; i < dataView.byteLength; i+=8) {
-          npVector.push(dataView.getFloat64(i, true));
-        }
-        const value = JSONBigInt.stringify(npVector)
         return JSONViewer({ value, ...props })
       } catch (e) {
         return { value: bufferToUTF8(reply), isValid: false }
@@ -173,6 +164,8 @@ const bufferToSerializedFormat = (
     case KeyValueFormat.HEX: return bufferToHex(value)
     case KeyValueFormat.Binary: return bufferToBinary(value)
     case KeyValueFormat.JSON: return reSerializeJSON(bufferToUTF8(value), space)
+    case KeyValueFormat.Vector32Bit: return bufferToFloat32Array(value.data)
+    case KeyValueFormat.Vector64Bit: return bufferToFloat64Array(value.data)
     case KeyValueFormat.Msgpack: {
       try {
         const decoded = decode(Uint8Array.from(value.data))

redisinsight/ui/src/utils/tests/formatters/valueFormatters.spec.ts

@@ -22,6 +22,54 @@ describe('bufferToSerializedFormat', () => {
     })
   })
 
+  describe(KeyValueFormat.Vector32Bit, () => {
+    describe('should properly serialize', () => {
+      const testValues = [new Float32Array([1.0, 2.0]), new Float32Array([12.12, 13.41])].map((v) => {
+        input: anyToBuffer(v.buffer)
+        expected: JSON.stringify(v)
+      })
+
+      test.each(testValues)('test %j', ({input, expected }) => {
+        expect(JSON.stringify(bufferToSerializedFormat(KeyValueFormat.Vector32Bit, input))).toEqual(expected)
+      })
+    })
+
+    describe('should properly return value with invalid values', () => {
+      const testValues = [new Float32Array(['test'])].map((v) => {
+        input: anyToBuffer(v.buffer)
+        expected: JSON.stringify(v)
+      })
+
+      test.each(testValues)('test %j', ({input, expected }) => {
+        expect(JSON.stringify(bufferToSerializedFormat(KeyValueFormat.Vector32Bit, input))).toEqual(expected)
+      })
+    })
+  })
+
+  describe(KeyValueFormat.Vector64Bit, () => {
+    describe('should properly serialize', () => {
+      const testValues = [new Float64Array([1.0, 2.0]), new Float64Array([12.12, 13.41])].map((v) => {
+        input: anyToBuffer(v.buffer)
+        expected: JSON.stringify(v)
+      })
+
+      test.each(testValues)('test %j', ({input, expected }) => {
+        expect(JSON.stringify(bufferToSerializedFormat(KeyValueFormat.Vector64Bit, input))).toEqual(expected)
+      })
+    })
+
+    describe('should properly return value with invalid values', () => {
+      const testValues = [new Float64Array(['test'])].map((v) => {
+        input: anyToBuffer(v.buffer)
+        expected: JSON.stringify(v)
+      })
+
+      test.each(testValues)('test %j', ({input, expected }) => {
+        expect(JSON.stringify(bufferToSerializedFormat(KeyValueFormat.Vector64Bit, input))).toEqual(expected)
+      })
+    })
+  })
+
   describe(KeyValueFormat.Msgpack, () => {
     describe('should properly serialize', () => {
       const testValues = [{}, '""', 6677, true, { a: { b: [1, 2, '3'] } }].map((v) => ({