Merge pull request #561 from RedisInsight/add-utests

add unit tests + fix minor bug

Author: arthosofteq

redisinsight/api/src/__mocks__/profiler.ts

@@ -8,17 +8,19 @@ import { MockType } from 'src/__mocks__/common';
 import { TelemetryEvents } from 'src/constants';
 import * as MockedSocket from 'socket.io-mock';
 import { IMonitorData } from 'src/modules/profiler/interfaces/monitor-data.interface';
+import { LogFileProvider } from 'src/modules/profiler/providers/log-file.provider';
+import { MonitorSettings } from 'src/modules/profiler/models/monitor-settings';
 
 export const mockMonitorDataItemEmitted = {
   time: '14239988881.12341',
+  args: ['set', 'foo', 'bar'],
   source: '127.0.0.1',
   database: 0,
-  args: ['set', 'foo', 'bar'],
 };
 
 export const mockMonitorDataItem: IMonitorData = {
   ...mockMonitorDataItemEmitted,
-  shardOptions: null,
+  shardOptions: undefined,
 };
 
 export const mockSocket = new MockedSocket();
@@ -88,7 +90,20 @@ export const mockLogFile: LogFile = new LogFile('instanceid', testLogFileId, moc
 mockLogFile['getWriteStream'] = jest.fn();
 mockLogFile['addProfilerClient'] = jest.fn();
 mockLogFile['removeProfilerClient'] = jest.fn();
+mockLogFile['setAlias'] = jest.fn();
 mockLogFile['destroy'] = jest.fn();
 
-export const mockProfilerClientId = 'profiler-client-id';
-export const mockProfilerClient: ProfilerClient = new ProfilerClient(mockProfilerClientId, mockSocket);
+export const mockProfilerClient: ProfilerClient = new ProfilerClient(mockSocket.id, mockSocket);
+mockProfilerClient['handleOnData'] = jest.fn();
+mockProfilerClient['handleOnDisconnect'] = jest.fn();
+
+export const mockMonitorSettings: MonitorSettings = {
+  logFileId: testLogFileId,
+};
+
+export const mockLogFileProvider: MockType<LogFileProvider> = {
+  getOrCreate: jest.fn(),
+  get: jest.fn(),
+  getDownloadData: jest.fn(),
+  onModuleDestroy: jest.fn(),
+};

redisinsight/api/src/modules/profiler/models/log-file.spec.ts

@@ -16,7 +16,6 @@ describe('LogFile', () => {
 
   beforeEach(() => {
     logFile = new LogFile(mockLogFile.instanceId, mockLogFile.id, mockProfilerAnalyticsEvents);
-    jest.resetAllMocks();
   });
 
   it('Initialization', () => {
@@ -98,9 +97,9 @@ describe('LogFile', () => {
     expect(fs.existsSync(logFile['filePath'])).toEqual(false);
     const stream = logFile.getWriteStream();
     expect(stream['_writableState'].ended).toEqual(false);
-    stream.write('somedata');
-    await new Promise((r) => setTimeout(r, 500));
-    expect(fs.existsSync(logFile['filePath'])).toEqual(true);
+    stream.write('somedata', () => {
+      expect(fs.existsSync(logFile['filePath'])).toEqual(true);
+    });
     expect(logFile['writeStream']).toEqual(stream);
     await logFile.destroy();
     expect(logFile['writeStream']).toEqual(null);

redisinsight/api/src/modules/profiler/models/log-file.ts

@@ -43,6 +43,7 @@ export class LogFile {
    */
   getWriteStream(): WriteStream {
     if (!this.writeStream) {
+      fs.ensureFileSync(this.filePath);
       this.writeStream = fs.createWriteStream(this.filePath, { flags: 'a' });
     }
     this.writeStream.on('error', () => {});
@@ -54,6 +55,7 @@ export class LogFile {
    * Used to download file using http server
    */
   getReadStream(): ReadStream {
+    fs.ensureFileSync(this.filePath);
     const stream = fs.createReadStream(this.filePath);
     stream.once('end', () => {
       stream.destroy();

redisinsight/api/src/modules/profiler/models/profiler.client.spec.ts

@@ -57,53 +57,3 @@ describe('ProfilerClient', () => {
     expect(mockLogEmitter.removeProfilerClient).toHaveBeenCalledWith(profilerClient.id);
   });
 });
-
-// import { WsException } from '@nestjs/websockets';
-// import * as MockedSocket from 'socket.io-mock';
-// import ERROR_MESSAGES from 'src/constants/error-messages';
-// import { MonitorGatewayServerEvents } from 'src/modules/profiler/constants/events';
-// import { ProfilerClient } from './profiler.client';
-// import { IOnDatePayload } from '../interfaces/client-monitor-observer.interface';
-//
-// describe('ClientMonitorObserver', () => {
-//   let socketClient;
-//
-//   beforeEach(() => {
-//     socketClient = new MockedSocket();
-//     socketClient.id = '123';
-//     socketClient.emit = jest.fn();
-//   });
-//
-//   it.only('should be defined', () => {
-//     const client = new ProfilerClient(socketClient.id, socketClient);
-//
-//     expect(client.id).toEqual(socketClient.id);
-//   });
-//   it.only('should emit event on monitorData', async () => {
-//     const client = new ProfilerClient(socketClient.id, socketClient);
-//     const monitorData = {
-//       // unix timestamp
-//       time: `${(new Date()).getTime() / 1000}`,
-//       source: '127.0.0.1:58612',
-//       database: 0,
-//       args: ['set', 'foo', 'bar'],
-//     };
-//     const payload: IOnDatePayload = { ...monitorData, shardOptions: { host: '127.0.0.1', port: 6379 } };
-//
-//     client.handleOnData(payload);
-//
-//     await new Promise((r) => setTimeout(r, 500));
-//
-//     expect(socketClient.emit).toHaveBeenCalledWith(MonitorGatewayServerEvents.Data, [monitorData]);
-//   });
-//   it.only('should emit exception event', () => {
-//     const client = new ProfilerClient(socketClient.id, socketClient);
-//
-//     client.handleOnDisconnect();
-//
-//     expect(socketClient.emit).toHaveBeenCalledWith(
-//       MonitorGatewayServerEvents.Exception,
-//       new WsException(ERROR_MESSAGES.NO_CONNECTION_TO_REDIS_DB),
-//     );
-//   });
-// });